krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-16 14:17:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix user receiving Joined Challenged achievement when creating a challenge (#10559)

Browse Source 
* Fix joinedChallenge achievement being awarded when creating a challenge

* Modify test to check that achievement is not awarded for creating a challenge
This commit is contained in:
Alex Figueroa
2018-07-30 07:00:05 -07:00
committed by Matteo Pagliazzi
parent 774a1d9a96
commit 5566460541
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/api/v3/integration/challenges/POST-challenges.test.js
View File

@@ -304,14 +304,14 @@ describe('POST /challenges', () => {
expect(groupLeader.challenges.length).to.equal(0); expect(groupLeader.challenges.length).to.equal(0);
}); });
it('awards achievement if this is creator\'s first challenge', async () => { it('does not award joinedChallenge achievement for creating a challenge', async () => {
await groupLeader.post('/challenges', { await groupLeader.post('/challenges', {
group: group._id, group: group._id,
name: 'Test Challenge', name: 'Test Challenge',
shortName: 'TC Label', shortName: 'TC Label',
}); });
groupLeader = await groupLeader.sync(); groupLeader = await groupLeader.sync();
expect(groupLeader.achievements.joinedChallenge).to.be.true; expect(groupLeader.achievements.joinedChallenge).to.not.be.true;
}); });
it('sets summary to challenges name when not supplied', async () => { it('sets summary to challenges name when not supplied', async () => {

2
website/server/libs/challenges/index.js
View File

@@ -79,8 +79,6 @@ export async function createChallenge (user, req, res) {
let challengeValidationErrors = challenge.validateSync(); let challengeValidationErrors = challenge.validateSync();
if (challengeValidationErrors) throw challengeValidationErrors; if (challengeValidationErrors) throw challengeValidationErrors;
addUserJoinChallengeNotification(user);
let results = await Promise.all([challenge.save({ let results = await Promise.all([challenge.save({
validateBeforeSave: false, // already validated validateBeforeSave: false, // already validated
}), group.save(), user.save()]); }), group.save(), user.save()]);