From 5566460541f2a519d1ab79db6ab4f8c107d8b9d0 Mon Sep 17 00:00:00 2001 From: Alex Figueroa Date: Mon, 30 Jul 2018 07:00:05 -0700 Subject: [PATCH] Fix user receiving Joined Challenged achievement when creating a challenge (#10559) * Fix joinedChallenge achievement being awarded when creating a challenge * Modify test to check that achievement is not awarded for creating a challenge --- test/api/v3/integration/challenges/POST-challenges.test.js | 4 ++-- website/server/libs/challenges/index.js | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/test/api/v3/integration/challenges/POST-challenges.test.js b/test/api/v3/integration/challenges/POST-challenges.test.js index c70b41806f..0176a729ff 100644 --- a/test/api/v3/integration/challenges/POST-challenges.test.js +++ b/test/api/v3/integration/challenges/POST-challenges.test.js @@ -304,14 +304,14 @@ describe('POST /challenges', () => { expect(groupLeader.challenges.length).to.equal(0); }); - it('awards achievement if this is creator\'s first challenge', async () => { + it('does not award joinedChallenge achievement for creating a challenge', async () => { await groupLeader.post('/challenges', { group: group._id, name: 'Test Challenge', shortName: 'TC Label', }); groupLeader = await groupLeader.sync(); - expect(groupLeader.achievements.joinedChallenge).to.be.true; + expect(groupLeader.achievements.joinedChallenge).to.not.be.true; }); it('sets summary to challenges name when not supplied', async () => { diff --git a/website/server/libs/challenges/index.js b/website/server/libs/challenges/index.js index 9feb91b925..764cdf907b 100644 --- a/website/server/libs/challenges/index.js +++ b/website/server/libs/challenges/index.js @@ -79,8 +79,6 @@ export async function createChallenge (user, req, res) { let challengeValidationErrors = challenge.validateSync(); if (challengeValidationErrors) throw challengeValidationErrors; - addUserJoinChallengeNotification(user); - let results = await Promise.all([challenge.save({ validateBeforeSave: false, // already validated }), group.save(), user.save()]);