Reorganize and set stub behavior

test/common/user.fns.buy.test.js

@@ -27,12 +27,7 @@ describe('user.fns.buy', function() {
 
     shared.wrap(user);
 
-    sinon.stub(user.fns, 'randomVal', function(obj) {
+    sinon.stub(user.fns, 'randomVal');
-      // too many predictableRandom calls to stub, let's return the last element
-      var last = _.last(obj);
-      return last;
-    });
-
     sinon.stub(user.fns, 'predictableRandom');
   });
 
@@ -82,6 +77,7 @@ describe('user.fns.buy', function() {
       user.items.food = {};
     });
 
+    context('failure conditions', function() {
       it('does not open if user does not have enough gold', function(done) {
         user.fns.predictableRandom.returns(YIELD_EQUIPMENT);
         user.stats.gp = 50;
@@ -107,6 +103,54 @@ describe('user.fns.buy', function() {
           done();
         });
       });
+    });
+
+    context('non-gear awards', function() {
+      it('gives Experience', function() {
+        user.fns.predictableRandom.returns(YIELD_EXP);
+
+        user.ops.buy({params: {key: 'armoire'}})
+
+        expect(user.items.gear.owned).to.eql({'weapon_warrior_0': true});
+        expect(user.items.food).to.be.empty;
+        expect(user.stats.exp).to.eql(46);
+        expect(user.stats.gp).to.eql(100);
+      });
+
+      it('gives food', function() {
+        var honey = Content.food.Honey;
+        user.fns.randomVal.returns(honey);
+        user.fns.predictableRandom.returns(YIELD_FOOD);
+
+        user.ops.buy({params: {key: 'armoire'}})
+
+        expect(user.items.gear.owned).to.eql({'weapon_warrior_0': true});
+        expect(user.items.food).to.eql({'Honey': 1});
+        expect(user.stats.exp).to.eql(0);
+        expect(user.stats.gp).to.eql(100);
+      });
+
+      it('does not give equipment if all equipment has been found', function() {
+        user.fns.predictableRandom.returns(YIELD_EQUIPMENT);
+        user.items.gear.owned = fullArmoire;
+        user.stats.gp = 150;
+
+        user.ops.buy({params: {key: 'armoire'}});
+
+        expect(user.items.gear.owned).to.eql(fullArmoire);
+        var armoireCount = shared.count.remainingGearInSet(user.items.gear.owned, 'armoire');
+        expect(armoireCount).to.eql(0);
+
+        expect(user.stats.exp).to.eql(30);
+        expect(user.stats.gp).to.eql(50);
+      });
+    });
+
+    context('gear awards', function() {
+      beforeEach(function() {
+        var shield = Content.gear.tree.shield.armoire.gladiatorShield;
+        user.fns.randomVal.returns(shield);
+      });
 
       it('always drops equipment the first time', function() {
         delete user.flags.armoireOpened;
@@ -126,28 +170,6 @@ describe('user.fns.buy', function() {
         expect(user.stats.gp).to.eql(100);
       });
 
-    it('gives Experience', function() {
-      user.fns.predictableRandom.returns(YIELD_EXP);
-
-      user.ops.buy({params: {key: 'armoire'}})
-
-      expect(user.items.gear.owned).to.eql({'weapon_warrior_0': true});
-      expect(user.items.food).to.be.empty;
-      expect(user.stats.exp).to.eql(46);
-      expect(user.stats.gp).to.eql(100);
-    });
-
-    it('gives food', function() {
-      user.fns.predictableRandom.returns(YIELD_FOOD);
-
-      user.ops.buy({params: {key: 'armoire'}})
-
-      expect(user.items.gear.owned).to.eql({'weapon_warrior_0': true});
-      expect(user.items.food).to.eql({'Honey': 1});
-      expect(user.stats.exp).to.eql(0);
-      expect(user.stats.gp).to.eql(100);
-    });
-
       it('gives more equipment', function() {
         user.fns.predictableRandom.returns(YIELD_EQUIPMENT);
         user.items.gear.owned = {
@@ -163,20 +185,6 @@ describe('user.fns.buy', function() {
         expect(armoireCount).to.eql((_.size(fullArmoire) - 2));
         expect(user.stats.gp).to.eql(100);
       });
-
-    it('does not give equipment if all equipment has been found', function() {
-      user.fns.predictableRandom.returns(YIELD_EQUIPMENT);
-      user.items.gear.owned = fullArmoire;
-      user.stats.gp = 150;
-
-      user.ops.buy({params: {key: 'armoire'}});
-
-      expect(user.items.gear.owned).to.eql(fullArmoire);
-      var armoireCount = shared.count.remainingGearInSet(user.items.gear.owned, 'armoire');
-      expect(armoireCount).to.eql(0);
-
-      expect(user.stats.exp).to.eql(30);
-      expect(user.stats.gp).to.eql(50);
     });
   });
 });