krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 07:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'release' into develop

Browse Source
This commit is contained in:
Matteo Pagliazzi
2020-10-18 19:16:25 +02:00
parent 8b1c009990 43efe2d6d6
commit 2cfc765e39
4 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
package-lock.json generated
View File

@@ -1,6 +1,6 @@
{
"name": "habitica",
"version": "4.165.0",
"version": "4.165.1",
"lockfileVersion": 1,
"requires": true,
"dependencies": {

2
package.json
View File

@@ -1,7 +1,7 @@
{
"name": "habitica",
"description": "A habit tracker app which treats your goals like a Role Playing Game.",
"version": "4.165.0",
"version": "4.165.1",
"main": "./website/server/index.js",
"dependencies": {
"@babel/core": "^7.11.6",

12
test/api/unit/middlewares/cronMiddleware.js
View File

@@ -311,8 +311,8 @@ describe('cron middleware', () => {
});
});
it('does not enroll 80% of users', async () => {
sandbox.stub(Math, 'random').returns(0.5);
it('does not enroll 50% of users', async () => {
sandbox.stub(Math, 'random').returns(0.6);
user.lastCron = moment(new Date()).subtract({ days: 2 });
await user.save();
req.headers['x-client'] = 'habitica-web';
@@ -328,8 +328,8 @@ describe('cron middleware', () => {
});
});
it('enables the new notification for 10% of users', async () => {
sandbox.stub(Math, 'random').returns(0.1);
it('enables the new notification for 25% of users', async () => {
sandbox.stub(Math, 'random').returns(0.25);
user.lastCron = moment(new Date()).subtract({ days: 2 });
await user.save();
req.headers['x-client'] = 'habitica-web';
@@ -345,8 +345,8 @@ describe('cron middleware', () => {
});
});
it('disables the new notification for 10% of users', async () => {
sandbox.stub(Math, 'random').returns(0.2);
it('disables the new notification for 25% of users', async () => {
sandbox.stub(Math, 'random').returns(0.5);
user.lastCron = moment(new Date()).subtract({ days: 2 });
await user.save();
req.headers['x-client'] = 'habitica-web';

4
website/server/middlewares/cron.js
View File

@@ -61,9 +61,9 @@ function dropCapABTest (user, req) {
if (isWeb && !user._ABtests.dropCapNotif && !user.isSubscribed()) {
const testGroup = Math.random();
// Enroll 20% of users, splitting them 50/50
if (testGroup <= 0.1) {
if (testGroup <= 0.25) {
user._ABtests.dropCapNotif = 'drop-cap-notif-enabled';
} else if (testGroup <= 0.2) {
} else if (testGroup <= 0.5) {
user._ABtests.dropCapNotif = 'drop-cap-notif-disabled';
} else {
user._ABtests.dropCapNotif = 'drop-cap-notif-not-enrolled';