diff --git a/package-lock.json b/package-lock.json index 16520e405b..003830fc14 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "habitica", - "version": "4.165.0", + "version": "4.165.1", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index d97a540387..ecd984a226 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "habitica", "description": "A habit tracker app which treats your goals like a Role Playing Game.", - "version": "4.165.0", + "version": "4.165.1", "main": "./website/server/index.js", "dependencies": { "@babel/core": "^7.11.6", diff --git a/test/api/unit/middlewares/cronMiddleware.js b/test/api/unit/middlewares/cronMiddleware.js index 6e2ab0e18a..7491d59c69 100644 --- a/test/api/unit/middlewares/cronMiddleware.js +++ b/test/api/unit/middlewares/cronMiddleware.js @@ -311,8 +311,8 @@ describe('cron middleware', () => { }); }); - it('does not enroll 80% of users', async () => { - sandbox.stub(Math, 'random').returns(0.5); + it('does not enroll 50% of users', async () => { + sandbox.stub(Math, 'random').returns(0.6); user.lastCron = moment(new Date()).subtract({ days: 2 }); await user.save(); req.headers['x-client'] = 'habitica-web'; @@ -328,8 +328,8 @@ describe('cron middleware', () => { }); }); - it('enables the new notification for 10% of users', async () => { - sandbox.stub(Math, 'random').returns(0.1); + it('enables the new notification for 25% of users', async () => { + sandbox.stub(Math, 'random').returns(0.25); user.lastCron = moment(new Date()).subtract({ days: 2 }); await user.save(); req.headers['x-client'] = 'habitica-web'; @@ -345,8 +345,8 @@ describe('cron middleware', () => { }); }); - it('disables the new notification for 10% of users', async () => { - sandbox.stub(Math, 'random').returns(0.2); + it('disables the new notification for 25% of users', async () => { + sandbox.stub(Math, 'random').returns(0.5); user.lastCron = moment(new Date()).subtract({ days: 2 }); await user.save(); req.headers['x-client'] = 'habitica-web'; diff --git a/website/server/middlewares/cron.js b/website/server/middlewares/cron.js index ce004a2f68..8b8f8be59e 100644 --- a/website/server/middlewares/cron.js +++ b/website/server/middlewares/cron.js @@ -61,9 +61,9 @@ function dropCapABTest (user, req) { if (isWeb && !user._ABtests.dropCapNotif && !user.isSubscribed()) { const testGroup = Math.random(); // Enroll 20% of users, splitting them 50/50 - if (testGroup <= 0.1) { + if (testGroup <= 0.25) { user._ABtests.dropCapNotif = 'drop-cap-notif-enabled'; - } else if (testGroup <= 0.2) { + } else if (testGroup <= 0.5) { user._ABtests.dropCapNotif = 'drop-cap-notif-disabled'; } else { user._ABtests.dropCapNotif = 'drop-cap-notif-not-enrolled';