Reordered Magic Hatching Potions, fixes issue 8465 (#8467)

* Moved Royal Purple to top of list, ordered other mounts from Spring to Winter

* Issue 8465, moved Royal Purple to top and arranged other pets/mounts from Spring-Winter

* Fixed whitespacing mistake from previous commit

* Magic Hatching Potions reordered by season

website/common/script/content/hatching-potions.js

@@ -49,17 +49,16 @@ let drops = {
 };
 
 let premium = {
-  Spooky: {
+  RoyalPurple: {
     value: 2,
-    text: t('hatchingPotionSpooky'),
+    text: t('hatchingPotionRoyalPurple'),
     limited: true,
-    _season: 'fall',
   },
-  Peppermint: {
+  Cupid: {
     value: 2,
-    text: t('hatchingPotionPeppermint'),
+    text: t('hatchingPotionCupid'),
     limited: true,
-    _season: 'winter',
+    _season: 'valentines',
   },
   Floral: {
     value: 2,
@@ -73,28 +72,29 @@ let premium = {
     limited: true,
     _season: 'summer',
   },
+  Spooky: {
+    value: 2,
+    text: t('hatchingPotionSpooky'),
+    limited: true,
+    _season: 'fall',
+  },
   Ghost: {
     value: 2,
     text: t('hatchingPotionGhost'),
     limited: true,
     _season: 'fall',
   },
-  RoyalPurple: {
-    value: 2,
-    text: t('hatchingPotionRoyalPurple'),
-    limited: true,
-  },
   Holly: {
     value: 2,
     text: t('hatchingPotionHolly'),
     limited: true,
     _season: 'winter',
   },
-  Cupid: {
+  Peppermint: {
     value: 2,
-    text: t('hatchingPotionCupid'),
+    text: t('hatchingPotionPeppermint'),
     limited: true,
-    _season: 'valentines',
+    _season: 'winter',
   },
 };