krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-10-26 10:42:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(party members): clone array to avoid infinite loops, fixes #11969

Browse Source
This commit is contained in:
Matteo Pagliazzi
2020-03-13 23:48:10 +01:00
parent e94631a002
commit 1411706963
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
website/client/src/components/groups/membersModal.vue
View File

@@ -475,7 +475,7 @@ export default {
return this.$store.state.memberModalOptions.challengeId;
},
sortedMembers () {
let sortedMembers = this.members;
let sortedMembers = this.members.slice(); // shallow clone to avoid infinite loop
if (!isEmpty(this.sortOption)) {
// Use the memberlist filtered by searchTerm

2
website/client/src/components/header/index.vue
View File

@@ -170,7 +170,7 @@ export default {
return Math.floor(this.currentWidth / 140) + 1;
},
sortedPartyMembers () {
let sortedMembers = this.partyMembers;
let sortedMembers = this.partyMembers.slice(); // shallow clone to avoid infinite loop
const { order, orderAscending } = this.user.party;
if (order === 'profile.name') {