fix isOnQuest function to correctly check for quest being active - fixes https://github.com/HabitRPG/habitrpg/issues/5518

This commit is contained in:
Alys
2015-06-29 19:40:06 +10:00
parent a4e9e5dbfc
commit 03d1f12a7c

View File

@@ -193,9 +193,8 @@ GroupSchema.methods.finishQuest = function(quest, cb) {
mongoose.model('User').update(q, updates, {multi:true}, cb);
}
// FIXME this is a temporary measure, we need to remove quests from users when they traverse parties
function isOnQuest(user,progress,group){
return group && progress && user.party.quest.key && user.party.quest.key == group.quest.key;
return group && progress && user.party.quest.key && group.quest && user.party.quest.key == group.quest.key && group.quest.active;
}
GroupSchema.statics.collectQuest = function(user, progress, cb) {