From 03d1f12a7cccec9567f3407ccf21c97186aba550 Mon Sep 17 00:00:00 2001
From: Alys <alice.harris@oldgods.net>
Date: Mon, 29 Jun 2015 19:40:06 +1000
Subject: [PATCH] fix isOnQuest function to correctly check for quest being
 active - fixes https://github.com/HabitRPG/habitrpg/issues/5518

---
 website/src/models/group.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/website/src/models/group.js b/website/src/models/group.js
index 7f5629b53d..ab4c468248 100644
--- a/website/src/models/group.js
+++ b/website/src/models/group.js
@@ -193,9 +193,8 @@ GroupSchema.methods.finishQuest = function(quest, cb) {
   mongoose.model('User').update(q, updates, {multi:true}, cb);
 }
 
-// FIXME this is a temporary measure, we need to remove quests from users when they traverse parties
 function isOnQuest(user,progress,group){
-  return group && progress && user.party.quest.key && user.party.quest.key == group.quest.key;
+  return group && progress && user.party.quest.key && group.quest && user.party.quest.key == group.quest.key && group.quest.active;
 }
 
 GroupSchema.statics.collectQuest = function(user, progress, cb) {