mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-17 06:37:23 +01:00
* Add new API call to complete multiple task scorings in one call * Improve API response * Improve saving process * Improve handling for multiple tasks scored at once * Handle challenge task errors better * Improve check for alias * Improve check for task scorings * Fix merge errors * make nodemon ignore content_cache * Fix completing group tasks * fix test * fix tests (again) * typo * WIP(a11y): task modal updates * fix(tasks): borders in modal * fix(tasks): circley locks * fix(task-modal): placeholders * WIP(task-modal): disabled states, hide empty options, +/- restyle * fix(task-modal): box shadows instead of borders, habit control pointer * fix(task-modal): button states? * fix(modal): tighten up layout, new spacing utils * fix(tasks): more stylin * fix(tasks): habit hovers * fix(css): checklist labels, a11y colors * fix(css): one more missed hover issue * fix(css): lock Challenges, label fixes * fix(css): scope input/textarea changes * fix(style): task tweakies * fix(style): more button fixage * WIP(component): start select list story * working example of a templated selectList * fix(style): more button corrections * fix(lint): EOL * fix(buttons): factor btn-secondary to better override Bootstrap * fix(styles): standardize more buttons * wip: difficulty select - style fixes * selectDifficulty works! 🎉 - fix styles * change the dropdown-item sizes only for the selectList ones * selectTranslatedArray * changed many label margins * more correct dropdown style * fix(modals): button corrections * input-group styling + datetime picker without today button * Style/margins for "repeat every" - extract selectTag.vue * working tag-selection / update - cleanup * fix stories * fix svg color on create modal (purple) * fix task modal bottom padding * correct dropdown shadow * update dropdown-toggle caret size / color * fixed checklist style * sync checked state * selectTag padding * fix spacing between positive/negative streak inputs * toggle-checkbox + fix some spacings * disable repeat-on when its a groupTask * fix new checklist-item * fix toggle-checkbox style - fix difficulty style * fix checklist ui * add tags label , when there arent any tags selected * WORKING select-tag component 🎉 * fix taglist story * show max 5 items in tag dropdown + "X more" label * fix datetime clear button * replace m-b-xs to mb-1 (bootstrap) - fix input-group-text style * fix styles of advanced settings * fix delete task styles * always show grippy on hover of the item * extract modal-text-input mixin + fix the borders/dropshadow * fix(spacing): revert most to Bootstrap * feat(checklists): make local copy of master checklist non-editable also aggressively update checklists because they weren't syncing?? * fix(checklists): handle add/remove options better * feat(teams): manager notes field * fix select/dropdown styles * input border + icon colors * delete task underline color * fix checklist "delete icon" vertical position * selectTag fixes - normal open/close toggle working again - remove icon color * fixing icons: Trash can - Delete Little X - Remove Big X - Close Block - Block * fix taglist margins / icon sizes * wip margin overview (in storybook) * fix routerlink * remove unused method * new selectTag style + add markdown inside tagList + scrollable tag selection * fix selectTag / selectList active border * fix difficulty select (svg default color) * fix input padding-left + fix reset habit streak fullwidth / padding + "repeat every" gray text (no border) * feat(teams): improved approval request > approve > reward flow * fix(tests): address failures * fix(lint): oops only * fix(tasks): short-circuit group related logic * fix(tasks): more short circuiting * fix(tasks): more lines, less lint * fix(tasks): how do i keep missing these * feat(teams): provide assigning user summary * fix(teams): don't attempt to record assiging user if not supplied * fix advanced-settings styling / margin * fix merge + hide advanced streak settings when none enabled * fix styles * set Roboto font for advanced settings * Add Challenge flag to the tag list * add tag with enter, when no other tag is found * fix styles + tag cancel button * refactor footer / margin * split repeat fields into option mt-3 groups * button all the things * fix(tasks): style updates * no hover state for non-editable tasks on team board * keep assign/claim footer on task after requesting approval * disable more fields on user copy of team task, and remove hover states for them * fix(tasks): functional revisions * "Claim Rewards" instead of "x" in task approved notif * Remove default transition supplied by Bootstrap, apply individually to some elements * Delete individual tasks and related notifications when master task deleted from team board * Manager notes now save when supplied at task initial creation * Can no longer dismiss rewards from approved task by hitting Dismiss All * fix(tasks): clean tasksOrder also adjust related test expectation * fix(tests): adjust integration expectations * fix(test): ratzen fratzen only * fix lint * fix tests * fix(teams): checklist, notes * handleSharedCompletion: handle error, make sure it is run after the user task has been saved * fix typo * correctly handle errors in handleSharedCompletion when approving a task * fix(teams): improve disabled states * handleSharedCompletion: do not increase completions by 1 manually to adjust for last approval not saved yet * revert changes to config.json.example * fix(teams): more style fixage * add unit tests for findMultipleByIdOrAlias * exclude api v4 route from apidocs * BREAKING(teams): return 202 instead of 401 for approval request * fix(teams): better taskboard sync also re-re-fix checklist borders * scoreTasks: validate body * fix tests, move string to api errors * fix(tests): update expectations for breaking change * start updating api docs, process tasks sequentially to avoid conflicts with user._tmp * do not crash entire bulk operation in case of errors * save task only if modified * fix lint * undo changes to error handling: either all tasks scoring are successfull or none * remove stale code * do not return user._tmp when bulk scoring, it would be the last version only * make sure user._tmp.leveledUp is not lost when bulk scoring * rewards tests * mixed tests * fix tests, allow scoring the same task multiple times * finish integration tests * fix api docs for the bulk score route * refactor(task-modal): lockable label component * wip loading spinner * refactor(teams): move task scoring to mixin * fix(teams): style corrections * fix(btn): fix padding to have height of 32px * implement loading spinner * remove console.log warnings * fix(tasks): spacing and wording corrections * fix(teams): don't bork manager notes * fix(teams): assignment fix and more approval flow revisions * WIP(teams): use tag dropdown control for assignment * finish merge - never throw an error when a group task requires approval (wip - needs tests) * fix taskModal merge * fix merge * fix(task modal): add newline * fix(column.vue): add newline at end of file * mvp yesterdaily modal * fix tests * fix api docs for bulk scoring group tasks * separate task scoring and _tmp handling * handle _tmp when bulk scoring * rya: close modal before calling cron API, prevents issues with modals * rya: fix conflicts with other modals * add sounds, support for group plans, analytics * use asyncResource for group plans * fix lint * streak bonus: add comment about missing in rya * move yesterdailyModal * fix issues with level up modals and rya * add comments for future use, fix level up modals not showing up at levels with a quest drop * handle errors in rya modal * bundle quest and crit notifications Co-authored-by: Phillip Thelen <phillip@habitica.com> Co-authored-by: Phillip Thelen <viirus@pherth.net> Co-authored-by: Sabe Jones <sabrecat@gmail.com> Co-authored-by: negue <eugen.bolz@gmail.com>
560 lines
19 KiB
JavaScript
560 lines
19 KiB
JavaScript
import { authWithHeaders } from '../../../middlewares/auth';
|
|
import * as Tasks from '../../../models/task';
|
|
import { model as Group } from '../../../models/group';
|
|
import { model as User } from '../../../models/user';
|
|
import {
|
|
BadRequest,
|
|
NotFound,
|
|
NotAuthorized,
|
|
} from '../../../libs/errors';
|
|
import {
|
|
createTasks,
|
|
getTasks,
|
|
moveTask,
|
|
} from '../../../libs/taskManager';
|
|
import { handleSharedCompletion } from '../../../libs/groupTasks';
|
|
import apiError from '../../../libs/apiError';
|
|
import logger from '../../../libs/logger';
|
|
|
|
const requiredGroupFields = '_id leader tasksOrder name';
|
|
// @TODO: abstract to task lib
|
|
const types = Tasks.tasksTypes.map(type => `${type}s`);
|
|
// _allCompletedTodos is currently in BETA and is likely to be removed in future
|
|
types.push('completedTodos', '_allCompletedTodos');
|
|
|
|
// @TODO abstract this snipped (also see api-v3/tasks.js)
|
|
function canNotEditTasks (group, user, assignedUserId) {
|
|
const isNotGroupLeader = group.leader !== user._id;
|
|
const isManager = Boolean(group.managers[user._id]);
|
|
const userIsAssigningToSelf = Boolean(assignedUserId && user._id === assignedUserId);
|
|
return isNotGroupLeader && !isManager && !userIsAssigningToSelf;
|
|
}
|
|
|
|
const api = {};
|
|
|
|
/**
|
|
* @api {post} /api/v3/tasks/group/:groupId Create a new task belonging to a group
|
|
* @apiDescription Can be passed an object to create a single task or
|
|
* an array of objects to create multiple tasks.
|
|
* @apiName CreateGroupTasks
|
|
* @apiGroup Task
|
|
*
|
|
* @apiParam (Path) {UUID} groupId The id of the group the new task(s) will belong to
|
|
*
|
|
* @apiSuccess data An object if a single task was created, otherwise an array of tasks
|
|
*/
|
|
api.createGroupTasks = {
|
|
method: 'POST',
|
|
url: '/tasks/group/:groupId',
|
|
middlewares: [authWithHeaders()],
|
|
async handler (req, res) {
|
|
req.checkParams('groupId', apiError('groupIdRequired')).notEmpty().isUUID();
|
|
|
|
const reqValidationErrors = req.validationErrors();
|
|
if (reqValidationErrors) throw reqValidationErrors;
|
|
|
|
const { user } = res.locals;
|
|
|
|
const fields = requiredGroupFields.concat(' managers');
|
|
const group = await Group.getGroup({ user, groupId: req.params.groupId, fields });
|
|
if (!group) throw new NotFound(res.t('groupNotFound'));
|
|
|
|
if (canNotEditTasks(group, user)) throw new NotAuthorized(res.t('onlyGroupLeaderCanEditTasks'));
|
|
|
|
const tasks = await createTasks(req, res, { user, group });
|
|
|
|
res.respond(201, tasks.length === 1 ? tasks[0] : tasks);
|
|
|
|
tasks.forEach(task => {
|
|
res.analytics.track('task create', {
|
|
uuid: user._id,
|
|
hitType: 'event',
|
|
category: 'behavior',
|
|
taskType: task.type,
|
|
groupID: group._id,
|
|
});
|
|
});
|
|
},
|
|
};
|
|
|
|
/**
|
|
* @api {get} /api/v3/tasks/group/:groupId Get a group's tasks
|
|
* @apiName GetGroupTasks
|
|
* @apiGroup Task
|
|
*
|
|
* @apiParam (Path) {UUID} groupId The id of the group from which to retrieve the tasks
|
|
* @apiParam (Query) {string="habits","dailys","todos","rewards"} [type] Query parameter to
|
|
* return just a type of tasks
|
|
*
|
|
* @apiSuccess {Array} data An array of tasks
|
|
*/
|
|
api.getGroupTasks = {
|
|
method: 'GET',
|
|
url: '/tasks/group/:groupId',
|
|
middlewares: [authWithHeaders()],
|
|
async handler (req, res) {
|
|
req.checkParams('groupId', apiError('groupIdRequired')).notEmpty().isUUID();
|
|
req.checkQuery('type', res.t('invalidTasksType')).optional().isIn(types);
|
|
|
|
const validationErrors = req.validationErrors();
|
|
if (validationErrors) throw validationErrors;
|
|
|
|
const { user } = res.locals;
|
|
|
|
const group = await Group.getGroup({
|
|
user,
|
|
groupId: req.params.groupId,
|
|
fields: requiredGroupFields,
|
|
});
|
|
if (!group) throw new NotFound(res.t('groupNotFound'));
|
|
|
|
const tasks = await getTasks(req, res, { user, group });
|
|
res.respond(200, tasks);
|
|
},
|
|
};
|
|
|
|
/**
|
|
* @api {post} /api/v3/group/:groupId/tasks/:taskId/move/to/:position
|
|
* Move a group task to a specified position
|
|
* @apiDescription Moves a group task to a specified position
|
|
* @apiVersion 3.0.0
|
|
* @apiName GroupMoveTask
|
|
* @apiGroup Task
|
|
*
|
|
* @apiParam (Path) {String} taskId The task _id
|
|
* @apiParam (Path) {Number} position Where to move the task (-1 means push to bottom).
|
|
* First position is 0
|
|
*
|
|
* @apiSuccess {Array} data The new tasks order (group.tasksOrder.{task.type}s)
|
|
*/
|
|
api.groupMoveTask = {
|
|
method: 'POST',
|
|
url: '/group-tasks/:taskId/move/to/:position',
|
|
middlewares: [authWithHeaders()],
|
|
async handler (req, res) {
|
|
req.checkParams('taskId', apiError('taskIdRequired')).notEmpty();
|
|
req.checkParams('position', res.t('positionRequired')).notEmpty().isNumeric();
|
|
|
|
const reqValidationErrors = req.validationErrors();
|
|
if (reqValidationErrors) throw reqValidationErrors;
|
|
|
|
const { user } = res.locals;
|
|
|
|
const { taskId } = req.params;
|
|
const task = await Tasks.Task.findOne({
|
|
_id: taskId,
|
|
}).exec();
|
|
|
|
const to = Number(req.params.position);
|
|
|
|
if (!task) {
|
|
throw new NotFound(res.t('taskNotFound'));
|
|
}
|
|
|
|
if (task.type === 'todo' && task.completed) throw new BadRequest(res.t('cantMoveCompletedTodo'));
|
|
|
|
const group = await Group.getGroup({
|
|
user,
|
|
groupId: task.group.id,
|
|
fields: requiredGroupFields,
|
|
});
|
|
if (!group) throw new NotFound(res.t('groupNotFound'));
|
|
|
|
if (group.leader !== user._id) throw new NotAuthorized(res.t('onlyGroupLeaderCanEditTasks'));
|
|
|
|
const order = group.tasksOrder[`${task.type}s`];
|
|
|
|
moveTask(order, task._id, to);
|
|
|
|
await group.save();
|
|
res.respond(200, order);
|
|
},
|
|
};
|
|
|
|
/**
|
|
* @api {post} /api/v3/tasks/:taskId/assign/:assignedUserId Assign a group task to a user
|
|
* @apiDescription Assigns a user to a group task
|
|
* @apiName AssignTask
|
|
* @apiGroup Task
|
|
*
|
|
* @apiParam (Path) {UUID} taskId The id of the task that will be assigned
|
|
* @apiParam (Path) {UUID} assignedUserId The id of the user that will be assigned to the task
|
|
*
|
|
* @apiSuccess data The assigned task
|
|
*/
|
|
api.assignTask = {
|
|
method: 'POST',
|
|
url: '/tasks/:taskId/assign/:assignedUserId',
|
|
middlewares: [authWithHeaders()],
|
|
async handler (req, res) {
|
|
req.checkParams('taskId', apiError('taskIdRequired')).notEmpty().isUUID();
|
|
req.checkParams('assignedUserId', res.t('userIdRequired')).notEmpty().isUUID();
|
|
|
|
const reqValidationErrors = req.validationErrors();
|
|
if (reqValidationErrors) throw reqValidationErrors;
|
|
|
|
const { user } = res.locals;
|
|
const { assignedUserId } = req.params;
|
|
const assignedUser = await User.findById(assignedUserId).exec();
|
|
|
|
const { taskId } = req.params;
|
|
const task = await Tasks.Task.findByIdOrAlias(taskId, user._id);
|
|
|
|
if (!task) {
|
|
throw new NotFound(res.t('taskNotFound'));
|
|
}
|
|
|
|
if (!task.group.id) {
|
|
throw new NotAuthorized(res.t('onlyGroupTasksCanBeAssigned'));
|
|
}
|
|
|
|
const groupFields = `${requiredGroupFields} chat managers`;
|
|
const group = await Group.getGroup({ user, groupId: task.group.id, fields: groupFields });
|
|
if (!group) throw new NotFound(res.t('groupNotFound'));
|
|
|
|
if (canNotEditTasks(group, user, assignedUserId)) throw new NotAuthorized(res.t('onlyGroupLeaderCanEditTasks'));
|
|
|
|
const promises = [];
|
|
const taskText = task.text;
|
|
const userName = `@${user.auth.local.username}`;
|
|
|
|
if (user._id === assignedUserId) {
|
|
const managerIds = Object.keys(group.managers);
|
|
managerIds.push(group.leader);
|
|
const managers = await User.find({ _id: managerIds }, 'notifications preferences').exec();
|
|
managers.forEach(manager => {
|
|
if (manager._id === user._id) return;
|
|
manager.addNotification('GROUP_TASK_CLAIMED', {
|
|
message: res.t('taskClaimed', { userName, taskText }, manager.preferences.language),
|
|
groupId: group._id,
|
|
taskId: task._id,
|
|
});
|
|
promises.push(manager.save());
|
|
});
|
|
} else {
|
|
assignedUser.addNotification('GROUP_TASK_ASSIGNED', {
|
|
message: res.t('youHaveBeenAssignedTask', { managerName: userName, taskText }),
|
|
taskId: task._id,
|
|
});
|
|
}
|
|
|
|
promises.push(group.syncTask(task, assignedUser, user));
|
|
promises.push(group.save());
|
|
await Promise.all(promises);
|
|
|
|
res.respond(200, task);
|
|
},
|
|
};
|
|
|
|
/**
|
|
* @api {post} /api/v3/tasks/:taskId/unassign/:assignedUserId Unassign a user from a task
|
|
* @apiDescription Unassigns a user from a group task
|
|
* @apiName UnassignTask
|
|
* @apiGroup Task
|
|
*
|
|
* @apiParam (Path) {UUID} taskId The id of the task that is the original group task
|
|
* @apiParam (Path) {UUID} assignedUserId The id of the user that will be unassigned from the task
|
|
*
|
|
* @apiSuccess data The unassigned task
|
|
*/
|
|
api.unassignTask = {
|
|
method: 'POST',
|
|
url: '/tasks/:taskId/unassign/:assignedUserId',
|
|
middlewares: [authWithHeaders()],
|
|
async handler (req, res) {
|
|
req.checkParams('taskId', apiError('taskIdRequired')).notEmpty().isUUID();
|
|
req.checkParams('assignedUserId', res.t('userIdRequired')).notEmpty().isUUID();
|
|
|
|
const reqValidationErrors = req.validationErrors();
|
|
if (reqValidationErrors) throw reqValidationErrors;
|
|
|
|
const { user } = res.locals;
|
|
const { assignedUserId } = req.params;
|
|
const assignedUser = await User.findById(assignedUserId).exec();
|
|
|
|
const { taskId } = req.params;
|
|
const task = await Tasks.Task.findByIdOrAlias(taskId, user._id);
|
|
|
|
if (!task) {
|
|
throw new NotFound(res.t('taskNotFound'));
|
|
}
|
|
|
|
if (!task.group.id) {
|
|
throw new NotAuthorized(res.t('onlyGroupTasksCanBeAssigned'));
|
|
}
|
|
|
|
const fields = requiredGroupFields.concat(' managers');
|
|
const group = await Group.getGroup({ user, groupId: task.group.id, fields });
|
|
if (!group) throw new NotFound(res.t('groupNotFound'));
|
|
|
|
if (canNotEditTasks(group, user, assignedUserId)) throw new NotAuthorized(res.t('onlyGroupLeaderCanEditTasks'));
|
|
|
|
await group.unlinkTask(task, assignedUser);
|
|
|
|
const notificationIndex = assignedUser.notifications.findIndex(notification => notification && notification.data && notification.type === 'GROUP_TASK_ASSIGNED' && notification.data.taskId === task._id);
|
|
|
|
if (notificationIndex !== -1) {
|
|
assignedUser.notifications.splice(notificationIndex, 1);
|
|
await assignedUser.save();
|
|
}
|
|
|
|
res.respond(200, task);
|
|
},
|
|
};
|
|
|
|
/**
|
|
* @api {post} /api/v3/tasks/:taskId/approve/:userId Approve a user's task
|
|
* @apiDescription Approves a user assigned to a group task
|
|
* @apiVersion 3.0.0
|
|
* @apiName ApproveTask
|
|
* @apiGroup Task
|
|
*
|
|
* @apiParam (Path) {UUID} taskId The id of the task that is the original group task
|
|
* @apiParam (Path) {UUID} userId The id of the user that will be approved
|
|
*
|
|
* @apiSuccess task The approved task
|
|
*/
|
|
api.approveTask = {
|
|
method: 'POST',
|
|
url: '/tasks/:taskId/approve/:userId',
|
|
middlewares: [authWithHeaders()],
|
|
async handler (req, res) {
|
|
req.checkParams('taskId', apiError('taskIdRequired')).notEmpty().isUUID();
|
|
req.checkParams('userId', res.t('userIdRequired')).notEmpty().isUUID();
|
|
|
|
const reqValidationErrors = req.validationErrors();
|
|
if (reqValidationErrors) throw reqValidationErrors;
|
|
|
|
const { user } = res.locals;
|
|
const assignedUserId = req.params.userId;
|
|
const assignedUser = await User.findById(assignedUserId).exec();
|
|
|
|
const { taskId } = req.params;
|
|
const task = await Tasks.Task.findOne({
|
|
'group.taskId': taskId,
|
|
userId: assignedUserId,
|
|
}).exec();
|
|
|
|
if (!task) {
|
|
throw new NotFound(res.t('taskNotFound'));
|
|
}
|
|
|
|
const fields = requiredGroupFields.concat(' managers');
|
|
const group = await Group.getGroup({ user, groupId: task.group.id, fields });
|
|
if (!group) throw new NotFound(res.t('groupNotFound'));
|
|
|
|
if (canNotEditTasks(group, user)) throw new NotAuthorized(res.t('onlyGroupLeaderCanEditTasks'));
|
|
if (task.group.approval.approved === true) throw new NotAuthorized(res.t('canOnlyApproveTaskOnce'));
|
|
if (!task.group.approval.requested) {
|
|
throw new NotAuthorized(res.t('taskApprovalWasNotRequested'));
|
|
}
|
|
|
|
task.group.approval.dateApproved = new Date();
|
|
task.group.approval.approvingUser = user._id;
|
|
task.group.approval.approved = true;
|
|
|
|
// Get Managers
|
|
const managerIds = Object.keys(group.managers);
|
|
managerIds.push(group.leader);
|
|
const managers = await User.find({ _id: managerIds }, 'notifications').exec(); // Use this method so we can get access to notifications
|
|
|
|
// Get task direction
|
|
const firstManagerNotifications = managers[0].notifications;
|
|
const firstNotificationIndex = firstManagerNotifications.findIndex(notification => notification && notification.data && notification.data.taskId === task._id && notification.type === 'GROUP_TASK_APPROVAL');
|
|
let direction = 'up';
|
|
if (firstManagerNotifications[firstNotificationIndex]) {
|
|
direction = firstManagerNotifications[firstNotificationIndex].direction || direction;
|
|
}
|
|
|
|
// Remove old notifications
|
|
const approvalPromises = [];
|
|
managers.forEach(manager => {
|
|
const notificationIndex = manager.notifications.findIndex(notification => notification && notification.data && notification.data.taskId === task._id && notification.type === 'GROUP_TASK_APPROVAL');
|
|
|
|
if (notificationIndex !== -1) {
|
|
manager.notifications.splice(notificationIndex, 1);
|
|
approvalPromises.push(manager.save());
|
|
}
|
|
});
|
|
|
|
// Add new notifications to user
|
|
assignedUser.addNotification('GROUP_TASK_APPROVED', {
|
|
message: res.t('yourTaskHasBeenApproved', { taskText: task.text }),
|
|
groupId: group._id,
|
|
task,
|
|
direction,
|
|
});
|
|
|
|
approvalPromises.push(task.save());
|
|
approvalPromises.push(assignedUser.save());
|
|
await Promise.all(approvalPromises);
|
|
|
|
res.respond(200, task);
|
|
|
|
// Wrapping everything in a try/catch block because if an error occurs
|
|
// using `await` it MUST NOT bubble up because the request has already been handled
|
|
try {
|
|
const groupTask = await Tasks.Task.findOne({
|
|
_id: task.group.taskId,
|
|
}).exec();
|
|
|
|
if (groupTask) {
|
|
await handleSharedCompletion(groupTask, task);
|
|
}
|
|
} catch (e) {
|
|
logger.error('Error handling group task', e);
|
|
}
|
|
},
|
|
};
|
|
|
|
/**
|
|
* @api {post} /api/v3/tasks/:taskId/needs-work/:userId Require more work for a group task
|
|
* @apiDescription Mark an assigned group task as needing more work before it can be approved
|
|
* @apiVersion 3.0.0
|
|
* @apiName TaskNeedsWork
|
|
* @apiGroup Task
|
|
*
|
|
* @apiParam (Path) {UUID} taskId The id of the task that is the original group task
|
|
* @apiParam (Path) {UUID} userId The id of the assigned user
|
|
*
|
|
* @apiSuccess task The task that needs more work
|
|
*/
|
|
api.taskNeedsWork = {
|
|
method: 'POST',
|
|
url: '/tasks/:taskId/needs-work/:userId',
|
|
middlewares: [authWithHeaders()],
|
|
async handler (req, res) {
|
|
req.checkParams('taskId', apiError('taskIdRequired')).notEmpty().isUUID();
|
|
req.checkParams('userId', res.t('userIdRequired')).notEmpty().isUUID();
|
|
|
|
const reqValidationErrors = req.validationErrors();
|
|
if (reqValidationErrors) throw reqValidationErrors;
|
|
|
|
const { user } = res.locals;
|
|
|
|
const assignedUserId = req.params.userId;
|
|
const { taskId } = req.params;
|
|
|
|
const [assignedUser, task] = await Promise.all([
|
|
User.findById(assignedUserId).exec(),
|
|
await Tasks.Task.findOne({
|
|
'group.taskId': taskId,
|
|
userId: assignedUserId,
|
|
}).exec(),
|
|
]);
|
|
|
|
if (!task) {
|
|
throw new NotFound(res.t('taskNotFound'));
|
|
}
|
|
|
|
const fields = requiredGroupFields.concat(' managers');
|
|
const group = await Group.getGroup({ user, groupId: task.group.id, fields });
|
|
if (!group) throw new NotFound(res.t('groupNotFound'));
|
|
|
|
if (canNotEditTasks(group, user)) throw new NotAuthorized(res.t('onlyGroupLeaderCanEditTasks'));
|
|
if (task.group.approval.approved === true) throw new NotAuthorized(res.t('canOnlyApproveTaskOnce'));
|
|
if (!task.group.approval.requested) {
|
|
throw new NotAuthorized(res.t('taskApprovalWasNotRequested'));
|
|
}
|
|
|
|
// Get Managers
|
|
const managerIds = Object.keys(group.managers);
|
|
managerIds.push(group.leader);
|
|
const managers = await User.find({ _id: managerIds }, 'notifications').exec(); // Use this method so we can get access to notifications
|
|
|
|
const promises = [];
|
|
|
|
// Remove old notifications
|
|
managers.forEach(manager => {
|
|
const notificationIndex = manager.notifications.findIndex(notification => notification && notification.data && notification.data.taskId === task._id && notification.type === 'GROUP_TASK_APPROVAL');
|
|
|
|
if (notificationIndex !== -1) {
|
|
manager.notifications.splice(notificationIndex, 1);
|
|
promises.push(manager.save());
|
|
}
|
|
});
|
|
|
|
task.group.approval.requested = false;
|
|
task.group.approval.requestedDate = undefined;
|
|
|
|
const taskText = task.text;
|
|
const managerName = user.profile.name;
|
|
|
|
const message = res.t('taskNeedsWork', { taskText, managerName }, assignedUser.preferences.language);
|
|
|
|
assignedUser.addNotification('GROUP_TASK_NEEDS_WORK', {
|
|
message,
|
|
task: {
|
|
id: task._id,
|
|
text: taskText,
|
|
},
|
|
group: {
|
|
id: group._id,
|
|
name: group.name,
|
|
},
|
|
manager: {
|
|
id: user._id,
|
|
name: managerName,
|
|
},
|
|
});
|
|
|
|
await Promise.all([...promises, assignedUser.save(), task.save()]);
|
|
|
|
res.respond(200, task);
|
|
},
|
|
};
|
|
|
|
/**
|
|
* @api {get} /api/v3/approvals/group/:groupId Get a group's approvals
|
|
* @apiVersion 3.0.0
|
|
* @apiName GetGroupApprovals
|
|
* @apiGroup Task
|
|
*
|
|
* @apiParam (Path) {UUID} groupId The id of the group from which to retrieve the approvals
|
|
*
|
|
* @apiSuccess {Array} data An array of tasks
|
|
*/
|
|
api.getGroupApprovals = {
|
|
method: 'GET',
|
|
url: '/approvals/group/:groupId',
|
|
middlewares: [authWithHeaders()],
|
|
async handler (req, res) {
|
|
req.checkParams('groupId', apiError('groupIdRequired')).notEmpty().isUUID();
|
|
|
|
const validationErrors = req.validationErrors();
|
|
if (validationErrors) throw validationErrors;
|
|
|
|
const { user } = res.locals;
|
|
const { groupId } = req.params;
|
|
|
|
const fields = requiredGroupFields.concat(' managers');
|
|
const group = await Group.getGroup({ user, groupId, fields });
|
|
if (!group) throw new NotFound(res.t('groupNotFound'));
|
|
|
|
let approvals;
|
|
if (canNotEditTasks(group, user)) {
|
|
approvals = await Tasks.Task.find({
|
|
'group.id': groupId,
|
|
'group.approval.approved': false,
|
|
'group.approval.requested': true,
|
|
'group.assignedUsers': user._id,
|
|
userId: user._id,
|
|
}, 'userId group text')
|
|
.populate('userId', 'profile')
|
|
.exec();
|
|
} else {
|
|
approvals = await Tasks.Task.find({
|
|
'group.id': groupId,
|
|
'group.approval.approved': false,
|
|
'group.approval.requested': true,
|
|
}, 'userId group text')
|
|
.populate('userId', 'profile')
|
|
.exec();
|
|
}
|
|
|
|
res.respond(200, approvals);
|
|
},
|
|
};
|
|
|
|
export default api;
|