mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-16 14:17:22 +01:00
* Begin refactoring news API to return individual markdown posts * Implement simple bailey CMS * Prevented users with lvl less than 10 from seeing mana * Added in class checks and notification tests * Added getter use * Fixed class check * chore(i18n): update locales * 4.60.2 * remove tests that are no longer needed because we won't be purging private messages (#10670) Ref: this comment from paglias: https://github.com/HabitRPG/habitica/issues/7940#issuecomment-406489506 * remove .only * allow challenge leader/owner to view/join/modify challenge in private group they've left - fixes #9753 (#10606) * rename hasAccess to canJoin for challenges This is so the function won't be used accidentally for other purposes, since hasAccess could be misinterpretted. * add isLeader function for challenges * allow challenge leader to join/modify/end challenge when they're not in the private group it's in * delete duplicate test * clarify title of existing tests * add tests and adjust existing tests to reduce privileges of test users * fix lint errors * remove pointless isLeader check (it's checked in canJoin) * Correct Challenges tooltip in Guild view (#10667) * Fix new party member cannot join pending quest (#10648) * Saved sort selection into local storage for later use - fixes #10432 (#10655) * Saved sort selection into local storage for later use * Updated code to use userLocalManager module * Fix initial position item info when selecting one item after another (fixes #10077) (#10661) * Update lastMouseMoveEvent even when dragging an egg or potion. * Update lastMouseMoveEvent even when dragging a food item. * Refactor/market vue (#10601) * extract inventoryDrawer from market * show scrollbar only if needed * extract featuredItemsHeader / pinUtils * extract pageLayout * extract layoutSection / filterDropdown - fix sortByNumber * rollback sortByNumber order-fix * move equipment lists out of the layout-section (for now) * refactor sellModal * extract checkbox * extract equipment section * extract category row * revert scroll - remove sellModal item template * fix(lint): commas and semis * Created category item component (#10613) * extract filter sidebar * fix gemCount - fix raising the item count if the item wasn't previously owned * fixes #10659 * remove unneeded method * fix typo when importing component * feat(content): Forest Friends Quest Bundle * chore(sprites): compile * chore(i18n): update locales * 4.60.3 * fix(bcrypt): install fork compatible with Node 8 * chore(i18n): update locales * 4.60.4 * add swear words - TRIGGER / CONTENT WARNING: assault, slurs, swearwords, etc * add pinUtils-mixin - fixes #10682 (#10683) * chore(news): Bailey * chore(i18n): update locales * 4.60.5 * Improve rendering banner about sleeping in the inn See #10695 * Display settings in one column * Small Updates (#10701) * small updates * fix client unit test * fix uuid validation * Revert "Small Updates (#10701)" (#10702) This reverts commitdd7fa73961. * feat(event): Fall Festival 2018 * chore(sprites): compile * chore(i18n): update locales * 4.61.0 * Move inbox to its own model (#10428) * shared model for chat and inbox * disable inbox schema * inbox: use separate model * remove old code that used group.chat * add back chat field (not used) and remove old tests * remove inbox exclusions when loading user * add GET /api/v3/inbox/messages * add comment * implement DELETE /inbox/messages/:messageid in v4 * implement GET /inbox/messages in v4 and update tests * implement DELETE /api/v4/inbox/clear * fix url * fix doc * update /export/inbox.html * update other data exports * add back messages in user schema * add user.toJSONWithInbox * add compativility until migration is done * more compatibility * fix tojson called twice * add compatibility methods * fix common tests * fix v4 integration tests * v3 get user -> with inbox * start to fix tests * fix v3 integration tests * wip * wip, client use new route * update tests for members/send-private-message * tests for get user in v4 * add tests for DELETE /inbox/messages/:messageId * add tests for DELETE /inbox/clear in v4 * update docs * fix tests * initial migration * fix migration * fix migration * migration fixes * migrate api.enterCouponCode * migrate api.castSpell * migrate reset, reroll, rebirth * add routes to v4 version * fix tests * fixes * api.updateUser * remove .only * get user -> userLib * refactor inbox.vue to work with new data model * fix return message when messaging yourself * wip fix bug with new conversation * wip * fix remaining ui issues * move api.registerLocal, fixes * keep only v3 version of GET /inbox/messages * Fix API early Stat Point allocation (#10680) * Refactor hasClass check to common so it can be used in shared & server-side code * Check that user has selected class before allocating stat points * chore(event): end Ember Hatching Potions * chore(analytics): reenable navigation tracking * update bcrypt * Point achievement modal links to main site (#10709) * Animal ears after death (#10691) * Animal Ears purchasable with Gold if lost in Death * remove ears from pinned items when set is bought * standardise css and error handling for gems and coins * revert accidental new line * fix client tests * Reduce margin-bottom of checklist-item from 10px to -3px. (#10684) * chore(i18n): update locales * 4.61.1 * Position inn banner when window is resized * feat(content): Subscriber Items and Magic Potions * chore(sprites): compile * chore(i18n): update locales * 4.62.0 * Update inn banner handling * Fix banner offset on initial load * Fix minor issues. * Issue: 10660 - Fixed. Changed default to Please Enter A Value (#10718) * Issue: 10660 - Fixed. Changed default to Please Enter A Value * Issue: 10660 - Fixed/revision 2 Changed default to Enter A Value * chore(news): Bailey announcements * chore(i18n): update locales * 4.62.1 * adjust wiki link for usernameInfo string https://github.com/HabitRPG/habitica-private/issues/7#issuecomment-425405425 * raise coverage for tasks api calls (#10029) * - updates a group task - approval is required - updates a group task with checklist * add expect to test the new checklist length * - moves tasks to a specified position out of length * remove unused line * website getter tasks tests * re-add sanitizeUserChallengeTask * change config.json.example variable to be a string not a boolean * fix tests - pick the text / up/down props too * fix test - remove changes on text/up/down - revert sanitize condition - revert sanitization props * chore(i18n): update locales * 4.62.2 * chore(news): Bailey * chore(i18n): update locales * 4.62.3 * inbox: fix avatar display and order * Username announcement (#10729) * Change update username API call The call no longer requires a password and also validates the username. * Implement API call to verify username without setting it * Improve coding style * Apply username verification to registration * Update error messages * Validate display names. * Fix API early Stat Point allocation (#10680) * Refactor hasClass check to common so it can be used in shared & server-side code * Check that user has selected class before allocating stat points * chore(event): end Ember Hatching Potions * chore(analytics): reenable navigation tracking * update bcrypt * Point achievement modal links to main site (#10709) * Animal ears after death (#10691) * Animal Ears purchasable with Gold if lost in Death * remove ears from pinned items when set is bought * standardise css and error handling for gems and coins * revert accidental new line * fix client tests * Reduce margin-bottom of checklist-item from 10px to -3px. (#10684) * chore(i18n): update locales * 4.61.1 * feat(content): Subscriber Items and Magic Potions * chore(sprites): compile * chore(i18n): update locales * 4.62.0 * Display notification for users to confirm their username * fix typo * WIP(usernames): Changes to address #10694 * WIP(usernames): Further changes for #10694 * fix(usernames): don't show spurious headings * Change verify username notification to new version * Improve feedback for invalid usernames * Allow user to set their username again to confirm it * Improve validation display for usernames * Temporarily move display name validation outside of schema * Improve rendering banner about sleeping in the inn See #10695 * Display settings in one column * Position inn banner when window is resized * Update inn banner handling * Fix banner offset on initial load * Fix minor issues. * Issue: 10660 - Fixed. Changed default to Please Enter A Value (#10718) * Issue: 10660 - Fixed. Changed default to Please Enter A Value * Issue: 10660 - Fixed/revision 2 Changed default to Enter A Value * chore(news): Bailey announcements * chore(i18n): update locales * 4.62.1 * adjust wiki link for usernameInfo string https://github.com/HabitRPG/habitica-private/issues/7#issuecomment-425405425 * raise coverage for tasks api calls (#10029) * - updates a group task - approval is required - updates a group task with checklist * add expect to test the new checklist length * - moves tasks to a specified position out of length * remove unused line * website getter tasks tests * re-add sanitizeUserChallengeTask * change config.json.example variable to be a string not a boolean * fix tests - pick the text / up/down props too * fix test - remove changes on text/up/down - revert sanitize condition - revert sanitization props * Change update username API call The call no longer requires a password and also validates the username. * feat(content): Subscriber Items and Magic Potions * Re-add register call * Fix merge issue * Fix issue with setting username * Implement new alert style * Display username confirmation status in settings * Add disclaimer to change username field * validate username in settings * Allow specific fields to be focused when opening site settings * Implement requested changes. * Fix merge issue * Fix failing tests * verify username when users register with username and password * Set ID for change username notification * Disable submit button if username is invalid * Improve username confirmation handling * refactor(settings): address remaining code comments on auth form * Revert "refactor(settings): address remaining code comments on auth form" This reverts commit9b6609ad64. * Social user username (#10620) * Refactored private functions to library * Refactored social login code * Added username to social registration * Changed id library * Added new local auth check * Fixed export error. Fixed password check error * fix(settings): password not available on client * refactor(settings): more sensible placement of methods * chore(migration): script to hand out procgen usernames * fix(migration): don't give EVERYONE new names you doofus * fix(migration): limit data retrieved, be extra careful about updates * fix(migration): use missing field, not migration tag, for query * fix(migration): unused var * fix(usernames): only generate 20 characters * fix(migration): set lowerCaseUsername * fix(lint): comma * fix(lint): comma spacing * chore(i18n): update locales * 4.63.0 * chore(news): Bailey * chore(i18n): update locales * 4.63.1 * fix(usernames): various Reword invalid characters error Correct typo in slur error Remove extraneous Confirm button Reset username field if empty on blur Restore ability to add local auth to social login * fix(auth): account for new username paradigm in add-local flow * fix(auth): alert on successful addLocal * chore(i18n): update locales * 4.63.2 * fix(auth): Don't try to check existing username on new reg * 4.63.3 * feat(content): Armoire and BGs 2018/10 * chore(sprites): compile * fix(passport): use graph API v2.8 * chore(i18n): update locales * 4.64.0 * Begin refactoring news API to return individual markdown posts * Implement simple bailey CMS * remove old news markdown * Correctly display images in bailey modal * Remove need for newStuff migration * Add basic tests * Fix authentication issue * Fix tests * Update news model * add API route to get single post * remove news admin frontend code * fix lint error * Fix merge mixups * Fix lint errors * fix api call * fix lint error * Fix issues caused by merging * remove console log * Improve news display * Correctly update users notifications * Fix date display for news posts * Fix tests * remove old cache file * correctly create date * correctly create promise * Better check for existance. * Improve docs * Fix minor issues * Add method to get latest post * fix lint errors * use correct call for 404 * add comment about old newStuff field * paginate news * Fix lint errors * Remove unnecessary await * Fix broken tests * ... * correct existence check * fix database queries * change approach to cached news posts * fix tests * Change how news posts are cached * Fetch last news post at an interval * Fix typos and other small things * add new permission for modifying bailey posts * add test for ensureNewsPoster * return last news post with legacy api * Fix test * Hopefully fix test * change fields to _id * Fixes * Fixes * fix test * Fixes * make all tests pass * fix lint * id -> _id * _id -> id * remove identical tell me later route from api v4 * fix lint * user model: fix issues with newStuff * improve user#toJSONTransform * fix typo * improve newsPost.js * fix(integration tests): do not return flags.newStuff if it was not selected * fix news controller * server side fixes, start refactoring client * more client fixes * automatically set author * new stuff: show one post per user + drafts * change default border radius for modals to 8px * required fields and defaults * slit news into its own component and fix static page * noNewsPoster: move from i18n to apiError * remove unused strings * fix unit tests * update apidocs * add backward comparibility for flags.newStuff in api v3 * fix integration tests * POST news: make integration test independent of number of posts * api v3 news: render markdown * static new-stuff: add padding and fix when user not logged in * test flags.newStuff * api v3: test setting flags.newStuff on PUT /user * refactor news post cache and add tests * remove new locales file * more resilient tests * more resilient tests * refactor tests for NewsPost.updateLastNewsPost * api v4: fix tests * api v3: fix tests * can set flags.newStuff in api v4 Co-authored-by: Keith Holliday <keithrholliday@gmail.com> Co-authored-by: Sabe Jones <sabrecat@gmail.com> Co-authored-by: Alys <Alys@users.noreply.github.com> Co-authored-by: Matteo Pagliazzi <matteopagliazzi@gmail.com> Co-authored-by: Carl Vuorinen <carl.vuorinen@gmail.com> Co-authored-by: Rene Cordier <rene.cordier@gmail.com> Co-authored-by: Forrest Hatfield <github@forresthatfield.com> Co-authored-by: lucubro <88whacko@gmail.com> Co-authored-by: negue <negue@users.noreply.github.com> Co-authored-by: Alys <alice.harris@oldgods.net> Co-authored-by: J.D. Sandifer <sandifer.jd@gmail.com> Co-authored-by: Kirsty <kirsty-tortoise@users.noreply.github.com> Co-authored-by: beatscribe <rattjp@gmail.com> Co-authored-by: Phillip Thelen <phillip@habitica.com>
300 lines
8.7 KiB
JavaScript
300 lines
8.7 KiB
JavaScript
import { each, get } from 'lodash';
|
|
import {
|
|
generateUser,
|
|
translate as t,
|
|
} from '../../../../helpers/api-integration/v3';
|
|
import { model as NewsPost } from '../../../../../website/server/models/newsPost';
|
|
|
|
describe('PUT /user', () => {
|
|
let user;
|
|
|
|
beforeEach(async () => {
|
|
user = await generateUser();
|
|
});
|
|
|
|
context('Allowed Operations', () => {
|
|
it('updates the user', async () => {
|
|
await user.put('/user', {
|
|
'profile.name': 'Frodo',
|
|
'preferences.costume': true,
|
|
'stats.hp': 14,
|
|
});
|
|
|
|
await user.sync();
|
|
|
|
expect(user.profile.name).to.eql('Frodo');
|
|
expect(user.preferences.costume).to.eql(true);
|
|
expect(user.stats.hp).to.eql(14);
|
|
});
|
|
|
|
it('tags must be an array', async () => {
|
|
await expect(user.put('/user', {
|
|
tags: {
|
|
tag: true,
|
|
},
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: 'mustBeArray',
|
|
});
|
|
});
|
|
|
|
it('update tags', async () => {
|
|
const userTags = user.tags;
|
|
|
|
await user.put('/user', {
|
|
tags: [...user.tags, {
|
|
name: 'new tag',
|
|
}],
|
|
});
|
|
|
|
await user.sync();
|
|
|
|
expect(user.tags.length).to.be.eql(userTags.length + 1);
|
|
});
|
|
|
|
it('validates profile.name', async () => {
|
|
await expect(user.put('/user', {
|
|
'profile.name': ' ', // string should be trimmed
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: 'User validation failed',
|
|
});
|
|
|
|
await expect(user.put('/user', {
|
|
'profile.name': '',
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: 'User validation failed',
|
|
});
|
|
|
|
await expect(user.put('/user', {
|
|
'profile.name': null,
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: t('invalidReqParams'),
|
|
});
|
|
|
|
await expect(user.put('/user', {
|
|
'profile.name': 'this is a very long display name that will not be allowed due to length',
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: t('displaynameIssueLength'),
|
|
});
|
|
|
|
await expect(user.put('/user', {
|
|
'profile.name': 'TESTPLACEHOLDERSLURWORDHERE',
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: t('displaynameIssueSlur'),
|
|
});
|
|
|
|
await expect(user.put('/user', {
|
|
'profile.name': 'namecontainsnewline\n',
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: t('displaynameIssueNewline'),
|
|
});
|
|
});
|
|
|
|
it('can set flags.newStuff to false', async () => {
|
|
NewsPost.updateLastNewsPost({
|
|
_id: '1234', publishDate: new Date(), title: 'Title', published: true,
|
|
});
|
|
|
|
await user.update({
|
|
'flags.lastNewStuffRead': '123',
|
|
});
|
|
|
|
await user.put('/user', {
|
|
'flags.newStuff': false,
|
|
});
|
|
|
|
await user.sync();
|
|
|
|
expect(user.flags.lastNewStuffRead).to.eql('1234');
|
|
});
|
|
});
|
|
|
|
context('Top Level Protected Operations', () => {
|
|
const protectedOperations = {
|
|
'gem balance': { balance: 100 },
|
|
auth: { 'auth.blocked': true, 'auth.timestamps.created': new Date() },
|
|
contributor: { 'contributor.level': 9, 'contributor.admin': true, 'contributor.text': 'some text' },
|
|
backer: { 'backer.tier': 10, 'backer.npc': 'Bilbo' },
|
|
subscriptions: { 'purchased.plan.extraMonths': 500, 'purchased.plan.consecutive.trinkets': 1000 },
|
|
'customization gem purchases': { 'purchased.background.tavern': true, 'purchased.skin.bear': true },
|
|
notifications: [{ type: 123 }],
|
|
webhooks: { webhooks: [{ url: 'https://foobar.com' }] },
|
|
secret: { secret: { text: 'Some new text' } },
|
|
};
|
|
|
|
each(protectedOperations, (data, testName) => {
|
|
it(`does not allow updating ${testName}`, async () => {
|
|
const errorText = t('messageUserOperationProtected', { operation: Object.keys(data)[0] });
|
|
|
|
await expect(user.put('/user', data)).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: errorText,
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
context('Sub-Level Protected Operations', () => {
|
|
const protectedOperations = {
|
|
'class stat': { 'stats.class': 'wizard' },
|
|
'flags unless whitelisted': { 'flags.chatRevoked': true },
|
|
webhooks: { 'preferences.webhooks': [1, 2, 3] },
|
|
sleep: { 'preferences.sleep': true },
|
|
'disable classes': { 'preferences.disableClasses': true },
|
|
secret: { secret: { text: 'Some new text' } },
|
|
};
|
|
|
|
each(protectedOperations, (data, testName) => {
|
|
it(`does not allow updating ${testName}`, async () => {
|
|
const errorText = t('messageUserOperationProtected', { operation: Object.keys(data)[0] });
|
|
|
|
await expect(user.put('/user', data)).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: errorText,
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
context('Default Appearance Preferences', () => {
|
|
const testCases = {
|
|
shirt: 'yellow',
|
|
skin: 'ddc994',
|
|
'hair.color': 'blond',
|
|
'hair.bangs': 2,
|
|
'hair.base': 1,
|
|
'hair.flower': 4,
|
|
size: 'broad',
|
|
};
|
|
|
|
each(testCases, (item, type) => {
|
|
const update = {};
|
|
update[`preferences.${type}`] = item;
|
|
|
|
it(`updates user with ${type} that is a default`, async () => {
|
|
const dbUpdate = {};
|
|
dbUpdate[`purchased.${type}.${item}`] = true;
|
|
await user.update(dbUpdate);
|
|
|
|
// Sanity checks to make sure user is not already equipped with item
|
|
expect(get(user.preferences, type)).to.not.eql(item);
|
|
|
|
const updatedUser = await user.put('/user', update);
|
|
|
|
expect(get(updatedUser.preferences, type)).to.eql(item);
|
|
});
|
|
});
|
|
|
|
it('returns an error if user tries to update body size with invalid type', async () => {
|
|
await expect(user.put('/user', {
|
|
'preferences.size': 'round',
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('mustPurchaseToSet', { val: 'round', key: 'preferences.size' }),
|
|
});
|
|
});
|
|
|
|
it('can set beard to default', async () => {
|
|
await user.update({
|
|
'purchased.hair.beard': 3,
|
|
'preferences.hair.beard': 3,
|
|
});
|
|
|
|
const updatedUser = await user.put('/user', {
|
|
'preferences.hair.beard': 0,
|
|
});
|
|
|
|
expect(updatedUser.preferences.hair.beard).to.eql(0);
|
|
});
|
|
|
|
it('can set mustache to default', async () => {
|
|
await user.update({
|
|
'purchased.hair.mustache': 2,
|
|
'preferences.hair.mustache': 2,
|
|
});
|
|
|
|
const updatedUser = await user.put('/user', {
|
|
'preferences.hair.mustache': 0,
|
|
});
|
|
|
|
expect(updatedUser.preferences.hair.mustache).to.eql(0);
|
|
});
|
|
});
|
|
|
|
context('Purchasable Appearance Preferences', () => {
|
|
const testCases = {
|
|
background: 'volcano',
|
|
shirt: 'convict',
|
|
skin: 'cactus',
|
|
'hair.base': 7,
|
|
'hair.beard': 2,
|
|
'hair.color': 'rainbow',
|
|
'hair.mustache': 2,
|
|
};
|
|
|
|
each(testCases, (item, type) => {
|
|
const update = {};
|
|
update[`preferences.${type}`] = item;
|
|
|
|
it(`returns an error if user tries to update ${type} with ${type} the user does not own`, async () => {
|
|
await expect(user.put('/user', update)).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('mustPurchaseToSet', { val: item, key: `preferences.${type}` }),
|
|
});
|
|
});
|
|
|
|
it(`updates user with ${type} user does own`, async () => {
|
|
const dbUpdate = {};
|
|
dbUpdate[`purchased.${type}.${item}`] = true;
|
|
await user.update(dbUpdate);
|
|
|
|
// Sanity check to make sure user is not already equipped with item
|
|
expect(get(user.preferences, type)).to.not.eql(item);
|
|
|
|
const updatedUser = await user.put('/user', update);
|
|
|
|
expect(get(updatedUser.preferences, type)).to.eql(item);
|
|
});
|
|
});
|
|
});
|
|
|
|
context('Improvement Categories', () => {
|
|
it('sets valid categories', async () => {
|
|
await user.put('/user', {
|
|
'preferences.improvementCategories': ['work', 'school'],
|
|
});
|
|
|
|
await user.sync();
|
|
|
|
expect(user.preferences.improvementCategories).to.eql(['work', 'school']);
|
|
});
|
|
|
|
it('discards invalid categories', async () => {
|
|
await expect(user.put('/user', {
|
|
'preferences.improvementCategories': ['work', 'procrastination', 'school'],
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: 'User validation failed',
|
|
});
|
|
});
|
|
});
|
|
});
|