mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-16 06:07:21 +01:00
* refactor: Move translate test utility to helpers directory * Add kind property to webhooks * feat: Add options to create webhook route * refactor: Move webhook ops into single file * refactor: Create webhook objects for specific webhook behavior * chore(tests): Add default sleep helper value of 1 second * feat(api): Add method for groups to send out webhook * feat(api): Add taskCreated webhook task creation * feat(api): Send chat webhooks after a chat is sent * refactor: Move webhook routes to own controller * lint: Correct linting errors * fix(api): Correct taskCreated webhook method * fix(api): Fix webhook logging to only log when there is an error * fix: Update groupChatRecieved webhook creation * chore: Add integration tests for webhooks * fix: Set webhook creation response to 201 * fix: Correct how task scored webhook data is sent * Revert group chat recieved webhook to only support one group * Remove quest activity option for webhooks * feat: Send webhook for each task created * feat: Allow webhooks without a type to default to taskScored * feat: Add logic for adding ids to webhook * feat: optimize webhook url check by shortcircuiting if no url is passed * refactor: Use full name for webhook variable * feat: Add missing params to client webhook * lint: Add missing semicolon * chore(tests): Fix inccorect webhook tests * chore: Add migration to update task scored webhooks * feat: Allow default value of webhook add route to be enabled * chore: Update webhook documentation * chore: Remove special handling for v2 * refactor: adjust addComputedStatsToJSONObject to work for webhooks * refactor: combine taskScored and taskActivity webhooks * feat(api): Add task activity to task update and delete routes * chore: Change references to taskScored to taskActivity * fix: Correct stats object being passed in for transform * chore: Remove extra line break * fix: Pass in the language to use for the translations * refactor(api): Move webhooks from user.preferences.webhooks to user.webhooks * chore: Update migration to set webhook array * lint: Correct brace spacing * chore: convert webhook lib to use user.webhooks * refactor(api): Consolidate filters * chore: clarify migration instructions * fix(test): Correct user creation in user anonymized tests * chore: add test that webhooks cannot be updated via PUT /user * refactor: Simplify default webhook id value * refactor(client): Push newly created webhook instead of doing a sync * chore(test): Add test file for webhook model * refactor: Remove webhook validation * refactor: Remove need for watch on webhooks * refactor(client): Update webhooks object without syncing * chore: update webhook documentation * Fix migrations issues * chore: remove v2 test helper * fix(api): Provide webhook type in task scored webhook * fix(client): Fix webhook deletion appearing to delete all webhooks * feat(api): add optional label field for webhooks * feat: provide empty string as default for webhook label * chore: Update webhook migration * chore: update webhook migration name
147 lines
3.6 KiB
JavaScript
147 lines
3.6 KiB
JavaScript
import {
|
|
generateUser,
|
|
translate as t,
|
|
generateGroup,
|
|
sleep,
|
|
generateChallenge,
|
|
server,
|
|
} from '../../../../helpers/api-integration/v3';
|
|
import { v4 as generateUUID } from 'uuid';
|
|
|
|
describe('DELETE /tasks/:id', () => {
|
|
let user;
|
|
|
|
beforeEach(async () => {
|
|
user = await generateUser();
|
|
});
|
|
|
|
context('task can be deleted', () => {
|
|
let task;
|
|
|
|
beforeEach(async () => {
|
|
task = await user.post('/tasks/user', {
|
|
text: 'test habit',
|
|
type: 'habit',
|
|
alias: 'task-to-be-deleted',
|
|
});
|
|
});
|
|
|
|
it('deletes a user\'s task', async () => {
|
|
await user.del(`/tasks/${task._id}`);
|
|
|
|
await expect(user.get(`/tasks/${task._id}`)).to.eventually.be.rejected.and.eql({
|
|
code: 404,
|
|
error: 'NotFound',
|
|
message: t('taskNotFound'),
|
|
});
|
|
});
|
|
|
|
it('can use a alias to delete a task', async () => {
|
|
await user.del(`/tasks/${task.alias}`);
|
|
|
|
await expect(user.get(`/tasks/${task._id}`)).to.eventually.be.rejected.and.eql({
|
|
code: 404,
|
|
error: 'NotFound',
|
|
message: t('taskNotFound'),
|
|
});
|
|
});
|
|
});
|
|
|
|
context('sending task activity webhooks', () => {
|
|
before(async () => {
|
|
await server.start();
|
|
});
|
|
|
|
after(async () => {
|
|
await server.close();
|
|
});
|
|
|
|
it('sends task activity webhooks if task is user owned', async () => {
|
|
let uuid = generateUUID();
|
|
|
|
let task = await user.post('/tasks/user', {
|
|
text: 'test habit',
|
|
type: 'habit',
|
|
});
|
|
|
|
await user.post('/user/webhook', {
|
|
url: `http://localhost:${server.port}/webhooks/${uuid}`,
|
|
type: 'taskActivity',
|
|
enabled: true,
|
|
options: {
|
|
created: false,
|
|
deleted: true,
|
|
},
|
|
});
|
|
|
|
await user.del(`/tasks/${task.id}`);
|
|
|
|
await sleep();
|
|
|
|
let body = server.getWebhookData(uuid);
|
|
|
|
expect(body.type).to.eql('deleted');
|
|
expect(body.task).to.eql(task);
|
|
});
|
|
|
|
it('does not send task activity webhooks if task is not user owned', async () => {
|
|
let uuid = generateUUID();
|
|
|
|
await user.update({
|
|
balance: 10,
|
|
});
|
|
let guild = await generateGroup(user);
|
|
let challenge = await generateChallenge(user, guild);
|
|
|
|
await user.post('/user/webhook', {
|
|
url: `http://localhost:${server.port}/webhooks/${uuid}`,
|
|
type: 'taskActivity',
|
|
enabled: true,
|
|
options: {
|
|
created: false,
|
|
deleted: true,
|
|
},
|
|
});
|
|
|
|
let challengeTask = await user.post(`/tasks/challenge/${challenge._id}`, {
|
|
text: 'test habit',
|
|
type: 'habit',
|
|
});
|
|
|
|
await user.del(`/tasks/${challengeTask.id}`);
|
|
|
|
await sleep();
|
|
|
|
let body = server.getWebhookData(uuid);
|
|
|
|
expect(body).to.not.exist;
|
|
});
|
|
});
|
|
|
|
context('task cannot be deleted', () => {
|
|
it('cannot delete a non-existant task', async () => {
|
|
await expect(user.del('/tasks/550e8400-e29b-41d4-a716-446655440000')).to.eventually.be.rejected.and.eql({
|
|
code: 404,
|
|
error: 'NotFound',
|
|
message: t('taskNotFound'),
|
|
});
|
|
});
|
|
|
|
it('cannot delete a task owned by someone else', async () => {
|
|
let anotherUser = await generateUser();
|
|
let anotherUsersTask = await anotherUser.post('/tasks/user', {
|
|
text: 'test habit',
|
|
type: 'habit',
|
|
});
|
|
|
|
await expect(user.del(`/tasks/${anotherUsersTask._id}`)).to.eventually.be.rejected.and.eql({
|
|
code: 404,
|
|
error: 'NotFound',
|
|
message: t('taskNotFound'),
|
|
});
|
|
});
|
|
|
|
it('removes a task from user.tasksOrder'); // TODO
|
|
});
|
|
});
|