mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-10-30 04:32:45 +01:00
* Change update username API call
The call no longer requires a password and also validates the username.
* Implement API call to verify username without setting it
* Improve coding style
* Apply username verification to registration
* Update error messages
* Validate display names.
* Fix API early Stat Point allocation (#10680)
* Refactor hasClass check to common so it can be used in shared & server-side code
* Check that user has selected class before allocating stat points
* chore(event): end Ember Hatching Potions
* chore(analytics): reenable navigation tracking
* update bcrypt
* Point achievement modal links to main site (#10709)
* Animal ears after death (#10691)
* Animal Ears purchasable with Gold if lost in Death
* remove ears from pinned items when set is bought
* standardise css and error handling for gems and coins
* revert accidental new line
* fix client tests
* Reduce margin-bottom of checklist-item from 10px to -3px. (#10684)
* chore(i18n): update locales
* 4.61.1
* feat(content): Subscriber Items and Magic Potions
* chore(sprites): compile
* chore(i18n): update locales
* 4.62.0
* Display notification for users to confirm their username
* fix typo
* WIP(usernames): Changes to address #10694
* WIP(usernames): Further changes for #10694
* fix(usernames): don't show spurious headings
* Change verify username notification to new version
* Improve feedback for invalid usernames
* Allow user to set their username again to confirm it
* Improve validation display for usernames
* Temporarily move display name validation outside of schema
* Improve rendering banner about sleeping in the inn
See #10695
* Display settings in one column
* Position inn banner when window is resized
* Update inn banner handling
* Fix banner offset on initial load
* Fix minor issues.
* Issue: 10660 - Fixed. Changed default to Please Enter A Value (#10718)
* Issue: 10660 - Fixed. Changed default to Please Enter A Value
* Issue: 10660 - Fixed/revision 2 Changed default to Enter A Value
* chore(news): Bailey announcements
* chore(i18n): update locales
* 4.62.1
* adjust wiki link for usernameInfo string
https://github.com/HabitRPG/habitica-private/issues/7#issuecomment-425405425
* raise coverage for tasks api calls (#10029)
* - updates a group task - approval is required
- updates a group task with checklist
* add expect to test the new checklist length
* - moves tasks to a specified position out of length
* remove unused line
* website getter tasks tests
* re-add sanitizeUserChallengeTask
* change config.json.example variable to be a string not a boolean
* fix tests - pick the text / up/down props too
* fix test - remove changes on text/up/down - revert sanitize condition - revert sanitization props
* Change update username API call
The call no longer requires a password and also validates the username.
* feat(content): Subscriber Items and Magic Potions
* Re-add register call
* Fix merge issue
* Fix issue with setting username
* Implement new alert style
* Display username confirmation status in settings
* Add disclaimer to change username field
* validate username in settings
* Allow specific fields to be focused when opening site settings
* Implement requested changes.
* Fix merge issue
* Fix failing tests
* verify username when users register with username and password
* Set ID for change username notification
* Disable submit button if username is invalid
* Improve username confirmation handling
* refactor(settings): address remaining code comments on auth form
* Revert "refactor(settings): address remaining code comments on auth form"
This reverts commit 9b6609ad64.
* Social user username (#10620)
* Refactored private functions to library
* Refactored social login code
* Added username to social registration
* Changed id library
* Added new local auth check
* Fixed export error. Fixed password check error
* fix(settings): password not available on client
* refactor(settings): more sensible placement of methods
* chore(migration): script to hand out procgen usernames
* fix(migration): don't give EVERYONE new names you doofus
* fix(migration): limit data retrieved, be extra careful about updates
* fix(migration): use missing field, not migration tag, for query
* fix(migration): unused var
* fix(usernames): only generate 20 characters
* fix(migration): set lowerCaseUsername
257 lines
7.4 KiB
JavaScript
257 lines
7.4 KiB
JavaScript
import {
|
|
generateUser,
|
|
translate as t,
|
|
} from '../../../helpers/api-integration/v4';
|
|
|
|
import { each, get } from 'lodash';
|
|
|
|
describe('PUT /user', () => {
|
|
let user;
|
|
|
|
beforeEach(async () => {
|
|
user = await generateUser();
|
|
});
|
|
|
|
context('Allowed Operations', () => {
|
|
it('updates the user', async () => {
|
|
await user.put('/user', {
|
|
'profile.name': 'Frodo',
|
|
'preferences.costume': true,
|
|
'stats.hp': 14,
|
|
});
|
|
|
|
await user.sync();
|
|
|
|
expect(user.profile.name).to.eql('Frodo');
|
|
expect(user.preferences.costume).to.eql(true);
|
|
expect(user.stats.hp).to.eql(14);
|
|
});
|
|
|
|
it('tags must be an array', async () => {
|
|
await expect(user.put('/user', {
|
|
tags: {
|
|
tag: true,
|
|
},
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: 'mustBeArray',
|
|
});
|
|
});
|
|
|
|
it('update tags', async () => {
|
|
let userTags = user.tags;
|
|
|
|
await user.put('/user', {
|
|
tags: [...user.tags, {
|
|
name: 'new tag',
|
|
}],
|
|
});
|
|
|
|
await user.sync();
|
|
|
|
expect(user.tags.length).to.be.eql(userTags.length + 1);
|
|
});
|
|
|
|
|
|
it('profile.name cannot be an empty string or null', async () => {
|
|
await expect(user.put('/user', {
|
|
'profile.name': ' ', // string should be trimmed
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: 'User validation failed',
|
|
});
|
|
|
|
await expect(user.put('/user', {
|
|
'profile.name': '',
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: 'User validation failed',
|
|
});
|
|
|
|
await expect(user.put('/user', {
|
|
'profile.name': null,
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: t('invalidReqParams'),
|
|
});
|
|
});
|
|
});
|
|
|
|
context('Top Level Protected Operations', () => {
|
|
let protectedOperations = {
|
|
'gem balance': {balance: 100},
|
|
auth: {'auth.blocked': true, 'auth.timestamps.created': new Date()},
|
|
contributor: {'contributor.level': 9, 'contributor.admin': true, 'contributor.text': 'some text'},
|
|
backer: {'backer.tier': 10, 'backer.npc': 'Bilbo'},
|
|
subscriptions: {'purchased.plan.extraMonths': 500, 'purchased.plan.consecutive.trinkets': 1000},
|
|
'customization gem purchases': {'purchased.background.tavern': true, 'purchased.skin.bear': true},
|
|
notifications: [{type: 123}],
|
|
webhooks: {webhooks: [{url: 'https://foobar.com'}]},
|
|
};
|
|
|
|
each(protectedOperations, (data, testName) => {
|
|
it(`does not allow updating ${testName}`, async () => {
|
|
let errorText = t('messageUserOperationProtected', { operation: Object.keys(data)[0] });
|
|
|
|
await expect(user.put('/user', data)).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: errorText,
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
context('Sub-Level Protected Operations', () => {
|
|
let protectedOperations = {
|
|
'class stat': {'stats.class': 'wizard'},
|
|
'flags unless whitelisted': {'flags.dropsEnabled': true},
|
|
webhooks: {'preferences.webhooks': [1, 2, 3]},
|
|
sleep: {'preferences.sleep': true},
|
|
'disable classes': {'preferences.disableClasses': true},
|
|
};
|
|
|
|
each(protectedOperations, (data, testName) => {
|
|
it(`does not allow updating ${testName}`, async () => {
|
|
let errorText = t('messageUserOperationProtected', { operation: Object.keys(data)[0] });
|
|
|
|
await expect(user.put('/user', data)).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: errorText,
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
context('Default Appearance Preferences', () => {
|
|
let testCases = {
|
|
shirt: 'yellow',
|
|
skin: 'ddc994',
|
|
'hair.color': 'blond',
|
|
'hair.bangs': 2,
|
|
'hair.base': 1,
|
|
'hair.flower': 4,
|
|
size: 'broad',
|
|
};
|
|
|
|
each(testCases, (item, type) => {
|
|
const update = {};
|
|
update[`preferences.${type}`] = item;
|
|
|
|
it(`updates user with ${type} that is a default`, async () => {
|
|
let dbUpdate = {};
|
|
dbUpdate[`purchased.${type}.${item}`] = true;
|
|
await user.update(dbUpdate);
|
|
|
|
// Sanity checks to make sure user is not already equipped with item
|
|
expect(get(user.preferences, type)).to.not.eql(item);
|
|
|
|
let updatedUser = await user.put('/user', update);
|
|
|
|
expect(get(updatedUser.preferences, type)).to.eql(item);
|
|
});
|
|
});
|
|
|
|
it('returns an error if user tries to update body size with invalid type', async () => {
|
|
await expect(user.put('/user', {
|
|
'preferences.size': 'round',
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('mustPurchaseToSet', { val: 'round', key: 'preferences.size' }),
|
|
});
|
|
});
|
|
|
|
it('can set beard to default', async () => {
|
|
await user.update({
|
|
'purchased.hair.beard': 3,
|
|
'preferences.hair.beard': 3,
|
|
});
|
|
|
|
let updatedUser = await user.put('/user', {
|
|
'preferences.hair.beard': 0,
|
|
});
|
|
|
|
expect(updatedUser.preferences.hair.beard).to.eql(0);
|
|
});
|
|
|
|
it('can set mustache to default', async () => {
|
|
await user.update({
|
|
'purchased.hair.mustache': 2,
|
|
'preferences.hair.mustache': 2,
|
|
});
|
|
|
|
let updatedUser = await user.put('/user', {
|
|
'preferences.hair.mustache': 0,
|
|
});
|
|
|
|
expect(updatedUser.preferences.hair.mustache).to.eql(0);
|
|
});
|
|
});
|
|
|
|
context('Purchasable Appearance Preferences', () => {
|
|
let testCases = {
|
|
background: 'volcano',
|
|
shirt: 'convict',
|
|
skin: 'cactus',
|
|
'hair.base': 7,
|
|
'hair.beard': 2,
|
|
'hair.color': 'rainbow',
|
|
'hair.mustache': 2,
|
|
};
|
|
|
|
each(testCases, (item, type) => {
|
|
const update = {};
|
|
update[`preferences.${type}`] = item;
|
|
|
|
it(`returns an error if user tries to update ${type} with ${type} the user does not own`, async () => {
|
|
await expect(user.put('/user', update)).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('mustPurchaseToSet', {val: item, key: `preferences.${type}`}),
|
|
});
|
|
});
|
|
|
|
it(`updates user with ${type} user does own`, async () => {
|
|
let dbUpdate = {};
|
|
dbUpdate[`purchased.${type}.${item}`] = true;
|
|
await user.update(dbUpdate);
|
|
|
|
// Sanity check to make sure user is not already equipped with item
|
|
expect(get(user.preferences, type)).to.not.eql(item);
|
|
|
|
let updatedUser = await user.put('/user', update);
|
|
|
|
expect(get(updatedUser.preferences, type)).to.eql(item);
|
|
});
|
|
});
|
|
});
|
|
|
|
context('Improvement Categories', () => {
|
|
it('sets valid categories', async () => {
|
|
await user.put('/user', {
|
|
'preferences.improvementCategories': ['work', 'school'],
|
|
});
|
|
|
|
await user.sync();
|
|
|
|
expect(user.preferences.improvementCategories).to.eql(['work', 'school']);
|
|
});
|
|
|
|
it('discards invalid categories', async () => {
|
|
await expect(user.put('/user', {
|
|
'preferences.improvementCategories': ['work', 'procrastination', 'school'],
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: 'User validation failed',
|
|
});
|
|
});
|
|
});
|
|
});
|