mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-17 14:47:53 +01:00
* refactor: Move translate test utility to helpers directory * Add kind property to webhooks * feat: Add options to create webhook route * refactor: Move webhook ops into single file * refactor: Create webhook objects for specific webhook behavior * chore(tests): Add default sleep helper value of 1 second * feat(api): Add method for groups to send out webhook * feat(api): Add taskCreated webhook task creation * feat(api): Send chat webhooks after a chat is sent * refactor: Move webhook routes to own controller * lint: Correct linting errors * fix(api): Correct taskCreated webhook method * fix(api): Fix webhook logging to only log when there is an error * fix: Update groupChatRecieved webhook creation * chore: Add integration tests for webhooks * fix: Set webhook creation response to 201 * fix: Correct how task scored webhook data is sent * Revert group chat recieved webhook to only support one group * Remove quest activity option for webhooks * feat: Send webhook for each task created * feat: Allow webhooks without a type to default to taskScored * feat: Add logic for adding ids to webhook * feat: optimize webhook url check by shortcircuiting if no url is passed * refactor: Use full name for webhook variable * feat: Add missing params to client webhook * lint: Add missing semicolon * chore(tests): Fix inccorect webhook tests * chore: Add migration to update task scored webhooks * feat: Allow default value of webhook add route to be enabled * chore: Update webhook documentation * chore: Remove special handling for v2 * refactor: adjust addComputedStatsToJSONObject to work for webhooks * refactor: combine taskScored and taskActivity webhooks * feat(api): Add task activity to task update and delete routes * chore: Change references to taskScored to taskActivity * fix: Correct stats object being passed in for transform * chore: Remove extra line break * fix: Pass in the language to use for the translations * refactor(api): Move webhooks from user.preferences.webhooks to user.webhooks * chore: Update migration to set webhook array * lint: Correct brace spacing * chore: convert webhook lib to use user.webhooks * refactor(api): Consolidate filters * chore: clarify migration instructions * fix(test): Correct user creation in user anonymized tests * chore: add test that webhooks cannot be updated via PUT /user * refactor: Simplify default webhook id value * refactor(client): Push newly created webhook instead of doing a sync * chore(test): Add test file for webhook model * refactor: Remove webhook validation * refactor: Remove need for watch on webhooks * refactor(client): Update webhooks object without syncing * chore: update webhook documentation * Fix migrations issues * chore: remove v2 test helper * fix(api): Provide webhook type in task scored webhook * fix(client): Fix webhook deletion appearing to delete all webhooks * feat(api): add optional label field for webhooks * feat: provide empty string as default for webhook label * chore: Update webhook migration * chore: update webhook migration name
204 lines
6.1 KiB
JavaScript
204 lines
6.1 KiB
JavaScript
import {
|
|
generateUser,
|
|
translate as t,
|
|
} from '../../../../helpers/api-integration/v3';
|
|
|
|
import { each, get } from 'lodash';
|
|
|
|
describe('PUT /user', () => {
|
|
let user;
|
|
|
|
beforeEach(async () => {
|
|
user = await generateUser();
|
|
});
|
|
|
|
context('Allowed Operations', () => {
|
|
it('updates the user', async () => {
|
|
await user.put('/user', {
|
|
'profile.name': 'Frodo',
|
|
'preferences.costume': true,
|
|
'stats.hp': 14,
|
|
});
|
|
|
|
await user.sync();
|
|
|
|
expect(user.profile.name).to.eql('Frodo');
|
|
expect(user.preferences.costume).to.eql(true);
|
|
expect(user.stats.hp).to.eql(14);
|
|
});
|
|
});
|
|
|
|
context('Top Level Protected Operations', () => {
|
|
let protectedOperations = {
|
|
'gem balance': {balance: 100},
|
|
auth: {'auth.blocked': true, 'auth.timestamps.created': new Date()},
|
|
contributor: {'contributor.level': 9, 'contributor.admin': true, 'contributor.text': 'some text'},
|
|
backer: {'backer.tier': 10, 'backer.npc': 'Bilbo'},
|
|
subscriptions: {'purchased.plan.extraMonths': 500, 'purchased.plan.consecutive.trinkets': 1000},
|
|
'customization gem purchases': {'purchased.background.tavern': true, 'purchased.skin.bear': true},
|
|
notifications: [{type: 123}],
|
|
webhooks: {webhooks: [{url: 'https://foobar.com'}]},
|
|
};
|
|
|
|
each(protectedOperations, (data, testName) => {
|
|
it(`does not allow updating ${testName}`, async () => {
|
|
let errorText = t('messageUserOperationProtected', { operation: Object.keys(data)[0] });
|
|
|
|
await expect(user.put('/user', data)).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: errorText,
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
context('Sub-Level Protected Operations', () => {
|
|
let protectedOperations = {
|
|
'class stat': {'stats.class': 'wizard'},
|
|
'flags unless whitelisted': {'flags.dropsEnabled': true},
|
|
webhooks: {'preferences.webhooks': [1, 2, 3]},
|
|
sleep: {'preferences.sleep': true},
|
|
'disable classes': {'preferences.disableClasses': true},
|
|
};
|
|
|
|
each(protectedOperations, (data, testName) => {
|
|
it(`does not allow updating ${testName}`, async () => {
|
|
let errorText = t('messageUserOperationProtected', { operation: Object.keys(data)[0] });
|
|
|
|
await expect(user.put('/user', data)).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: errorText,
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
context('Default Appearance Preferences', () => {
|
|
let testCases = {
|
|
shirt: 'yellow',
|
|
skin: 'ddc994',
|
|
'hair.color': 'blond',
|
|
'hair.bangs': 2,
|
|
'hair.base': 1,
|
|
'hair.flower': 4,
|
|
size: 'broad',
|
|
};
|
|
|
|
each(testCases, (item, type) => {
|
|
const update = {};
|
|
update[`preferences.${type}`] = item;
|
|
|
|
it(`updates user with ${type} that is a default`, async () => {
|
|
let dbUpdate = {};
|
|
dbUpdate[`purchased.${type}.${item}`] = true;
|
|
await user.update(dbUpdate);
|
|
|
|
// Sanity checks to make sure user is not already equipped with item
|
|
expect(get(user.preferences, type)).to.not.eql(item);
|
|
|
|
let updatedUser = await user.put('/user', update);
|
|
|
|
expect(get(updatedUser.preferences, type)).to.eql(item);
|
|
});
|
|
});
|
|
|
|
it('returns an error if user tries to update body size with invalid type', async () => {
|
|
await expect(user.put('/user', {
|
|
'preferences.size': 'round',
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('mustPurchaseToSet', { val: 'round', key: 'preferences.size' }),
|
|
});
|
|
});
|
|
|
|
it('can set beard to default', async () => {
|
|
await user.update({
|
|
'purchased.hair.beard': 3,
|
|
'preferences.hair.beard': 3,
|
|
});
|
|
|
|
let updatedUser = await user.put('/user', {
|
|
'preferences.hair.beard': 0,
|
|
});
|
|
|
|
expect(updatedUser.preferences.hair.beard).to.eql(0);
|
|
});
|
|
|
|
it('can set mustache to default', async () => {
|
|
await user.update({
|
|
'purchased.hair.mustache': 2,
|
|
'preferences.hair.mustache': 2,
|
|
});
|
|
|
|
let updatedUser = await user.put('/user', {
|
|
'preferences.hair.mustache': 0,
|
|
});
|
|
|
|
expect(updatedUser.preferences.hair.mustache).to.eql(0);
|
|
});
|
|
});
|
|
|
|
context('Purchasable Appearance Preferences', () => {
|
|
let testCases = {
|
|
background: 'volcano',
|
|
shirt: 'convict',
|
|
skin: 'cactus',
|
|
'hair.base': 7,
|
|
'hair.beard': 2,
|
|
'hair.color': 'rainbow',
|
|
'hair.mustache': 2,
|
|
};
|
|
|
|
each(testCases, (item, type) => {
|
|
const update = {};
|
|
update[`preferences.${type}`] = item;
|
|
|
|
it(`returns an error if user tries to update ${type} with ${type} the user does not own`, async () => {
|
|
await expect(user.put('/user', update)).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('mustPurchaseToSet', {val: item, key: `preferences.${type}`}),
|
|
});
|
|
});
|
|
|
|
it(`updates user with ${type} user does own`, async () => {
|
|
let dbUpdate = {};
|
|
dbUpdate[`purchased.${type}.${item}`] = true;
|
|
await user.update(dbUpdate);
|
|
|
|
// Sanity check to make sure user is not already equipped with item
|
|
expect(get(user.preferences, type)).to.not.eql(item);
|
|
|
|
let updatedUser = await user.put('/user', update);
|
|
|
|
expect(get(updatedUser.preferences, type)).to.eql(item);
|
|
});
|
|
});
|
|
});
|
|
|
|
context('Improvement Categories', () => {
|
|
it('sets valid categories', async () => {
|
|
await user.put('/user', {
|
|
'preferences.improvementCategories': ['work', 'school'],
|
|
});
|
|
|
|
await user.sync();
|
|
|
|
expect(user.preferences.improvementCategories).to.eql(['work', 'school']);
|
|
});
|
|
|
|
it('discards invalid categories', async () => {
|
|
await expect(user.put('/user', {
|
|
'preferences.improvementCategories': ['work', 'procrastination', 'school'],
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: 'User validation failed',
|
|
});
|
|
});
|
|
});
|
|
});
|