mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-16 06:07:21 +01:00
* Add new API call to complete multiple task scorings in one call * Improve API response * Improve saving process * Improve handling for multiple tasks scored at once * Handle challenge task errors better * Improve check for alias * Improve check for task scorings * Fix merge errors * make nodemon ignore content_cache * Fix completing group tasks * fix test * fix tests (again) * typo * WIP(a11y): task modal updates * fix(tasks): borders in modal * fix(tasks): circley locks * fix(task-modal): placeholders * WIP(task-modal): disabled states, hide empty options, +/- restyle * fix(task-modal): box shadows instead of borders, habit control pointer * fix(task-modal): button states? * fix(modal): tighten up layout, new spacing utils * fix(tasks): more stylin * fix(tasks): habit hovers * fix(css): checklist labels, a11y colors * fix(css): one more missed hover issue * fix(css): lock Challenges, label fixes * fix(css): scope input/textarea changes * fix(style): task tweakies * fix(style): more button fixage * WIP(component): start select list story * working example of a templated selectList * fix(style): more button corrections * fix(lint): EOL * fix(buttons): factor btn-secondary to better override Bootstrap * fix(styles): standardize more buttons * wip: difficulty select - style fixes * selectDifficulty works! 🎉 - fix styles * change the dropdown-item sizes only for the selectList ones * selectTranslatedArray * changed many label margins * more correct dropdown style * fix(modals): button corrections * input-group styling + datetime picker without today button * Style/margins for "repeat every" - extract selectTag.vue * working tag-selection / update - cleanup * fix stories * fix svg color on create modal (purple) * fix task modal bottom padding * correct dropdown shadow * update dropdown-toggle caret size / color * fixed checklist style * sync checked state * selectTag padding * fix spacing between positive/negative streak inputs * toggle-checkbox + fix some spacings * disable repeat-on when its a groupTask * fix new checklist-item * fix toggle-checkbox style - fix difficulty style * fix checklist ui * add tags label , when there arent any tags selected * WORKING select-tag component 🎉 * fix taglist story * show max 5 items in tag dropdown + "X more" label * fix datetime clear button * replace m-b-xs to mb-1 (bootstrap) - fix input-group-text style * fix styles of advanced settings * fix delete task styles * always show grippy on hover of the item * extract modal-text-input mixin + fix the borders/dropshadow * fix(spacing): revert most to Bootstrap * feat(checklists): make local copy of master checklist non-editable also aggressively update checklists because they weren't syncing?? * fix(checklists): handle add/remove options better * feat(teams): manager notes field * fix select/dropdown styles * input border + icon colors * delete task underline color * fix checklist "delete icon" vertical position * selectTag fixes - normal open/close toggle working again - remove icon color * fixing icons: Trash can - Delete Little X - Remove Big X - Close Block - Block * fix taglist margins / icon sizes * wip margin overview (in storybook) * fix routerlink * remove unused method * new selectTag style + add markdown inside tagList + scrollable tag selection * fix selectTag / selectList active border * fix difficulty select (svg default color) * fix input padding-left + fix reset habit streak fullwidth / padding + "repeat every" gray text (no border) * feat(teams): improved approval request > approve > reward flow * fix(tests): address failures * fix(lint): oops only * fix(tasks): short-circuit group related logic * fix(tasks): more short circuiting * fix(tasks): more lines, less lint * fix(tasks): how do i keep missing these * feat(teams): provide assigning user summary * fix(teams): don't attempt to record assiging user if not supplied * fix advanced-settings styling / margin * fix merge + hide advanced streak settings when none enabled * fix styles * set Roboto font for advanced settings * Add Challenge flag to the tag list * add tag with enter, when no other tag is found * fix styles + tag cancel button * refactor footer / margin * split repeat fields into option mt-3 groups * button all the things * fix(tasks): style updates * no hover state for non-editable tasks on team board * keep assign/claim footer on task after requesting approval * disable more fields on user copy of team task, and remove hover states for them * fix(tasks): functional revisions * "Claim Rewards" instead of "x" in task approved notif * Remove default transition supplied by Bootstrap, apply individually to some elements * Delete individual tasks and related notifications when master task deleted from team board * Manager notes now save when supplied at task initial creation * Can no longer dismiss rewards from approved task by hitting Dismiss All * fix(tasks): clean tasksOrder also adjust related test expectation * fix(tests): adjust integration expectations * fix(test): ratzen fratzen only * fix lint * fix tests * fix(teams): checklist, notes * handleSharedCompletion: handle error, make sure it is run after the user task has been saved * fix typo * correctly handle errors in handleSharedCompletion when approving a task * fix(teams): improve disabled states * handleSharedCompletion: do not increase completions by 1 manually to adjust for last approval not saved yet * revert changes to config.json.example * fix(teams): more style fixage * add unit tests for findMultipleByIdOrAlias * exclude api v4 route from apidocs * BREAKING(teams): return 202 instead of 401 for approval request * fix(teams): better taskboard sync also re-re-fix checklist borders * scoreTasks: validate body * fix tests, move string to api errors * fix(tests): update expectations for breaking change * start updating api docs, process tasks sequentially to avoid conflicts with user._tmp * do not crash entire bulk operation in case of errors * save task only if modified * fix lint * undo changes to error handling: either all tasks scoring are successfull or none * remove stale code * do not return user._tmp when bulk scoring, it would be the last version only * make sure user._tmp.leveledUp is not lost when bulk scoring * rewards tests * mixed tests * fix tests, allow scoring the same task multiple times * finish integration tests * fix api docs for the bulk score route * refactor(task-modal): lockable label component * wip loading spinner * refactor(teams): move task scoring to mixin * fix(teams): style corrections * fix(btn): fix padding to have height of 32px * implement loading spinner * remove console.log warnings * fix(tasks): spacing and wording corrections * fix(teams): don't bork manager notes * fix(teams): assignment fix and more approval flow revisions * WIP(teams): use tag dropdown control for assignment * finish merge - never throw an error when a group task requires approval (wip - needs tests) * fix taskModal merge * fix merge * fix(task modal): add newline * fix(column.vue): add newline at end of file * mvp yesterdaily modal * fix tests * fix api docs for bulk scoring group tasks * separate task scoring and _tmp handling * handle _tmp when bulk scoring * rya: close modal before calling cron API, prevents issues with modals * rya: fix conflicts with other modals * add sounds, support for group plans, analytics * use asyncResource for group plans * fix lint * streak bonus: add comment about missing in rya * move yesterdailyModal * fix issues with level up modals and rya * add comments for future use, fix level up modals not showing up at levels with a quest drop * handle errors in rya modal * bundle quest and crit notifications Co-authored-by: Phillip Thelen <phillip@habitica.com> Co-authored-by: Phillip Thelen <viirus@pherth.net> Co-authored-by: Sabe Jones <sabrecat@gmail.com> Co-authored-by: negue <eugen.bolz@gmail.com>
364 lines
13 KiB
JavaScript
364 lines
13 KiB
JavaScript
import timesLodash from 'lodash/times';
|
|
import reduce from 'lodash/reduce';
|
|
import moment from 'moment';
|
|
import max from 'lodash/max';
|
|
import {
|
|
NotAuthorized,
|
|
} from '../libs/errors';
|
|
import i18n from '../i18n';
|
|
import updateStats from '../fns/updateStats';
|
|
import crit from '../fns/crit';
|
|
import getUtcOffset from '../fns/getUtcOffset';
|
|
|
|
import statsComputed from '../libs/statsComputed';
|
|
import { checkOnboardingStatus } from '../libs/onboarding';
|
|
|
|
const MAX_TASK_VALUE = 21.27;
|
|
const MIN_TASK_VALUE = -47.27;
|
|
const CLOSE_ENOUGH = 0.00001;
|
|
|
|
function _getTaskValue (taskValue) {
|
|
if (taskValue < MIN_TASK_VALUE) {
|
|
return MIN_TASK_VALUE;
|
|
} if (taskValue > MAX_TASK_VALUE) {
|
|
return MAX_TASK_VALUE;
|
|
}
|
|
return taskValue;
|
|
}
|
|
|
|
// Calculates the next task.value based on direction
|
|
// Uses a capped inverse log y=.95^x, y>= -5
|
|
function _calculateDelta (task, direction, cron) {
|
|
// Min/max on task redness
|
|
const currVal = _getTaskValue(task.value);
|
|
let nextDelta = (0.9747 ** currVal) * (direction === 'down' ? -1 : 1);
|
|
|
|
// Checklists
|
|
if (task.checklist && task.checklist.length > 0) {
|
|
// If the Daily, only dock them a portion based on their checklist completion
|
|
if (direction === 'down' && task.type === 'daily' && cron) {
|
|
nextDelta *= 1 - reduce(
|
|
task.checklist,
|
|
(m, i) => m + (i.completed ? 1 : 0),
|
|
0,
|
|
) / task.checklist.length;
|
|
}
|
|
|
|
// If To Do, point-match the TD per checklist item completed
|
|
if (task.type === 'todo' && !cron) {
|
|
nextDelta *= 1 + reduce(task.checklist, (m, i) => m + (i.completed ? 1 : 0), 0);
|
|
}
|
|
}
|
|
|
|
return nextDelta;
|
|
}
|
|
|
|
// Approximates the reverse delta for the task value
|
|
// This is meant to return the task value to its original value when unchecking a task.
|
|
// First, calculate the value using the normal way for our first guess although
|
|
// it will be a bit off
|
|
function _calculateReverseDelta (task, direction) {
|
|
const currVal = _getTaskValue(task.value);
|
|
let testVal = currVal + (0.9747 ** currVal) * (direction === 'down' ? -1 : 1);
|
|
|
|
// Now keep moving closer to the original value until we get "close enough"
|
|
// Check how close we are to the original value by computing the delta off our guess
|
|
// and looking at the difference between that and our current value.
|
|
while (true) { // eslint-disable-line no-constant-condition
|
|
const calc = testVal + (0.9747 ** testVal);
|
|
const diff = currVal - calc;
|
|
|
|
if (Math.abs(diff) < CLOSE_ENOUGH) break;
|
|
|
|
if (diff > 0) {
|
|
testVal -= diff;
|
|
} else {
|
|
testVal += diff;
|
|
}
|
|
}
|
|
|
|
// When we get close enough, return the difference between our approximated value
|
|
// and the current value. This will be the delta calculated from the original value
|
|
// before the task was checked.
|
|
let nextDelta = testVal - currVal;
|
|
|
|
// Checklists - If To Do, point-match the TD per checklist item completed
|
|
if (task.checklist && task.checklist.length > 0 && task.type === 'todo') {
|
|
nextDelta *= 1 + reduce(task.checklist, (m, i) => m + (i.completed ? 1 : 0), 0);
|
|
}
|
|
|
|
return nextDelta;
|
|
}
|
|
|
|
function _gainMP (user, val) {
|
|
val *= user._tmp.crit || 1; // eslint-disable-line no-param-reassign
|
|
user.stats.mp += val;
|
|
|
|
if (user.stats.mp >= statsComputed(user).maxMP) user.stats.mp = statsComputed(user).maxMP;
|
|
if (user.stats.mp < 0) {
|
|
user.stats.mp = 0;
|
|
}
|
|
}
|
|
|
|
// HP modifier
|
|
// ===== CONSTITUTION =====
|
|
// TODO Decreases HP loss from bad habits / missed dailies by 0.5% per point.
|
|
function _subtractPoints (user, task, stats, delta) {
|
|
let conBonus = 1 - statsComputed(user).con / 250;
|
|
if (conBonus < 0.1) conBonus = 0.1;
|
|
|
|
const hpMod = delta * conBonus * task.priority * 2; // constant 2 multiplier for better results
|
|
stats.hp += Math.round(hpMod * 10) / 10; // round to 1dp
|
|
return stats.hp;
|
|
}
|
|
|
|
function _addPoints (user, task, stats, direction, delta) {
|
|
const _crit = user._tmp.crit || 1;
|
|
|
|
// Exp Modifier
|
|
// ===== Intelligence =====
|
|
// TODO Increases Experience gain by .2% per point.
|
|
const intBonus = 1 + statsComputed(user).int * 0.025;
|
|
stats.exp += Math.round(delta * intBonus * task.priority * _crit * 6);
|
|
|
|
// GP modifier
|
|
// ===== PERCEPTION =====
|
|
// TODO Increases Gold gained from tasks by .3% per point.
|
|
const perBonus = 1 + statsComputed(user).per * 0.02;
|
|
const gpMod = delta * task.priority * _crit * perBonus;
|
|
|
|
if (task.streak) {
|
|
const currStreak = direction === 'down' ? task.streak - 1 : task.streak;
|
|
const streakBonus = currStreak / 100 + 1; // eg, 1-day streak is 1.01, 2-day is 1.02, etc
|
|
const afterStreak = gpMod * streakBonus;
|
|
if (currStreak > 0 && gpMod > 0) {
|
|
// keep this on-hand for later, so we can notify streak-bonus
|
|
user._tmp.streakBonus = afterStreak - gpMod;
|
|
}
|
|
|
|
stats.gp += afterStreak;
|
|
} else {
|
|
stats.gp += gpMod;
|
|
}
|
|
}
|
|
|
|
function _changeTaskValue (user, task, direction, times, cron) {
|
|
let addToDelta = 0;
|
|
|
|
// ===== CRITICAL HITS =====
|
|
// allow critical hit only when checking off a task, not when unchecking it:
|
|
const _crit = direction === 'up' ? crit.crit(user) : 1;
|
|
// if there was a crit, alert the user via notification
|
|
if (_crit > 1) user._tmp.crit = _crit;
|
|
|
|
// If multiple days have passed, multiply times days missed
|
|
timesLodash(times, () => {
|
|
// Each iteration calculate the nextDelta, which is then accumulated in the total delta.
|
|
const nextDelta = !cron && direction === 'down' ? _calculateReverseDelta(task, direction) : _calculateDelta(task, direction, cron);
|
|
|
|
if (task.type !== 'reward') {
|
|
if (user.preferences.automaticAllocation === true && user.preferences.allocationMode === 'taskbased' && !(task.type === 'todo' && direction === 'down')) {
|
|
user.stats.training[task.attribute] += nextDelta;
|
|
}
|
|
|
|
if (direction === 'up') { // Make progress on quest based on STR
|
|
user.party.quest.progress.up = user.party.quest.progress.up || 0;
|
|
const prevProgress = user.party.quest.progress.up;
|
|
|
|
if (task.type === 'todo' || task.type === 'daily') {
|
|
user.party.quest.progress.up += nextDelta * _crit * (1 + statsComputed(user).str / 200);
|
|
} else if (task.type === 'habit') {
|
|
user.party.quest.progress.up += nextDelta * _crit * (0.5 + statsComputed(user).str / 400);
|
|
}
|
|
|
|
if (!user._tmp.quest) user._tmp.quest = {};
|
|
user._tmp.quest.progressDelta = user.party.quest.progress.up - prevProgress;
|
|
}
|
|
task.value += nextDelta;
|
|
}
|
|
|
|
addToDelta += nextDelta;
|
|
});
|
|
|
|
return addToDelta;
|
|
}
|
|
|
|
function _updateCounter (task, direction, times) {
|
|
if (direction === 'up') {
|
|
task.counterUp += times;
|
|
} else {
|
|
task.counterDown += times;
|
|
}
|
|
}
|
|
|
|
function _lastHistoryEntryWasToday (lastHistoryEntry, user) {
|
|
if (!lastHistoryEntry || !lastHistoryEntry.date) {
|
|
return false;
|
|
}
|
|
|
|
const timezoneUtcOffset = getUtcOffset(user);
|
|
const { dayStart } = user.preferences;
|
|
|
|
// Adjust the last entry date according to the user's timezone and CDS
|
|
const dateWithTimeZone = moment(lastHistoryEntry.date).utcOffset(timezoneUtcOffset);
|
|
if (dateWithTimeZone.hour() < dayStart) dateWithTimeZone.subtract(1, 'day');
|
|
|
|
return moment().utcOffset(timezoneUtcOffset).isSame(dateWithTimeZone, 'day');
|
|
}
|
|
|
|
function _updateLastHistoryEntry (lastHistoryEntry, task, direction, times) {
|
|
lastHistoryEntry.value = task.value;
|
|
lastHistoryEntry.date = Number(new Date());
|
|
|
|
// @TODO remove this extra check after migration
|
|
// has run to set scoredUp and scoredDown in every task
|
|
lastHistoryEntry.scoredUp = lastHistoryEntry.scoredUp || 0;
|
|
lastHistoryEntry.scoredDown = lastHistoryEntry.scoredDown || 0;
|
|
|
|
if (direction === 'up') {
|
|
lastHistoryEntry.scoredUp += times;
|
|
} else {
|
|
lastHistoryEntry.scoredDown += times;
|
|
}
|
|
}
|
|
|
|
export default function scoreTask (options = {}, req = {}, analytics) {
|
|
const {
|
|
user, task, direction, times = 1, cron = false,
|
|
} = options;
|
|
let delta = 0;
|
|
const stats = {
|
|
gp: user.stats.gp,
|
|
hp: user.stats.hp,
|
|
exp: user.stats.exp,
|
|
};
|
|
|
|
if (
|
|
task.group && task.group.approval && task.group.approval.required
|
|
&& !task.group.approval.approved && !(task.type === 'todo' && cron)
|
|
) return 0;
|
|
|
|
// This is for setting one-time temporary flags,
|
|
// such as streakBonus or itemDropped. Useful for notifying
|
|
// the API consumer, then cleared afterwards
|
|
// Keep user._tmp.leveledUp if it already exists
|
|
// To make sure infos on level ups don't get lost when bulk scoring multiple tasks
|
|
const oldLeveledUp = user._tmp && user._tmp.leveledUp;
|
|
user._tmp = {};
|
|
|
|
if (oldLeveledUp) user._tmp.leveledUp = oldLeveledUp;
|
|
|
|
// If they're trying to purchase a too-expensive reward, don't allow them to do that.
|
|
if (task.value > user.stats.gp && task.type === 'reward') throw new NotAuthorized(i18n.t('messageNotEnoughGold', req.language));
|
|
|
|
if (task.type === 'habit') {
|
|
delta += _changeTaskValue(user, task, direction, times, cron);
|
|
|
|
// Add habit value to habit-history (if different)
|
|
if (delta > 0) {
|
|
_addPoints(user, task, stats, direction, delta);
|
|
} else {
|
|
_subtractPoints(user, task, stats, delta);
|
|
}
|
|
_gainMP(user, max([0.25, 0.0025 * statsComputed(user).maxMP]) * (direction === 'down' ? -1 : 1));
|
|
|
|
// Save history entry for habit
|
|
task.history = task.history || [];
|
|
const historyLength = task.history.length;
|
|
const lastHistoryEntry = task.history[historyLength - 1];
|
|
|
|
if (_lastHistoryEntryWasToday(lastHistoryEntry, user)) {
|
|
_updateLastHistoryEntry(lastHistoryEntry, task, direction, times);
|
|
if (task.markModified) {
|
|
task.markModified(`history.${historyLength - 1}`);
|
|
}
|
|
} else {
|
|
task.history.push({
|
|
date: Number(new Date()),
|
|
value: task.value,
|
|
scoredUp: direction === 'up' ? 1 : 0,
|
|
scoredDown: direction === 'down' ? 1 : 0,
|
|
});
|
|
}
|
|
|
|
_updateCounter(task, direction, times);
|
|
} else if (task.type === 'daily') {
|
|
if (cron) {
|
|
delta += _changeTaskValue(user, task, direction, times, cron);
|
|
_subtractPoints(user, task, stats, delta);
|
|
if (!user.stats.buffs.streaks) task.streak = 0;
|
|
} else {
|
|
delta += _changeTaskValue(user, task, direction, times, cron);
|
|
if (direction === 'down') delta = _calculateDelta(task, direction, cron); // recalculate delta for unchecking so the gp and exp come out correctly
|
|
// obviously for delta>0, but also a trick to undo accidental checkboxes
|
|
_addPoints(user, task, stats, direction, delta);
|
|
_gainMP(user, max([1, 0.01 * statsComputed(user).maxMP]) * (direction === 'down' ? -1 : 1));
|
|
|
|
if (direction === 'up') {
|
|
task.streak += 1;
|
|
// Give a streak achievement when the streak is a multiple of 21
|
|
if (task.streak !== 0 && task.streak % 21 === 0) {
|
|
user.achievements.streak = user.achievements.streak ? user.achievements.streak + 1 : 1;
|
|
if (user.addNotification) user.addNotification('STREAK_ACHIEVEMENT');
|
|
}
|
|
task.completed = true;
|
|
|
|
// Save history entry for daily
|
|
task.history = task.history || [];
|
|
const historyEntry = {
|
|
date: Number(new Date()),
|
|
value: task.value,
|
|
};
|
|
task.history.push(historyEntry);
|
|
} else if (direction === 'down') {
|
|
// Remove a streak achievement if streak was a multiple of 21 and the daily was undone
|
|
if (task.streak !== 0 && task.streak % 21 === 0) {
|
|
user.achievements.streak = user.achievements.streak ? user.achievements.streak - 1 : 0;
|
|
}
|
|
task.streak -= 1;
|
|
task.completed = false;
|
|
|
|
// Delete history entry when daily unchecked
|
|
if (task.history || task.history.length > 0) {
|
|
task.history.splice(-1, 1);
|
|
}
|
|
}
|
|
}
|
|
} else if (task.type === 'todo') {
|
|
if (cron) { // don't touch stats on cron
|
|
delta += _changeTaskValue(user, task, direction, times, cron);
|
|
} else {
|
|
if (direction === 'up') {
|
|
task.dateCompleted = new Date();
|
|
task.completed = true;
|
|
} else if (direction === 'down') {
|
|
task.completed = false;
|
|
task.dateCompleted = undefined;
|
|
}
|
|
|
|
delta += _changeTaskValue(user, task, direction, times, cron);
|
|
if (direction === 'down') delta = _calculateDelta(task, direction, cron); // recalculate delta for unchecking so the gp and exp come out correctly
|
|
_addPoints(user, task, stats, direction, delta);
|
|
|
|
// MP++ per checklist item in ToDo, bonus per CLI
|
|
const multiplier = max([reduce(task.checklist, (m, i) => m + (i.completed ? 1 : 0), 1), 1]);
|
|
_gainMP(user, max([multiplier, 0.01 * statsComputed(user).maxMP * multiplier]) * (direction === 'down' ? -1 : 1));
|
|
}
|
|
} else if (task.type === 'reward') {
|
|
// Don't adjust values for rewards
|
|
delta += _changeTaskValue(user, task, direction, times, cron);
|
|
// purchase item
|
|
stats.gp -= task.value;
|
|
}
|
|
|
|
req.yesterDailyScored = task.yesterDailyScored;
|
|
updateStats(user, stats, req);
|
|
|
|
if (!user.achievements.completedTask && cron === false && direction === 'up' && user.addAchievement) {
|
|
user.addAchievement('completedTask');
|
|
checkOnboardingStatus(user, req, analytics);
|
|
}
|
|
|
|
return [delta];
|
|
}
|