mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-16 14:17:22 +01:00
e2f4b0e3dc
* Added abiltiy to add group managers * Added ability to remove managers * Added ability for managers to add group tasks * Allower managers to assign tasks * Allowed managers to unassign tasks * Allow managers to delete group tasks * Allowed managers to approve * Added initial ui * Added approval view for managers * Allowed managers to edit * Fixed lint issues * Added spacing to buttons * Removed leader from selection of group managers * Code review updates * Ensured approvals are only done once * Added ability for parties to add managers * Add notifications to all managers when approval is requests * Removed tasks need approval notifications from all managers when task is approve * Fixed linting issues * Hid add managers UI from groups that are not subscribed * Removed let from front end * Fixed issues with post task url params * Fixed string locales * Removed extra limited strings * Added cannotedit tasks function * Added limit fields and notification check by taskId * Localized string and other minor issues * Added manager and leader indicator * Added group notifications refresh on sync * Added close button for group notifications * Removed group approval notifications when manager is removed * Moved leader/manager indicators to after hp * Added manager fields to groups * Spelling and syntax fixes
86 lines
2.4 KiB
JavaScript
86 lines
2.4 KiB
JavaScript
import {
|
|
generateUser,
|
|
createAndPopulateGroup,
|
|
translate as t,
|
|
} from '../../../../helpers/api-v3-integration.helper';
|
|
|
|
describe('POST /group/:groupId/add-manager', () => {
|
|
let leader, nonLeader, groupToUpdate;
|
|
let groupName = 'Test Public Guild';
|
|
let groupType = 'guild';
|
|
let nonMember;
|
|
|
|
context('Guilds', () => {
|
|
beforeEach(async () => {
|
|
let { group, groupLeader, members } = await createAndPopulateGroup({
|
|
groupDetails: {
|
|
name: groupName,
|
|
type: groupType,
|
|
privacy: 'public',
|
|
},
|
|
members: 1,
|
|
});
|
|
|
|
groupToUpdate = group;
|
|
leader = groupLeader;
|
|
nonLeader = members[0];
|
|
nonMember = await generateUser();
|
|
});
|
|
|
|
it('returns an error when a non group leader tries to add member', async () => {
|
|
await expect(nonLeader.post(`/groups/${groupToUpdate._id}/add-manager`, {
|
|
managerId: nonLeader._id,
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('messageGroupOnlyLeaderCanUpdate'),
|
|
});
|
|
});
|
|
|
|
it('returns an error when trying to promote a non member', async () => {
|
|
await expect(leader.post(`/groups/${groupToUpdate._id}/add-manager`, {
|
|
managerId: nonMember._id,
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('userMustBeMember'),
|
|
});
|
|
});
|
|
|
|
it('allows a leader to add managers', async () => {
|
|
let updatedGroup = await leader.post(`/groups/${groupToUpdate._id}/add-manager`, {
|
|
managerId: nonLeader._id,
|
|
});
|
|
|
|
expect(updatedGroup.managers[nonLeader._id]).to.be.true;
|
|
});
|
|
});
|
|
|
|
context('Party', () => {
|
|
let party, partyLeader, partyNonLeader;
|
|
|
|
beforeEach(async () => {
|
|
let { group, groupLeader, members } = await createAndPopulateGroup({
|
|
groupDetails: {
|
|
name: groupName,
|
|
type: 'party',
|
|
privacy: 'private',
|
|
},
|
|
members: 1,
|
|
});
|
|
|
|
party = group;
|
|
partyLeader = groupLeader;
|
|
partyNonLeader = members[0];
|
|
});
|
|
|
|
it('allows leader of party to add managers', async () => {
|
|
let updatedGroup = await partyLeader.post(`/groups/${party._id}/add-manager`, {
|
|
managerId: partyNonLeader._id,
|
|
});
|
|
|
|
expect(updatedGroup.managers[partyNonLeader._id]).to.be.true;
|
|
});
|
|
});
|
|
});
|