mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-10-27 19:22:55 +01:00
* WIP(a11y): task modal updates * fix(tasks): borders in modal * fix(tasks): circley locks * fix(task-modal): placeholders * WIP(task-modal): disabled states, hide empty options, +/- restyle * fix(task-modal): box shadows instead of borders, habit control pointer * fix(task-modal): button states? * fix(modal): tighten up layout, new spacing utils * fix(tasks): more stylin * fix(tasks): habit hovers * fix(css): checklist labels, a11y colors * fix(css): one more missed hover issue * fix(css): lock Challenges, label fixes * fix(css): scope input/textarea changes * fix(style): task tweakies * fix(style): more button fixage * WIP(component): start select list story * working example of a templated selectList * fix(style): more button corrections * fix(lint): EOL * fix(buttons): factor btn-secondary to better override Bootstrap * fix(styles): standardize more buttons * wip: difficulty select - style fixes * selectDifficulty works! 🎉 - fix styles * change the dropdown-item sizes only for the selectList ones * selectTranslatedArray * changed many label margins * more correct dropdown style * fix(modals): button corrections * input-group styling + datetime picker without today button * Style/margins for "repeat every" - extract selectTag.vue * working tag-selection / update - cleanup * fix stories * fix svg color on create modal (purple) * fix task modal bottom padding * correct dropdown shadow * update dropdown-toggle caret size / color * fixed checklist style * sync checked state * selectTag padding * fix spacing between positive/negative streak inputs * toggle-checkbox + fix some spacings * disable repeat-on when its a groupTask * fix new checklist-item * fix toggle-checkbox style - fix difficulty style * fix checklist ui * add tags label , when there arent any tags selected * WORKING select-tag component 🎉 * fix taglist story * show max 5 items in tag dropdown + "X more" label * fix datetime clear button * replace m-b-xs to mb-1 (bootstrap) - fix input-group-text style * fix styles of advanced settings * fix delete task styles * always show grippy on hover of the item * extract modal-text-input mixin + fix the borders/dropshadow * fix(spacing): revert most to Bootstrap * feat(checklists): make local copy of master checklist non-editable also aggressively update checklists because they weren't syncing?? * fix(checklists): handle add/remove options better * feat(teams): manager notes field * fix select/dropdown styles * input border + icon colors * delete task underline color * fix checklist "delete icon" vertical position * selectTag fixes - normal open/close toggle working again - remove icon color * fixing icons: Trash can - Delete Little X - Remove Big X - Close Block - Block * fix taglist margins / icon sizes * wip margin overview (in storybook) * fix routerlink * remove unused method * new selectTag style + add markdown inside tagList + scrollable tag selection * fix selectTag / selectList active border * fix difficulty select (svg default color) * fix input padding-left + fix reset habit streak fullwidth / padding + "repeat every" gray text (no border) * feat(teams): improved approval request > approve > reward flow * fix(tests): address failures * fix(lint): oops only * fix(tasks): short-circuit group related logic * fix(tasks): more short circuiting * fix(tasks): more lines, less lint * fix(tasks): how do i keep missing these * feat(teams): provide assigning user summary * fix(teams): don't attempt to record assiging user if not supplied * fix advanced-settings styling / margin * fix merge + hide advanced streak settings when none enabled * fix styles * set Roboto font for advanced settings * Add Challenge flag to the tag list * add tag with enter, when no other tag is found * fix styles + tag cancel button * refactor footer / margin * split repeat fields into option mt-3 groups * button all the things * fix(tasks): style updates * no hover state for non-editable tasks on team board * keep assign/claim footer on task after requesting approval * disable more fields on user copy of team task, and remove hover states for them * fix(tasks): functional revisions * "Claim Rewards" instead of "x" in task approved notif * Remove default transition supplied by Bootstrap, apply individually to some elements * Delete individual tasks and related notifications when master task deleted from team board * Manager notes now save when supplied at task initial creation * Can no longer dismiss rewards from approved task by hitting Dismiss All * fix(tasks): clean tasksOrder also adjust related test expectation * fix(tests): adjust integration expectations * fix(test): ratzen fratzen only * fix(teams): checklist, notes * fix(teams): improve disabled states * fix(teams): more style fixage * BREAKING(teams): return 202 instead of 401 for approval request * fix(teams): better taskboard sync also re-re-fix checklist borders * fix(tests): update expectations for breaking change * refactor(task-modal): lockable label component * refactor(teams): move task scoring to mixin * fix(teams): style corrections * fix(tasks): spacing and wording corrections * fix(teams): don't bork manager notes * fix(teams): assignment fix and more approval flow revisions * WIP(teams): use tag dropdown control for assignment * refactor(tasks): better spacing, generic multi select * fix(tasks): various visual and behavior updates * fix(tasks): incidental style tweaks * fix(teams): standardize approval request response * refactor(teams): correct test, use res.respond message param * fix(storybook): renamed component * fix(teams): age approval-required To Do's Fixes #8730 * fix(teams): sync personal data as well as team on mixin sync * fix(teams): hide unclaim button, not whole footer; fix switch focus * fix(achievements): unrevert width fix Co-authored-by: Sabe Jones <sabrecat@gmail.com>
144 lines
4.2 KiB
JavaScript
144 lines
4.2 KiB
JavaScript
import { find } from 'lodash';
|
||
import {
|
||
translate as t,
|
||
createAndPopulateGroup,
|
||
} from '../../../../../helpers/api-integration/v3';
|
||
|
||
describe('Groups DELETE /tasks/:id', () => {
|
||
let user; let guild; let member; let member2; let
|
||
task;
|
||
|
||
function findAssignedTask (memberTask) {
|
||
return memberTask.group.id === guild._id;
|
||
}
|
||
|
||
beforeEach(async () => {
|
||
const { group, members, groupLeader } = await createAndPopulateGroup({
|
||
groupDetails: {
|
||
name: 'Test Guild',
|
||
type: 'guild',
|
||
},
|
||
members: 2,
|
||
});
|
||
|
||
guild = group;
|
||
user = groupLeader;
|
||
member = members[0]; // eslint-disable-line prefer-destructuring
|
||
member2 = members[1]; // eslint-disable-line prefer-destructuring
|
||
|
||
task = await user.post(`/tasks/group/${guild._id}`, {
|
||
text: 'test habit',
|
||
type: 'habit',
|
||
up: false,
|
||
down: true,
|
||
notes: 1976,
|
||
});
|
||
|
||
await user.post(`/tasks/${task._id}/assign/${member._id}`);
|
||
await user.post(`/tasks/${task._id}/assign/${member2._id}`);
|
||
});
|
||
|
||
it('deletes a group task', async () => {
|
||
await user.del(`/tasks/${task._id}`);
|
||
|
||
await expect(user.get(`/tasks/${task._id}`))
|
||
.to.eventually.be.rejected.and.eql({
|
||
code: 404,
|
||
error: 'NotFound',
|
||
message: t('taskNotFound'),
|
||
});
|
||
});
|
||
|
||
it('allows a manager to delete a group task', async () => {
|
||
await user.post(`/groups/${guild._id}/add-manager`, {
|
||
managerId: member2._id,
|
||
});
|
||
|
||
await member2.del(`/tasks/${task._id}`);
|
||
|
||
await expect(user.get(`/tasks/${task._id}`))
|
||
.to.eventually.be.rejected.and.eql({
|
||
code: 404,
|
||
error: 'NotFound',
|
||
message: t('taskNotFound'),
|
||
});
|
||
});
|
||
|
||
it('removes deleted taskʾs approval pending notifications from managers', async () => {
|
||
await user.post(`/groups/${guild._id}/add-manager`, {
|
||
managerId: member2._id,
|
||
});
|
||
await user.put(`/tasks/${task._id}/`, {
|
||
requiresApproval: true,
|
||
});
|
||
const memberTasks = await member.get('/tasks/user');
|
||
const syncedTask = find(memberTasks, findAssignedTask);
|
||
await member.post(`/tasks/${syncedTask._id}/score/up`);
|
||
|
||
await user.sync();
|
||
await member2.sync();
|
||
expect(user.notifications.length).to.equal(2);
|
||
expect(user.notifications[1].type).to.equal('GROUP_TASK_APPROVAL');
|
||
expect(member2.notifications.length).to.equal(2);
|
||
expect(member2.notifications[1].type).to.equal('GROUP_TASK_APPROVAL');
|
||
|
||
await member2.del(`/tasks/${task._id}`);
|
||
|
||
await user.sync();
|
||
await member2.sync();
|
||
|
||
expect(user.notifications.length).to.equal(1);
|
||
expect(member2.notifications.length).to.equal(1);
|
||
});
|
||
|
||
it('deletes task from assigned user', async () => {
|
||
await user.del(`/tasks/${task._id}`);
|
||
|
||
const memberTasks = await member.get('/tasks/user');
|
||
const syncedTask = find(memberTasks, findAssignedTask);
|
||
|
||
expect(syncedTask).to.not.exist;
|
||
});
|
||
|
||
it('deletes task from all assigned users', async () => {
|
||
await user.del(`/tasks/${task._id}`);
|
||
|
||
const memberTasks = await member.get('/tasks/user');
|
||
const syncedTask = find(memberTasks, findAssignedTask);
|
||
|
||
const member2Tasks = await member2.get('/tasks/user');
|
||
const member2SyncedTask = find(member2Tasks, findAssignedTask);
|
||
|
||
expect(syncedTask).to.not.exist;
|
||
expect(member2SyncedTask).to.not.exist;
|
||
});
|
||
|
||
it('prevents a user from deleting a task they are assigned to', async () => {
|
||
const memberTasks = await member.get('/tasks/user');
|
||
const syncedTask = find(memberTasks, findAssignedTask);
|
||
|
||
await expect(member.del(`/tasks/${syncedTask._id}`))
|
||
.to.eventually.be.rejected.and.eql({
|
||
code: 401,
|
||
error: 'NotAuthorized',
|
||
message: t('cantDeleteAssignedGroupTasks'),
|
||
});
|
||
});
|
||
|
||
it('allows a user to delete a task after leaving a group', async () => {
|
||
const memberTasks = await member.get('/tasks/user');
|
||
const syncedTask = find(memberTasks, findAssignedTask);
|
||
|
||
await member.post(`/groups/${guild._id}/leave`);
|
||
|
||
await member.del(`/tasks/${syncedTask._id}`);
|
||
|
||
await expect(member.get(`/tasks/${syncedTask._id}`))
|
||
.to.eventually.be.rejected.and.eql({
|
||
code: 404,
|
||
error: 'NotFound',
|
||
message: 'Task not found.',
|
||
});
|
||
});
|
||
});
|