mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-16 22:27:26 +01:00
98c019a0b6
* common: import lodash modules separately * remove test/content from .eslintignore, fix with eslint --fix content/index * lint test/content * lint content/index except for lodash methods * upgrade server/models * upgrade server/middlewares and server/libs * port server/controllers/top-level * port server/controllers/api-v3 * port views and tests * client old port lodash and _(, missing _. * upgrade client-old * port common/script (root level files only) * port common/script/fns * port common/libs * port common/script/ops * port common/script/content and common/script/libs/shops.js * misc fixes * misc fixes * misc fixes * more tests fixes * fix payments test stubbing, down to 2 failing tests * remove more instances of lodash wrapping * fix bug where toObject does not clone object * fix tests * upgrade migration or add lodash 4 note * update shrinkwrap * fix linting * upgrade eslint-config-habitrpg * update shrinkwrap * recompile shrinkwrap
23 lines
702 B
JavaScript
23 lines
702 B
JavaScript
import isEmpty from 'lodash/isEmpty';
|
|
import maxBy from 'lodash/maxBy';
|
|
import values from 'lodash/values';
|
|
import uuid from './uuid';
|
|
|
|
/*
|
|
Reflists are arrays, but stored as objects. Mongoose has a helluvatime working with arrays (the main problem for our
|
|
syncing issues) - so the goal is to move away from arrays to objects, since mongoose can reference elements by ID
|
|
no problem. To maintain sorting, we use these helper functions:
|
|
*/
|
|
|
|
module.exports = function refPush (reflist, item) {
|
|
item.sort = isEmpty(reflist) ? 0 : maxBy(values(reflist), 'sort').sort + 1;
|
|
|
|
if (!(item.id && !reflist[item.id])) {
|
|
item.id = uuid();
|
|
}
|
|
|
|
reflist[item.id] = item;
|
|
|
|
return reflist[item.id];
|
|
};
|