mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-14 13:17:24 +01:00
* Add new API call to complete multiple task scorings in one call * Improve API response * Improve saving process * Improve handling for multiple tasks scored at once * Handle challenge task errors better * Improve check for alias * Improve check for task scorings * Fix merge errors * make nodemon ignore content_cache * Fix completing group tasks * fix test * fix tests (again) * typo * WIP(a11y): task modal updates * fix(tasks): borders in modal * fix(tasks): circley locks * fix(task-modal): placeholders * WIP(task-modal): disabled states, hide empty options, +/- restyle * fix(task-modal): box shadows instead of borders, habit control pointer * fix(task-modal): button states? * fix(modal): tighten up layout, new spacing utils * fix(tasks): more stylin * fix(tasks): habit hovers * fix(css): checklist labels, a11y colors * fix(css): one more missed hover issue * fix(css): lock Challenges, label fixes * fix(css): scope input/textarea changes * fix(style): task tweakies * fix(style): more button fixage * WIP(component): start select list story * working example of a templated selectList * fix(style): more button corrections * fix(lint): EOL * fix(buttons): factor btn-secondary to better override Bootstrap * fix(styles): standardize more buttons * wip: difficulty select - style fixes * selectDifficulty works! 🎉 - fix styles * change the dropdown-item sizes only for the selectList ones * selectTranslatedArray * changed many label margins * more correct dropdown style * fix(modals): button corrections * input-group styling + datetime picker without today button * Style/margins for "repeat every" - extract selectTag.vue * working tag-selection / update - cleanup * fix stories * fix svg color on create modal (purple) * fix task modal bottom padding * correct dropdown shadow * update dropdown-toggle caret size / color * fixed checklist style * sync checked state * selectTag padding * fix spacing between positive/negative streak inputs * toggle-checkbox + fix some spacings * disable repeat-on when its a groupTask * fix new checklist-item * fix toggle-checkbox style - fix difficulty style * fix checklist ui * add tags label , when there arent any tags selected * WORKING select-tag component 🎉 * fix taglist story * show max 5 items in tag dropdown + "X more" label * fix datetime clear button * replace m-b-xs to mb-1 (bootstrap) - fix input-group-text style * fix styles of advanced settings * fix delete task styles * always show grippy on hover of the item * extract modal-text-input mixin + fix the borders/dropshadow * fix(spacing): revert most to Bootstrap * feat(checklists): make local copy of master checklist non-editable also aggressively update checklists because they weren't syncing?? * fix(checklists): handle add/remove options better * feat(teams): manager notes field * fix select/dropdown styles * input border + icon colors * delete task underline color * fix checklist "delete icon" vertical position * selectTag fixes - normal open/close toggle working again - remove icon color * fixing icons: Trash can - Delete Little X - Remove Big X - Close Block - Block * fix taglist margins / icon sizes * wip margin overview (in storybook) * fix routerlink * remove unused method * new selectTag style + add markdown inside tagList + scrollable tag selection * fix selectTag / selectList active border * fix difficulty select (svg default color) * fix input padding-left + fix reset habit streak fullwidth / padding + "repeat every" gray text (no border) * feat(teams): improved approval request > approve > reward flow * fix(tests): address failures * fix(lint): oops only * fix(tasks): short-circuit group related logic * fix(tasks): more short circuiting * fix(tasks): more lines, less lint * fix(tasks): how do i keep missing these * feat(teams): provide assigning user summary * fix(teams): don't attempt to record assiging user if not supplied * fix advanced-settings styling / margin * fix merge + hide advanced streak settings when none enabled * fix styles * set Roboto font for advanced settings * Add Challenge flag to the tag list * add tag with enter, when no other tag is found * fix styles + tag cancel button * refactor footer / margin * split repeat fields into option mt-3 groups * button all the things * fix(tasks): style updates * no hover state for non-editable tasks on team board * keep assign/claim footer on task after requesting approval * disable more fields on user copy of team task, and remove hover states for them * fix(tasks): functional revisions * "Claim Rewards" instead of "x" in task approved notif * Remove default transition supplied by Bootstrap, apply individually to some elements * Delete individual tasks and related notifications when master task deleted from team board * Manager notes now save when supplied at task initial creation * Can no longer dismiss rewards from approved task by hitting Dismiss All * fix(tasks): clean tasksOrder also adjust related test expectation * fix(tests): adjust integration expectations * fix(test): ratzen fratzen only * fix lint * fix tests * fix(teams): checklist, notes * handleSharedCompletion: handle error, make sure it is run after the user task has been saved * fix typo * correctly handle errors in handleSharedCompletion when approving a task * fix(teams): improve disabled states * handleSharedCompletion: do not increase completions by 1 manually to adjust for last approval not saved yet * revert changes to config.json.example * fix(teams): more style fixage * add unit tests for findMultipleByIdOrAlias * exclude api v4 route from apidocs * BREAKING(teams): return 202 instead of 401 for approval request * fix(teams): better taskboard sync also re-re-fix checklist borders * scoreTasks: validate body * fix tests, move string to api errors * fix(tests): update expectations for breaking change * start updating api docs, process tasks sequentially to avoid conflicts with user._tmp * do not crash entire bulk operation in case of errors * save task only if modified * fix lint * undo changes to error handling: either all tasks scoring are successfull or none * remove stale code * do not return user._tmp when bulk scoring, it would be the last version only * make sure user._tmp.leveledUp is not lost when bulk scoring * rewards tests * mixed tests * fix tests, allow scoring the same task multiple times * finish integration tests * fix api docs for the bulk score route * refactor(task-modal): lockable label component * wip loading spinner * refactor(teams): move task scoring to mixin * fix(teams): style corrections * fix(btn): fix padding to have height of 32px * implement loading spinner * remove console.log warnings * fix(tasks): spacing and wording corrections * fix(teams): don't bork manager notes * fix(teams): assignment fix and more approval flow revisions * WIP(teams): use tag dropdown control for assignment * finish merge - never throw an error when a group task requires approval (wip - needs tests) * fix taskModal merge * fix merge * fix(task modal): add newline * fix(column.vue): add newline at end of file * mvp yesterdaily modal * fix tests * fix api docs for bulk scoring group tasks * separate task scoring and _tmp handling * handle _tmp when bulk scoring * rya: close modal before calling cron API, prevents issues with modals * rya: fix conflicts with other modals * add sounds, support for group plans, analytics * use asyncResource for group plans * fix lint * streak bonus: add comment about missing in rya * move yesterdailyModal * fix issues with level up modals and rya * add comments for future use, fix level up modals not showing up at levels with a quest drop * handle errors in rya modal * bundle quest and crit notifications Co-authored-by: Phillip Thelen <phillip@habitica.com> Co-authored-by: Phillip Thelen <viirus@pherth.net> Co-authored-by: Sabe Jones <sabrecat@gmail.com> Co-authored-by: negue <eugen.bolz@gmail.com>
304 lines
9.0 KiB
JavaScript
304 lines
9.0 KiB
JavaScript
import { each } from 'lodash';
|
|
import { model as Challenge } from '../../../../website/server/models/challenge';
|
|
import { model as Group } from '../../../../website/server/models/group';
|
|
import { model as User } from '../../../../website/server/models/user';
|
|
import * as Tasks from '../../../../website/server/models/task';
|
|
import { generateHistory } from '../../../helpers/api-unit.helper';
|
|
|
|
describe('Task Model', () => {
|
|
let guild; let leader; let challenge; let
|
|
task;
|
|
const tasksToTest = {
|
|
habit: {
|
|
text: 'test habit',
|
|
type: 'habit',
|
|
up: false,
|
|
down: true,
|
|
},
|
|
daily: {
|
|
text: 'test daily',
|
|
type: 'daily',
|
|
frequency: 'daily',
|
|
everyX: 5,
|
|
startDate: new Date(),
|
|
},
|
|
};
|
|
|
|
beforeEach(async () => {
|
|
guild = new Group({
|
|
name: 'test guild',
|
|
type: 'guild',
|
|
});
|
|
|
|
leader = new User({
|
|
guilds: [guild._id],
|
|
});
|
|
|
|
guild.leader = leader._id;
|
|
|
|
challenge = new Challenge({
|
|
name: 'Test Challenge',
|
|
shortName: 'Test',
|
|
leader: leader._id,
|
|
group: guild._id,
|
|
});
|
|
|
|
leader.challenges = [challenge._id];
|
|
|
|
await Promise.all([
|
|
guild.save(),
|
|
leader.save(),
|
|
challenge.save(),
|
|
]);
|
|
});
|
|
|
|
each(tasksToTest, (taskValue, taskType) => {
|
|
context(`${taskType}`, () => {
|
|
beforeEach(async () => {
|
|
task = new Tasks[`${taskType}`](Tasks.Task.sanitize(taskValue));
|
|
task.challenge.id = challenge._id;
|
|
task.history = generateHistory(396);
|
|
await task.save();
|
|
});
|
|
|
|
it('preens challenge tasks history when scored', async () => {
|
|
const historyLengthBeforePreen = task.history.length;
|
|
|
|
await task.scoreChallengeTask(1.2);
|
|
|
|
const updatedTask = await Tasks.Task.findOne({ _id: task._id });
|
|
|
|
expect(historyLengthBeforePreen).to.be.greaterThan(updatedTask.history.length);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('Static Methods', () => {
|
|
describe('findByIdOrAlias', () => {
|
|
let taskWithAlias; let
|
|
user;
|
|
|
|
beforeEach(async () => {
|
|
user = new User();
|
|
await user.save();
|
|
|
|
taskWithAlias = new Tasks.todo({ // eslint-disable-line new-cap
|
|
text: 'some text',
|
|
alias: 'short-name',
|
|
userId: user.id,
|
|
});
|
|
await taskWithAlias.save();
|
|
|
|
sandbox.spy(Tasks.Task, 'findOne');
|
|
});
|
|
|
|
it('throws an error if task identifier is not passed in', async () => {
|
|
try {
|
|
await Tasks.Task.findByIdOrAlias(null, user._id);
|
|
throw new Error('No exception when Id is None');
|
|
} catch (err) {
|
|
expect(err).to.exist;
|
|
expect(err).to.be.an.instanceOf(Error);
|
|
expect(err.message).to.eql('Task identifier is a required argument');
|
|
}
|
|
});
|
|
|
|
it('throws an error if user identifier is not passed in', async () => {
|
|
try {
|
|
await Tasks.Task.findByIdOrAlias(taskWithAlias._id);
|
|
throw new Error('No exception when user_id is undefined');
|
|
} catch (err) {
|
|
expect(err).to.exist;
|
|
expect(err).to.be.an.instanceOf(Error);
|
|
expect(err.message).to.eql('User identifier is a required argument');
|
|
}
|
|
});
|
|
|
|
it('returns task by id', async () => {
|
|
const foundTodo = await Tasks.Task.findByIdOrAlias(taskWithAlias._id, user._id);
|
|
|
|
expect(foundTodo.text).to.eql(taskWithAlias.text);
|
|
});
|
|
|
|
it('returns task by alias', async () => {
|
|
const foundTodo = await Tasks.Task.findByIdOrAlias(taskWithAlias.alias, user._id);
|
|
|
|
expect(foundTodo.text).to.eql(taskWithAlias.text);
|
|
});
|
|
|
|
it('scopes alias lookup to user', async () => {
|
|
await Tasks.Task.findByIdOrAlias(taskWithAlias.alias, user._id);
|
|
|
|
expect(Tasks.Task.findOne).to.be.calledOnce;
|
|
expect(Tasks.Task.findOne).to.be.calledWithMatch({
|
|
alias: taskWithAlias.alias,
|
|
userId: user._id,
|
|
});
|
|
});
|
|
|
|
it('returns null if task cannot be found', async () => {
|
|
const foundTask = await Tasks.Task.findByIdOrAlias('not-found', user._id);
|
|
|
|
expect(foundTask).to.eql(null);
|
|
});
|
|
|
|
it('accepts additional query parameters', async () => {
|
|
await Tasks.Task.findByIdOrAlias(taskWithAlias.alias, user._id, { foo: 'bar' });
|
|
|
|
expect(Tasks.Task.findOne).to.be.calledOnce;
|
|
expect(Tasks.Task.findOne).to.be.calledWithMatch({
|
|
foo: 'bar',
|
|
alias: taskWithAlias.alias,
|
|
userId: user._id,
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('findMultipleByIdOrAlias', () => {
|
|
let taskWithAlias;
|
|
let secondTask;
|
|
let user;
|
|
|
|
beforeEach(async () => {
|
|
user = new User();
|
|
await user.save();
|
|
|
|
taskWithAlias = new Tasks.todo({ // eslint-disable-line new-cap
|
|
text: 'some text',
|
|
alias: 'short-name',
|
|
userId: user.id,
|
|
});
|
|
await taskWithAlias.save();
|
|
|
|
secondTask = new Tasks.habit({ // eslint-disable-line new-cap
|
|
text: 'second task',
|
|
alias: 'second-short-name',
|
|
userId: user.id,
|
|
});
|
|
await secondTask.save();
|
|
|
|
sandbox.spy(Tasks.Task, 'find');
|
|
});
|
|
|
|
it('throws an error if task identifiers is not passed in', async () => {
|
|
try {
|
|
await Tasks.Task.findMultipleByIdOrAlias(null, user._id);
|
|
throw new Error('No exception when Id is None');
|
|
} catch (err) {
|
|
expect(err).to.exist;
|
|
expect(err).to.be.an.instanceOf(Error);
|
|
expect(err.message).to.eql('Task identifiers is a required array argument');
|
|
}
|
|
});
|
|
|
|
it('throws an error if task identifiers is not an array', async () => {
|
|
try {
|
|
await Tasks.Task.findMultipleByIdOrAlias('string', user._id);
|
|
throw new Error('No exception when Id is None');
|
|
} catch (err) {
|
|
expect(err).to.exist;
|
|
expect(err).to.be.an.instanceOf(Error);
|
|
expect(err.message).to.eql('Task identifiers is a required array argument');
|
|
}
|
|
});
|
|
|
|
it('throws an error if user identifier is not passed in', async () => {
|
|
try {
|
|
await Tasks.Task.findMultipleByIdOrAlias([taskWithAlias._id]);
|
|
throw new Error('No exception when user_id is undefined');
|
|
} catch (err) {
|
|
expect(err).to.exist;
|
|
expect(err).to.be.an.instanceOf(Error);
|
|
expect(err.message).to.eql('User identifier is a required argument');
|
|
}
|
|
});
|
|
|
|
it('returns task by id', async () => {
|
|
const foundTasks = await Tasks.Task.findMultipleByIdOrAlias([taskWithAlias._id], user._id);
|
|
|
|
expect(foundTasks[0].text).to.eql(taskWithAlias.text);
|
|
});
|
|
|
|
it('returns task by alias', async () => {
|
|
const foundTasks = await Tasks.Task.findMultipleByIdOrAlias(
|
|
[taskWithAlias.alias], user._id,
|
|
);
|
|
|
|
expect(foundTasks[0].text).to.eql(taskWithAlias.text);
|
|
});
|
|
|
|
it('returns multiple tasks', async () => {
|
|
const foundTasks = await Tasks.Task.findMultipleByIdOrAlias(
|
|
[taskWithAlias.alias, secondTask._id], user._id,
|
|
);
|
|
|
|
expect(foundTasks.length).to.eql(2);
|
|
expect(foundTasks[0]._id).to.eql(taskWithAlias._id);
|
|
expect(foundTasks[1]._id).to.eql(secondTask._id);
|
|
});
|
|
|
|
it('returns a task only once if searched by both id and alias', async () => {
|
|
const foundTasks = await Tasks.Task.findMultipleByIdOrAlias(
|
|
[taskWithAlias.alias, taskWithAlias._id], user._id,
|
|
);
|
|
|
|
expect(foundTasks.length).to.eql(1);
|
|
expect(foundTasks[0].text).to.eql(taskWithAlias.text);
|
|
});
|
|
|
|
it('scopes alias lookup to user', async () => {
|
|
await Tasks.Task.findMultipleByIdOrAlias([taskWithAlias.alias], user._id);
|
|
|
|
expect(Tasks.Task.find).to.be.calledOnce;
|
|
expect(Tasks.Task.find).to.be.calledWithMatch({
|
|
$or: [
|
|
{ _id: { $in: [] } },
|
|
{ alias: { $in: [taskWithAlias.alias] } },
|
|
],
|
|
userId: user._id,
|
|
});
|
|
});
|
|
|
|
it('returns empty array if tasks cannot be found', async () => {
|
|
const foundTasks = await Tasks.Task.findMultipleByIdOrAlias(['not-found'], user._id);
|
|
|
|
expect(foundTasks).to.eql([]);
|
|
});
|
|
|
|
it('accepts additional query parameters', async () => {
|
|
await Tasks.Task.findMultipleByIdOrAlias([taskWithAlias.alias], user._id, { foo: 'bar' });
|
|
|
|
expect(Tasks.Task.find).to.be.calledOnce;
|
|
expect(Tasks.Task.find).to.be.calledWithMatch({
|
|
$or: [
|
|
{ _id: { $in: [] } },
|
|
{ alias: { $in: [taskWithAlias.alias] } },
|
|
],
|
|
userId: user._id,
|
|
foo: 'bar',
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('sanitizeUserChallengeTask ', () => {
|
|
});
|
|
|
|
describe('sanitizeChecklist ', () => {
|
|
});
|
|
|
|
describe('sanitizeReminder ', () => {
|
|
});
|
|
|
|
describe('fromJSONV2 ', () => {
|
|
});
|
|
});
|
|
|
|
describe('Instance Methods', () => {
|
|
describe('scoreChallengeTask', () => {
|
|
});
|
|
|
|
describe('toJSONV2', () => {
|
|
});
|
|
});
|
|
});
|