mirror of
				https://github.com/HabitRPG/habitica.git
				synced 2025-10-31 05:05:07 +01:00 
			
		
		
		
	* add max length validations for summary in challenge create and update controllers * Add validation to group APIs * fix lint errors * add validation to group plan * fix imports * add tests * add max length validations for summary in challenge create and update controllers * Add validation to group APIs * fix lint errors * add validation to group plan * fix imports * add tests * lint checks
		
			
				
	
	
		
			337 lines
		
	
	
		
			9.3 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			337 lines
		
	
	
		
			9.3 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| import {
 | |
|   generateUser,
 | |
|   translate as t,
 | |
| } from '../../../../helpers/api-integration/v3';
 | |
| import { model as Group } from '../../../../../website/server/models/group';
 | |
| import { MAX_SUMMARY_SIZE_FOR_GUILDS } from '../../../../../website/common/script/constants';
 | |
| 
 | |
| describe('POST /group', () => {
 | |
|   let user;
 | |
| 
 | |
|   beforeEach(async () => {
 | |
|     user = await generateUser({ balance: 10 });
 | |
|   });
 | |
| 
 | |
|   context('All Groups', () => {
 | |
|     it('it returns validation error when type is not provided', async () => {
 | |
|       await expect(
 | |
|         user.post('/groups', { name: 'Test Group Without Type' }),
 | |
|       ).to.eventually.be.rejected.and.eql({
 | |
|         code: 400,
 | |
|         error: 'BadRequest',
 | |
|         message: 'Group validation failed',
 | |
|       });
 | |
|     });
 | |
| 
 | |
|     it('it returns validation error when type is not supported', async () => {
 | |
|       await expect(
 | |
|         user.post('/groups', { name: 'Group with unsupported type', type: 'foo' }),
 | |
|       ).to.eventually.be.rejected.and.eql({
 | |
|         code: 400,
 | |
|         error: 'BadRequest',
 | |
|         message: 'Group validation failed',
 | |
|       });
 | |
|     });
 | |
| 
 | |
|     it('sets the group leader to the user who created the group', async () => {
 | |
|       const group = await user.post('/groups', {
 | |
|         name: 'Test Public Guild',
 | |
|         type: 'guild',
 | |
|       });
 | |
| 
 | |
|       expect(group.leader).to.eql({
 | |
|         _id: user._id,
 | |
|         profile: {
 | |
|           name: user.profile.name,
 | |
|         },
 | |
|       });
 | |
|     });
 | |
| 
 | |
|     it('sets summary to groups name when not supplied', async () => {
 | |
|       const name = 'Test Group';
 | |
|       const group = await user.post('/groups', {
 | |
|         name,
 | |
|         type: 'guild',
 | |
|       });
 | |
| 
 | |
|       const updatedGroup = await user.get(`/groups/${group._id}`);
 | |
| 
 | |
|       expect(updatedGroup.summary).to.eql(name);
 | |
|     });
 | |
| 
 | |
|     it('sets summary to groups', async () => {
 | |
|       const name = 'Test Group';
 | |
|       const summary = 'Test Summary';
 | |
|       const group = await user.post('/groups', {
 | |
|         name,
 | |
|         type: 'guild',
 | |
|         summary,
 | |
|       });
 | |
| 
 | |
|       const updatedGroup = await user.get(`/groups/${group._id}`);
 | |
| 
 | |
|       expect(updatedGroup.summary).to.eql(summary);
 | |
|     });
 | |
| 
 | |
|     it('returns error when summary is longer than MAX_SUMMARY_SIZE_FOR_GUILDS characters', async () => {
 | |
|       const name = 'Test Group';
 | |
|       const summary = 'A'.repeat(MAX_SUMMARY_SIZE_FOR_GUILDS + 1);
 | |
|       await expect(user.post('/groups', {
 | |
|         name,
 | |
|         type: 'guild',
 | |
|         summary,
 | |
|       })).to.eventually.be.rejected.and.eql({
 | |
|         code: 400,
 | |
|         error: 'BadRequest',
 | |
|         message: t('invalidReqParams'),
 | |
|       });
 | |
|     });
 | |
|   });
 | |
| 
 | |
|   context('Guilds', () => {
 | |
|     it('returns an error when a user with insufficient funds attempts to create a guild', async () => {
 | |
|       await user.update({ balance: 0 });
 | |
| 
 | |
|       await expect(
 | |
|         user.post('/groups', {
 | |
|           name: 'Test Public Guild',
 | |
|           type: 'guild',
 | |
|         }),
 | |
|       ).to.eventually.be.rejected.and.eql({
 | |
|         code: 401,
 | |
|         error: 'NotAuthorized',
 | |
|         message: t('messageInsufficientGems'),
 | |
|       });
 | |
|     });
 | |
| 
 | |
|     it('adds guild to user\'s list of guilds', async () => {
 | |
|       const guild = await user.post('/groups', {
 | |
|         name: 'some guild',
 | |
|         type: 'guild',
 | |
|         privacy: 'public',
 | |
|       });
 | |
| 
 | |
|       const updatedUser = await user.get('/user');
 | |
| 
 | |
|       expect(updatedUser.guilds).to.include(guild._id);
 | |
|     });
 | |
| 
 | |
|     it('awards the Joined Guild achievement', async () => {
 | |
|       await user.post('/groups', {
 | |
|         name: 'some guild',
 | |
|         type: 'guild',
 | |
|         privacy: 'public',
 | |
|       });
 | |
| 
 | |
|       const updatedUser = await user.get('/user');
 | |
| 
 | |
|       expect(updatedUser.achievements.joinedGuild).to.eql(true);
 | |
|     });
 | |
| 
 | |
|     context('public guild', () => {
 | |
|       it('creates a group', async () => {
 | |
|         const groupName = 'Test Public Guild';
 | |
|         const groupType = 'guild';
 | |
|         const groupPrivacy = 'public';
 | |
| 
 | |
|         const publicGuild = await user.post('/groups', {
 | |
|           name: groupName,
 | |
|           type: groupType,
 | |
|           privacy: groupPrivacy,
 | |
|         });
 | |
| 
 | |
|         expect(publicGuild._id).to.exist;
 | |
|         expect(publicGuild.name).to.equal(groupName);
 | |
|         expect(publicGuild.type).to.equal(groupType);
 | |
|         expect(publicGuild.memberCount).to.equal(1);
 | |
|         expect(publicGuild.privacy).to.equal(groupPrivacy);
 | |
|         expect(publicGuild.leader).to.eql({
 | |
|           _id: user._id,
 | |
|           profile: {
 | |
|             name: user.profile.name,
 | |
|           },
 | |
|         });
 | |
|       });
 | |
| 
 | |
|       it('returns an error when a user with no chat privileges attempts to create a public guild', async () => {
 | |
|         await user.update({ 'flags.chatRevoked': true });
 | |
| 
 | |
|         await expect(
 | |
|           user.post('/groups', {
 | |
|             name: 'Test Public Guild',
 | |
|             type: 'guild',
 | |
|             privacy: 'public',
 | |
|           }),
 | |
|         ).to.eventually.be.rejected.and.eql({
 | |
|           code: 401,
 | |
|           error: 'NotAuthorized',
 | |
|           message: t('chatPrivilegesRevoked'),
 | |
|         });
 | |
|       });
 | |
|     });
 | |
| 
 | |
|     context('private guild', () => {
 | |
|       const groupName = 'Test Private Guild';
 | |
|       const groupType = 'guild';
 | |
|       const groupPrivacy = 'private';
 | |
| 
 | |
|       it('creates a group', async () => {
 | |
|         const privateGuild = await user.post('/groups', {
 | |
|           name: groupName,
 | |
|           type: groupType,
 | |
|           privacy: groupPrivacy,
 | |
|         });
 | |
| 
 | |
|         expect(privateGuild._id).to.exist;
 | |
|         expect(privateGuild.name).to.equal(groupName);
 | |
|         expect(privateGuild.type).to.equal(groupType);
 | |
|         expect(privateGuild.memberCount).to.equal(1);
 | |
|         expect(privateGuild.privacy).to.equal(groupPrivacy);
 | |
|         expect(privateGuild.leader).to.eql({
 | |
|           _id: user._id,
 | |
|           profile: {
 | |
|             name: user.profile.name,
 | |
|           },
 | |
|         });
 | |
|       });
 | |
| 
 | |
|       it('creates a private guild when the user has no chat privileges', async () => {
 | |
|         await user.update({ 'flags.chatRevoked': true });
 | |
|         const privateGuild = await user.post('/groups', {
 | |
|           name: groupName,
 | |
|           type: groupType,
 | |
|           privacy: groupPrivacy,
 | |
|         });
 | |
| 
 | |
|         expect(privateGuild._id).to.exist;
 | |
|       });
 | |
| 
 | |
|       it('deducts gems from user and adds them to guild bank', async () => {
 | |
|         const privateGuild = await user.post('/groups', {
 | |
|           name: groupName,
 | |
|           type: groupType,
 | |
|           privacy: groupPrivacy,
 | |
|         });
 | |
| 
 | |
|         expect(privateGuild.balance).to.eql(1);
 | |
| 
 | |
|         const updatedUser = await user.get('/user');
 | |
| 
 | |
|         expect(updatedUser.balance).to.eql(user.balance - 1);
 | |
|       });
 | |
| 
 | |
|       it('does not deduct the gems from user when guild creation fails', async () => {
 | |
|         const stub = sinon.stub(Group.prototype, 'save').rejects();
 | |
|         const promise = user.post('/groups', {
 | |
|           name: groupName,
 | |
|           type: groupType,
 | |
|           privacy: groupPrivacy,
 | |
|         });
 | |
| 
 | |
|         await expect(promise).to.eventually.be.rejected;
 | |
| 
 | |
|         const updatedUser = await user.get('/user');
 | |
| 
 | |
|         expect(updatedUser.balance).to.eql(user.balance);
 | |
| 
 | |
|         stub.restore();
 | |
|       });
 | |
|     });
 | |
|   });
 | |
| 
 | |
|   context('Parties', () => {
 | |
|     const partyName = 'Test Party';
 | |
|     const partyType = 'party';
 | |
| 
 | |
|     it('creates a party', async () => {
 | |
|       const party = await user.post('/groups', {
 | |
|         name: partyName,
 | |
|         type: partyType,
 | |
|       });
 | |
| 
 | |
|       expect(party._id).to.exist;
 | |
|       expect(party.name).to.equal(partyName);
 | |
|       expect(party.type).to.equal(partyType);
 | |
|       expect(party.memberCount).to.equal(1);
 | |
|       expect(party.leader).to.eql({
 | |
|         _id: user._id,
 | |
|         profile: {
 | |
|           name: user.profile.name,
 | |
|         },
 | |
|       });
 | |
|     });
 | |
| 
 | |
|     it('creates a party when the user has no chat privileges', async () => {
 | |
|       await user.update({ 'flags.chatRevoked': true });
 | |
|       const party = await user.post('/groups', {
 | |
|         name: partyName,
 | |
|         type: partyType,
 | |
|       });
 | |
| 
 | |
|       expect(party._id).to.exist;
 | |
|     });
 | |
| 
 | |
|     it('does not require gems to create a party', async () => {
 | |
|       await user.update({ balance: 0 });
 | |
| 
 | |
|       const party = await user.post('/groups', {
 | |
|         name: partyName,
 | |
|         type: partyType,
 | |
|       });
 | |
| 
 | |
|       expect(party._id).to.exist;
 | |
| 
 | |
|       const updatedUser = await user.get('/user');
 | |
| 
 | |
|       expect(updatedUser.balance).to.eql(user.balance);
 | |
|     });
 | |
| 
 | |
|     it('sets party id on user object', async () => {
 | |
|       const party = await user.post('/groups', {
 | |
|         name: partyName,
 | |
|         type: partyType,
 | |
|       });
 | |
| 
 | |
|       const updatedUser = await user.get('/user');
 | |
| 
 | |
|       expect(updatedUser.party._id).to.eql(party._id);
 | |
|     });
 | |
| 
 | |
|     it('does not award Party Up achievement to solo partier', async () => {
 | |
|       await user.post('/groups', {
 | |
|         name: partyName,
 | |
|         type: partyType,
 | |
|       });
 | |
| 
 | |
|       const updatedUser = await user.get('/user');
 | |
| 
 | |
|       expect(updatedUser.achievements.partyUp).to.not.eql(true);
 | |
|     });
 | |
| 
 | |
|     it('prevents user in a party from creating another party', async () => {
 | |
|       await user.post('/groups', {
 | |
|         name: partyName,
 | |
|         type: partyType,
 | |
|       });
 | |
| 
 | |
|       await expect(user.post('/groups')).to.eventually.be.rejected.and.eql({
 | |
|         code: 401,
 | |
|         error: 'NotAuthorized',
 | |
|         message: t('messageGroupAlreadyInParty'),
 | |
|       });
 | |
|     });
 | |
| 
 | |
|     it('prevents creating a public party', async () => {
 | |
|       await expect(user.post('/groups', {
 | |
|         name: partyName,
 | |
|         type: partyType,
 | |
|         privacy: 'public',
 | |
|       })).to.eventually.be.rejected.and.eql({
 | |
|         code: 401,
 | |
|         error: 'NotAuthorized',
 | |
|         message: t('partyMustbePrivate'),
 | |
|       });
 | |
|     });
 | |
|   });
 | |
| });
 |