mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-10-26 18:52:37 +01:00
* fix(teams): no hover bg change for noninteractive checkboxes * feat(teams): send notification to managers on task claim Also fix client unit test broken by prev commit * feat(groups): don't penalize for tasks assigned since last activity * fix(tests): actually fix client unit * fix(teams): improve task styles * fix(teams): let people other than leader see relevant approvals Also more style fixes * fix(approvals): better filtering and task headings for approval data * fix(test): correct test expectations for new GET /approvals behavior * fix(groups): style tweaks * different border for group and normal tasks * fix(teams): remove extra click for claiming * fix(teams): leaders & managers can check off approval-required tasks * fix(teams): don't notify user of own claim * fix group task margin and z-index on hover * fix(menu): sporadic error in top bar * fix(teams): more approval header and footer adjustments * fix(tests): adjust expectations for self-approval * fix(teams): address PR comments * refactor(timestamps): date user activity on authenticated requests * refactor(timestamps): update local user instead of direct db update
94 lines
2.8 KiB
JavaScript
94 lines
2.8 KiB
JavaScript
import {
|
|
createAndPopulateGroup,
|
|
translate as t,
|
|
} from '../../../../helpers/api-integration/v3';
|
|
import { find } from 'lodash';
|
|
|
|
describe('POST /group/:groupId/remove-manager', () => {
|
|
let leader, nonLeader, groupToUpdate;
|
|
let groupName = 'Test Public Guild';
|
|
let groupType = 'guild';
|
|
let nonManager;
|
|
|
|
function findAssignedTask (memberTask) {
|
|
return memberTask.group.id === groupToUpdate._id;
|
|
}
|
|
|
|
beforeEach(async () => {
|
|
let { group, groupLeader, members } = await createAndPopulateGroup({
|
|
groupDetails: {
|
|
name: groupName,
|
|
type: groupType,
|
|
privacy: 'public',
|
|
},
|
|
members: 2,
|
|
});
|
|
|
|
groupToUpdate = group;
|
|
leader = groupLeader;
|
|
nonLeader = members[0];
|
|
nonManager = members[1];
|
|
});
|
|
|
|
it('returns an error when a non group leader tries to add member', async () => {
|
|
await expect(nonLeader.post(`/groups/${groupToUpdate._id}/remove-manager`, {
|
|
managerId: nonLeader._id,
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('messageGroupOnlyLeaderCanUpdate'),
|
|
});
|
|
});
|
|
|
|
it('returns an error when manager does not exist', async () => {
|
|
await expect(leader.post(`/groups/${groupToUpdate._id}/remove-manager`, {
|
|
managerId: nonManager._id,
|
|
})).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('userIsNotManager'),
|
|
});
|
|
});
|
|
|
|
it('allows a leader to remove managers', async () => {
|
|
await leader.post(`/groups/${groupToUpdate._id}/add-manager`, {
|
|
managerId: nonLeader._id,
|
|
});
|
|
|
|
let updatedGroup = await leader.post(`/groups/${groupToUpdate._id}/remove-manager`, {
|
|
managerId: nonLeader._id,
|
|
});
|
|
|
|
expect(updatedGroup.managers[nonLeader._id]).to.not.exist;
|
|
});
|
|
|
|
it('removes group approval notifications from a manager that is removed', async () => {
|
|
await leader.post(`/groups/${groupToUpdate._id}/add-manager`, {
|
|
managerId: nonLeader._id,
|
|
});
|
|
let task = await leader.post(`/tasks/group/${groupToUpdate._id}`, {
|
|
text: 'test todo',
|
|
type: 'todo',
|
|
requiresApproval: true,
|
|
});
|
|
await nonLeader.post(`/tasks/${task._id}/assign/${nonManager._id}`);
|
|
let memberTasks = await nonManager.get('/tasks/user');
|
|
let syncedTask = find(memberTasks, findAssignedTask);
|
|
await expect(nonManager.post(`/tasks/${syncedTask._id}/score/up`))
|
|
.to.eventually.be.rejected.and.to.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('taskApprovalHasBeenRequested'),
|
|
});
|
|
|
|
let updatedGroup = await leader.post(`/groups/${groupToUpdate._id}/remove-manager`, {
|
|
managerId: nonLeader._id,
|
|
});
|
|
|
|
await nonLeader.sync();
|
|
|
|
expect(nonLeader.notifications.length).to.equal(0);
|
|
expect(updatedGroup.managers[nonLeader._id]).to.not.exist;
|
|
});
|
|
});
|