Robert Whitaker af1d13d3a2 Fix bug where updated webhook options failed to save (fixes #12336) (#12342) ...

* Fix bug where updated webhook options failed to save

This bug was caused by Mongoose not creating getters/setters for array
elements (https://mongoosejs.com/docs/faq.html#array-changes-not-saved).
So, although the webhook was being updated properly, Mongoose was not
actually committing it to the database. Telling Mongoose that the array
of webhooks has changed via `markModified` fixes the issue.

Additionally, the relevant API test case was only checking whether or
not the webhook returned from the PUT endpoint matched the expected
update. Since the endpoint was returning the updated webhook without
querying the database again, this test case would pass. It has been
updated to check both the returned webhook as well as the version of the
webhook that is saved to the database against the expected. In other
words:

`assert returned === saved === expected`

Fixes #12336

* Call markModified on webhook.options instead of user.webhooks

This tells Mongoose that only the modified webhook's options changed
instead of telling it that the entire user.webhooks array changed,
saving a costly DB update.

2020-07-03 16:48:45 +02:00

..

DELETE-user_delete_webhook.test.js

fix test lint

2019-10-08 20:45:38 +02:00

GET-user-webhook.test.js

fix test lint

2019-10-08 20:45:38 +02:00

POST-user_add_webhook.test.js

Disable Failing Webhooks (#11966)

2020-03-20 23:26:21 +01:00

PUT-user_update_webhook.test.js

Fix bug where updated webhook options failed to save (fixes #12336) (#12342)

2020-07-03 16:48:45 +02:00