mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-10-31 05:05:07 +01:00
98c019a0b6
* common: import lodash modules separately * remove test/content from .eslintignore, fix with eslint --fix content/index * lint test/content * lint content/index except for lodash methods * upgrade server/models * upgrade server/middlewares and server/libs * port server/controllers/top-level * port server/controllers/api-v3 * port views and tests * client old port lodash and _(, missing _. * upgrade client-old * port common/script (root level files only) * port common/script/fns * port common/libs * port common/script/ops * port common/script/content and common/script/libs/shops.js * misc fixes * misc fixes * misc fixes * more tests fixes * fix payments test stubbing, down to 2 failing tests * remove more instances of lodash wrapping * fix bug where toObject does not clone object * fix tests * upgrade migration or add lodash 4 note * update shrinkwrap * fix linting * upgrade eslint-config-habitrpg * update shrinkwrap * recompile shrinkwrap
42 lines
1.8 KiB
JavaScript
42 lines
1.8 KiB
JavaScript
/**
|
|
* 745612d and fedc5b6 added a db-subscription optimization to the initial subscribe.
|
|
* However, it requires the user only be to one party. That should be the case anyway, but user.party.current was letting
|
|
* us look past the fact that a user was erroneously subscribed to multiple parties. This fixes
|
|
*
|
|
* mongo habitrpg ./node_modules/underscore/underscore.js ./migrations/20130508_fix_duff_party_subscriptions.js
|
|
*/
|
|
|
|
// IMPORTANT NOTE: this migration was written when we were using version 3 of lodash.
|
|
// We've now upgraded to lodash v4 but the code used in this migration has not been
|
|
// adapted to work with it. Before this migration is used again any lodash method should
|
|
// be checked for compatibility against the v4 changelog and changed if necessary.
|
|
// https://github.com/lodash/lodash/wiki/Changelog#v400
|
|
|
|
// since our primary subscription will first hit parties now, we *definitely* need an index there
|
|
db.parties.ensureIndex( { 'members': 1}, {background: true} );
|
|
|
|
db.parties.find().forEach(function(party){
|
|
|
|
if(!party.members) {
|
|
return db.parties.remove({_id:party._id});
|
|
}
|
|
|
|
// Find all members
|
|
db.users.find( {_id: {$in:party.members} }, {_id:1,party:1} ).forEach(function(user){
|
|
// user somehow is subscribed to this party in the background, but they're it's not their primary party
|
|
if (user.party && user.party.current !== party._id) {
|
|
var i = party.members.indexOf(user._id);
|
|
party.members.splice(i, 1);
|
|
}
|
|
|
|
// if after we remove the user, the party is empty - delete this party
|
|
if (_.isEmpty(party.members)) {
|
|
db.parties.remove({_id:party._id});
|
|
|
|
// else just set it
|
|
} else {
|
|
db.parties.update({_id:party._id}, {$set:{members:party.members}});
|
|
}
|
|
})
|
|
})
|