mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-17 22:57:21 +01:00
01d272d2c4
* fix(teams): no hover bg change for noninteractive checkboxes * feat(teams): send notification to managers on task claim Also fix client unit test broken by prev commit * feat(groups): don't penalize for tasks assigned since last activity * fix(tests): actually fix client unit * fix(teams): improve task styles * fix(teams): let people other than leader see relevant approvals Also more style fixes * fix(approvals): better filtering and task headings for approval data * fix(test): correct test expectations for new GET /approvals behavior * fix(groups): style tweaks * different border for group and normal tasks * fix(teams): remove extra click for claiming * fix(teams): leaders & managers can check off approval-required tasks * fix(teams): don't notify user of own claim * fix group task margin and z-index on hover * fix(menu): sporadic error in top bar * fix(teams): more approval header and footer adjustments * fix(tests): adjust expectations for self-approval * fix(teams): address PR comments * refactor(timestamps): date user activity on authenticated requests * refactor(timestamps): update local user instead of direct db update
77 lines
2.3 KiB
JavaScript
77 lines
2.3 KiB
JavaScript
import {
|
|
createAndPopulateGroup,
|
|
} from '../../../../../helpers/api-integration/v3';
|
|
import { find } from 'lodash';
|
|
|
|
describe('GET /approvals/group/:groupId', () => {
|
|
let user, guild, member, addlMember, task, syncedTask, addlSyncedTask;
|
|
|
|
function findAssignedTask (memberTask) {
|
|
return memberTask.group.id === guild._id;
|
|
}
|
|
|
|
beforeEach(async () => {
|
|
let {group, members, groupLeader} = await createAndPopulateGroup({
|
|
groupDetails: {
|
|
name: 'Test Guild',
|
|
type: 'guild',
|
|
},
|
|
members: 2,
|
|
});
|
|
|
|
guild = group;
|
|
user = groupLeader;
|
|
member = members[0];
|
|
addlMember = members[1];
|
|
|
|
task = await user.post(`/tasks/group/${guild._id}`, {
|
|
text: 'test todo',
|
|
type: 'todo',
|
|
requiresApproval: true,
|
|
});
|
|
|
|
await user.post(`/tasks/${task._id}/assign/${member._id}`);
|
|
await user.post(`/tasks/${task._id}/assign/${addlMember._id}`);
|
|
|
|
let memberTasks = await member.get('/tasks/user');
|
|
syncedTask = find(memberTasks, findAssignedTask);
|
|
|
|
let addlMemberTasks = await addlMember.get('/tasks/user');
|
|
addlSyncedTask = find(addlMemberTasks, findAssignedTask);
|
|
|
|
try {
|
|
await member.post(`/tasks/${syncedTask._id}/score/up`);
|
|
} catch (e) {
|
|
// eslint-disable-next-line no-empty
|
|
}
|
|
|
|
try {
|
|
await addlMember.post(`/tasks/${addlSyncedTask._id}/score/up`);
|
|
} catch (e) {
|
|
// eslint-disable-next-line no-empty
|
|
}
|
|
});
|
|
|
|
it('provides only user\'s own tasks when user is not the group leader', async () => {
|
|
let approvals = await member.get(`/approvals/group/${guild._id}`);
|
|
expect(approvals[0]._id).to.equal(syncedTask._id);
|
|
expect(approvals[1]).to.not.exist;
|
|
});
|
|
|
|
it('allows group leaders to get a list of tasks that need approval', async () => {
|
|
let approvals = await user.get(`/approvals/group/${guild._id}`);
|
|
expect(approvals[0]._id).to.equal(syncedTask._id);
|
|
expect(approvals[1]._id).to.equal(addlSyncedTask._id);
|
|
});
|
|
|
|
it('allows managers to get a list of tasks that need approval', async () => {
|
|
await user.post(`/groups/${guild._id}/add-manager`, {
|
|
managerId: member._id,
|
|
});
|
|
|
|
let approvals = await member.get(`/approvals/group/${guild._id}`);
|
|
expect(approvals[0]._id).to.equal(syncedTask._id);
|
|
expect(approvals[1]._id).to.equal(addlSyncedTask._id);
|
|
});
|
|
});
|