Remove localstorage and add notifications (#7588)

* move remaining files frm /common/script/public to website/public

* remove localstorage

* add back noscript template and put all javascript in the footer

* fixes client side tests

* remove double quotes where possible

* simplify jade code and add tests for buildManifest

* loading page with logo and spinner

* better loading screen in landscape mode

* icon on top of text logo

* wip: user.notifications

* notifications: simpler and working code

* finish implementing notifications

* correct loading screen css and re-inline images

* add tests for user notifications

* split User model in multiple files

* remove old comment about missing .catch()

* correctly setup hooks and methods for User model. Cleanup localstorage

* include UserNotificationsService in static page js and split loading-screen css in its own file

* add cron notification and misc fixes

* remove console.log

* fix tests

* fix multiple notifications

test/api/v3/unit/middlewares/response.js

@@ -32,6 +32,7 @@ describe('response middleware', () => {
     expect(res.json).to.be.calledWith({
       success: true,
       data: {field: 1},
+      notifications: [],
     });
   });
 
@@ -47,6 +48,7 @@ describe('response middleware', () => {
       success: true,
       data: {field: 1},
       message: 'hello',
+      notifications: [],
     });
   });
 
@@ -61,6 +63,45 @@ describe('response middleware', () => {
     expect(res.json).to.be.calledWith({
       success: false,
       data: {field: 1},
+      notifications: [],
+    });
+  });
+
+  it('returns userV if a user is authenticated req.query.userV is passed', () => {
+    responseMiddleware(req, res, next);
+    req.query.userV = 3;
+    res.respond(200, {field: 1});
+
+    expect(res.json).to.be.calledOnce;
+
+    expect(res.json).to.be.calledWith({
+      success: true,
+      data: {field: 1},
+      notifications: [],
+      userV: 0,
+    });
+  });
+
+  it('returns notifications if a user is authenticated', () => {
+    res.locals.user.notifications.push({type: 'NEW_CONTRIBUTOR_LEVEL'});
+    let notification = res.locals.user.notifications[0].toJSON();
+
+    responseMiddleware(req, res, next);
+    res.respond(200, {field: 1});
+
+    expect(res.json).to.be.calledOnce;
+
+    expect(res.json).to.be.calledWith({
+      success: true,
+      data: {field: 1},
+      notifications: [
+        {
+          type: notification.type,
+          id: notification.id,
+          createdAt: notification.createdAt,
+          data: {},
+        },
+      ],
     });
   });
 });