Remove localstorage and add notifications (#7588)

* move remaining files frm /common/script/public to website/public

* remove localstorage

* add back noscript template and put all javascript in the footer

* fixes client side tests

* remove double quotes where possible

* simplify jade code and add tests for buildManifest

* loading page with logo and spinner

* better loading screen in landscape mode

* icon on top of text logo

* wip: user.notifications

* notifications: simpler and working code

* finish implementing notifications

* correct loading screen css and re-inline images

* add tests for user notifications

* split User model in multiple files

* remove old comment about missing .catch()

* correctly setup hooks and methods for User model. Cleanup localstorage

* include UserNotificationsService in static page js and split loading-screen css in its own file

* add cron notification and misc fixes

* remove console.log

* fix tests

* fix multiple notifications

test/api/v3/integration/challenges/POST-challenges_challengeId_winner_winnerId.test.js

@@ -100,6 +100,8 @@ describe('POST /challenges/:challengeId/winner/:winnerId', () => {
       await sleep(0.5);
 
       await expect(winningUser.sync()).to.eventually.have.deep.property('achievements.challenges').to.include(challenge.name);
+      expect(winningUser.notifications.length).to.equal(1);
+      expect(winningUser.notifications[0].type).to.equal('WON_CHALLENGE');
     });
 
     it('gives winner gems as reward', async () => {

test/api/v3/integration/dataexport/GET-export_history.csv.test.js

@@ -17,16 +17,19 @@ describe('GET /export/history.csv', () => {
     ]);
 
     // score all the tasks twice
-    await Promise.all(tasks.map(task => {
-      return user.post(`/tasks/${task._id}/score/up`);
-    }));
-    await Promise.all(tasks.map(task => {
-      return user.post(`/tasks/${task._id}/score/up`);
-    }));
+    await user.post(`/tasks/${tasks[0]._id}/score/up`);
+    await user.post(`/tasks/${tasks[1]._id}/score/up`);
+    await user.post(`/tasks/${tasks[2]._id}/score/up`);
+    await user.post(`/tasks/${tasks[3]._id}/score/up`);
+
+    await user.post(`/tasks/${tasks[0]._id}/score/up`);
+    await user.post(`/tasks/${tasks[1]._id}/score/up`);
+    await user.post(`/tasks/${tasks[2]._id}/score/up`);
+    await user.post(`/tasks/${tasks[3]._id}/score/up`);
 
     // adding an history entry to daily 1 manually because cron didn't run yet
     await updateDocument('tasks', tasks[1], {
-      history: {value: 3.2, date: Number(new Date())},
+      history: [{value: 3.2, date: Number(new Date())}],
     });
 
     // get updated tasks

test/api/v3/integration/hall/PUT-hall_heores_heroId.test.js

@@ -68,6 +68,8 @@ describe('PUT /heroes/:heroId', () => {
     expect(hero.contributor.level).to.equal(1);
     expect(hero.purchased.ads).to.equal(true);
     expect(hero.auth.blocked).to.equal(true);
+    expect(hero.notifications.length).to.equal(1);
+    expect(hero.notifications[0].type).to.equal('NEW_CONTRIBUTOR_LEVEL');
   });
 
   it('updates contributor level', async () => {

test/api/v3/integration/user/POST-user_rebirth.test.js

@@ -46,6 +46,9 @@ describe('POST /user/rebirth', () => {
     let response = await user.post('/user/rebirth');
     await user.sync();
 
+    expect(user.notifications.length).to.equal(1);
+    expect(user.notifications[0].type).to.equal('REBIRTH_ACHIEVEMENT');
+
     let updatedDaily = await user.get(`/tasks/${daily._id}`);
     let updatedReward = await user.get(`/tasks/${reward._id}`);
 

test/api/v3/integration/user/PUT-user.test.js

@@ -36,6 +36,7 @@ describe('PUT /user', () => {
       backer: {'backer.tier': 10, 'backer.npc': 'Bilbo'},
       subscriptions: {'purchased.plan.extraMonths': 500, 'purchased.plan.consecutive.trinkets': 1000},
       'customization gem purchases': {'purchased.background.tavern': true, 'purchased.skin.bear': true},
+      notifications: [{type: 123}],
     };
 
     each(protectedOperations, (data, testName) => {