From f6bc929ddde02ad4c50f787fa22bc024dc930413 Mon Sep 17 00:00:00 2001
From: Blade Barringer <blade@crookedneighbor.com>
Date: Fri, 24 Jul 2015 11:38:52 -0500
Subject: [PATCH] Refacor how spec factory overrides works

---
 test/spec/specHelper.js | 26 +++++++++++---------------
 1 file changed, 11 insertions(+), 15 deletions(-)

diff --git a/test/spec/specHelper.js b/test/spec/specHelper.js
index 238fabb847..16ca672a82 100644
--- a/test/spec/specHelper.js
+++ b/test/spec/specHelper.js
@@ -72,9 +72,7 @@ var specHelper = {};
       challenge: { }
     };
 
-    for(var key in overrides) {
-      task[key] = overrides[key];
-    }
+    _setOverrides(task, overrides);
 
     return task;
   }
@@ -86,9 +84,7 @@ var specHelper = {};
     habit.up = true;
     habit.down = true;
 
-    for(var key in overrides) {
-      habit[key] = overrides[key];
-    }
+    _setOverrides(habit, overrides);
 
     return habit;
   }
@@ -113,9 +109,7 @@ var specHelper = {};
     daily.checklist = [];
     daily.streak = 0;
 
-    for(var key in overrides) {
-      daily[key] = overrides[key];
-    }
+    _setOverrides(daily, overrides);
 
     return daily;
   }
@@ -127,9 +121,7 @@ var specHelper = {};
     todo.collapseChecklist = false;
     todo.checklist = [];
 
-    for(var key in overrides) {
-      todo[key] = overrides[key];
-    }
+    _setOverrides(todo, overrides);
 
     return todo;
   }
@@ -138,10 +130,14 @@ var specHelper = {};
     var reward = newTask();
     reward.type = 'reward';
 
-    for(var key in overrides) {
-      reward[key] = overrides[key];
-    }
+    _setOverrides(reward, overrides);
 
     return reward;
   }
+
+  function _setOverrides(factory, overrides) {
+    for(var key in overrides) {
+      factory[key] = overrides[key];
+    }
+  }
 })();