krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-16 22:27:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

deemphasise the warning that spritesheets might be too large for mobile safari - ref https://github.com/HabitRPG/habitrpg/pull/6683#issuecomment-185462180

Browse Source
This commit is contained in:
Alys
2016-02-18 18:52:09 +10:00
parent 3563244cdc
commit f631712a45
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tasks/gulp-sprites.js
View File

@@ -41,13 +41,12 @@ gulp.task('sprites:checkCompiledDimensions', ['sprites:main', 'sprites:largeSpri
if (spriteSize > MAX_SPRITESHEET_SIZE) { if (spriteSize > MAX_SPRITESHEET_SIZE) {
numberOfSheetsThatAreTooBig++; numberOfSheetsThatAreTooBig++;
let name = basename(img, '.png'); let name = basename(img, '.png');
console.error(`WARNING: ${name} is too big - ${spriteSize} > ${MAX_SPRITESHEET_SIZE}`); console.error(`WARNING: ${name} might be too big - ${spriteSize} > ${MAX_SPRITESHEET_SIZE}`);
} }
}); });
if (numberOfSheetsThatAreTooBig > 0) { if (numberOfSheetsThatAreTooBig > 0) {
console.error(`${numberOfSheetsThatAreTooBig} sheets are too big :(`); console.error(`${numberOfSheetsThatAreTooBig} sheets might too big for mobile Safari to be able to handle them, but there is a margin of error in these calculations so it is probably okay. Mention this to an admin so they can test a staging site on mobile Safari after your PR is merged.`); // https://github.com/HabitRPG/habitrpg/pull/6683#issuecomment-185462180
console.error('Mobile Safari may be unhappy with you');
} else { } else {
console.log('All images are within the correct dimensions'); console.log('All images are within the correct dimensions');
} }