krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 15:48:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

don’t use body with delete

Browse Source
This commit is contained in:
Phillip Thelen
2025-05-29 19:17:54 +02:00
parent 0a6f138de8
commit f33e256b57
2 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
website/client/src/store/actions/hall.js
View File

@@ -40,10 +40,7 @@ export async function getHeroGroupPlans (store, payload) {
} }
export async function deleteHero (store, payload) { export async function deleteHero (store, payload) {
const url = `/api/v4/members/${payload.uuid}`; const url = `/api/v4/members/${payload.uuid}?deleteAccount=${payload.deleteAccount}&deleteAmplitude=${payload.deleteAmplitude}`;
const response = await axios.delete(url, { const response = await axios.delete(url);
deleteAccount: payload.deleteHabiticaAccount,
deleteAmplitude: payload.deleteAmplitudeData,
});
return response.data.data; return response.data.data;
} }

8
website/server/controllers/api-v4/members.js
View File

@@ -44,15 +44,15 @@ api.deleteMember = {
url: '/members/:memberId', url: '/members/:memberId',
async handler (req, res) { async handler (req, res) {
req.checkParams('memberId', res.t('memberIdRequired')).notEmpty().isUUID(); req.checkParams('memberId', res.t('memberIdRequired')).notEmpty().isUUID();
req.checkBody('deleteAccount').optional().isIn(['true', 'false']); req.checkQuery('deleteAccount').optional().isIn(['true', 'false']);
req.checkBody('deleteAmplitude').optional().isIn(['true', 'false']); req.checkQuery('deleteAmplitude').optional().isIn(['true', 'false']);
const validationErrors = req.validationErrors(); const validationErrors = req.validationErrors();
if (validationErrors) throw validationErrors; if (validationErrors) throw validationErrors;
sendJob('delete-user', { sendJob('delete-user', {
data: { data: {
userId: req.params.memberId, userId: req.params.memberId,
deleteAccount: req.body.deleteAccount === 'true', deleteAccount: req.query.deleteAccount === 'true',
deleteAmplitude: req.body.deleteAmplitude === 'true', deleteAmplitude: req.query.deleteAmplitude === 'true',
}, },
}); });
res.respond(200, {}); res.respond(200, {});