mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-19 15:48:04 +01:00
Fixes task left in odd setting when cancelling editing with ESC / Escape Key; add click outside to close modal #8308 #8321 (#8382)
* Remove backdrop property from open modal call to allow click-outside to close, call cancelTaskEdit function on dismissal of edit modal via ESC or click-outside * Remove commented out code, change catch function to normal (non-arrow) * Modify task services test mock openModal function, to handle new use of subsequent promise resolution functionality * Tidy old edit controls away
This commit is contained in:
committed by
Keith Holliday
parent
2b80931202
commit
ef4aeb29ab
@@ -17,7 +17,14 @@ describe('Tasks Service', function() {
|
||||
tasks = Tasks;
|
||||
});
|
||||
|
||||
rootScope.openModal = function () {};
|
||||
rootScope.openModal = function() {
|
||||
return {
|
||||
result: {
|
||||
then: function() {},
|
||||
catch: function() {},
|
||||
},
|
||||
};
|
||||
};
|
||||
});
|
||||
|
||||
it('calls get user tasks endpoint', function() {
|
||||
|
||||
Reference in New Issue
Block a user