krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 15:17:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix tests

Browse Source
This commit is contained in:
Matteo Pagliazzi
2015-09-04 18:21:06 +02:00
parent 0f1d514460
commit ec45a87dce
2 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
test/api/groups.coffee
View File

@@ -270,7 +270,8 @@ describe "Guilds", ->
userToBecomeLeader = undefined userToBecomeLeader = undefined
request.post(baseURL + "/groups").send( request.post(baseURL + "/groups").send(
name: "TestGuildToEmptyAndAssignLeader" name: "TestGuildToEmptyAndAssignLeader"
type: "guild" type: "guild",
privacy: "public"
).end (res) -> ).end (res) ->
guildToEmptyAndAssignLeader = res.body guildToEmptyAndAssignLeader = res.body
#Add members to guild #Add members to guild

4
website/src/models/group.js
View File

@@ -424,6 +424,9 @@ GroupSchema.methods.leave = function(user, keep, mainCb){
var seniorMember = _.find(group.members, function (m) {return m != user._id}); var seniorMember = _.find(group.members, function (m) {return m != user._id});
// If the leader is leaving (or if the leader previously left, and this wasn't accounted for) // If the leader is leaving (or if the leader previously left, and this wasn't accounted for)
var leader = group.leader; var leader = group.leader;
// could not exist in case of public guild with 1 member who is leaving
if(seniorMember){
if (leader == user._id || !~group.members.indexOf(leader)) { if (leader == user._id || !~group.members.indexOf(leader)) {
update['$set'] = update['$set'] || {}; update['$set'] = update['$set'] || {};
update['$set'].leader = seniorMember; update['$set'].leader = seniorMember;
@@ -435,6 +438,7 @@ GroupSchema.methods.leave = function(user, keep, mainCb){
update['$set'] = update['$set'] || {}; update['$set'] = update['$set'] || {};
update['$set']['quest.leader'] = seniorMember; update['$set']['quest.leader'] = seniorMember;
} }
}
update['$inc'] = {memberCount: -1}; update['$inc'] = {memberCount: -1};
Group.update({_id:group._id}, update, cb); Group.update({_id:group._id}, update, cb);