krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-17 22:57:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

PR to fix: Disallow line breaks in display names (#12380)

Browse Source 
* Update settings.json

* Update index.js

* Update validation.js

* Update validation.js

* Update validation.js

Removes the second check

* Update tests and validation

Added tests, and updated validation
This commit is contained in:
Amber
2020-07-18 15:41:19 -05:00
committed by GitHub
parent e550ca1531
commit ead0b6c56f
5 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
website/server/libs/user/index.js
View File

@@ -6,7 +6,7 @@ import {
NotAuthorized,
} from '../errors';
import { model as User, schema as UserSchema } from '../../models/user';
import { nameContainsSlur } from './validation';
import { nameContainsSlur, nameContainsNewline } from './validation';
export async function get (req, res, { isV3 = false }) {
const { user } = res.locals;
@@ -112,6 +112,7 @@ export async function update (req, res, { isV3 = false }) {
if (newName === null) throw new BadRequest(res.t('invalidReqParams'));
if (newName.length > 30) throw new BadRequest(res.t('displaynameIssueLength'));
if (nameContainsSlur(newName)) throw new BadRequest(res.t('displaynameIssueSlur'));
if (nameContainsNewline(newName)) throw new BadRequest(res.t('displaynameIssueNewline'));
}
_.each(req.body, (val, key) => {