krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 07:07:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

PR to fix: Disallow line breaks in display names (#12380)

Browse Source 
* Update settings.json

* Update index.js

* Update validation.js

* Update validation.js

* Update validation.js

Removes the second check

* Update tests and validation

Added tests, and updated validation
This commit is contained in:
Amber
2020-07-18 15:41:19 -05:00
committed by GitHub
parent e550ca1531
commit ead0b6c56f
5 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/api/v4/user/auth/POST-user_verify_display_name.test.js
View File

@@ -53,5 +53,11 @@ describe('POST /user/auth/verify-display-name', async () => {
displayName: 'this is a very long display name over 30 characters',
})).to.eventually.eql({ isUsable: false, issues: [t('displaynameIssueLength')] });
});
it('errors if display name contains a newline', async () => {
await expect(user.post(ENDPOINT, {
displayName: 'namecontainsnewline\n',
})).to.eventually.eql({ isUsable: false, issues: [t('displaynameIssueNewline')] });
});
});
});