krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 15:48:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(analytics): Add missing ID update

Browse Source 
Also make the order of partyID and partySize consistent across updateUser calls.
This commit is contained in:
Sabe Jones
2015-07-27 14:34:31 -05:00
parent 9d7a2a1c24
commit e9ed561907
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
website/public/js/controllers/groupsCtrl.js
View File

@@ -267,7 +267,7 @@ habitrpg.controller("GroupsCtrl", ['$scope', '$rootScope', 'Shared', 'Groups', '
$scope.message.content = ''; $scope.message.content = '';
$scope._sending = false; $scope._sending = false;
if (group.type == 'party') { if (group.type == 'party') {
Analytics.updateUser({'partySize':group.memberCount}); Analytics.updateUser({'partyID':group.id,'partySize':group.memberCount});
} }
if (group.privacy == 'public'){ if (group.privacy == 'public'){
Analytics.track({'hitType':'event','eventCategory':'behavior','eventAction':'group chat','groupType':group.type,'privacy':group.privacy,'groupName':group.name,'message':message}); Analytics.track({'hitType':'event','eventCategory':'behavior','eventAction':'group chat','groupType':group.type,'privacy':group.privacy,'groupName':group.name,'message':message});

8
website/public/js/services/groupServices.js
View File

@@ -64,25 +64,25 @@ function($rootScope, ApiUrl, $resource, $q, $http, User, Challenges, Analytics,
}, },
questAccept: function(party){ questAccept: function(party){
Analytics.updateUser({'partySize':party.memberCount,'partyID':party.id}); Analytics.updateUser({'partyID':party.id,'partySize':party.memberCount});
party.$questAccept() party.$questAccept()
.then(syncUser, logError); .then(syncUser, logError);
}, },
questReject: function(party){ questReject: function(party){
Analytics.updateUser({'partySize':party.memberCount,'partyID':party.id}); Analytics.updateUser({'partyID':party.id,'partySize':party.memberCount});
party.$questReject() party.$questReject()
.then(syncUser, logError); .then(syncUser, logError);
}, },
questCancel: function(party){ questCancel: function(party){
Analytics.updateUser({'partySize':party.memberCount,'partyID':party.id}); Analytics.updateUser({'partyID':party.id,'partySize':party.memberCount});
party.$questCancel() party.$questCancel()
.then(syncUser, logError); .then(syncUser, logError);
}, },
questAbort: function(party){ questAbort: function(party){
Analytics.updateUser({'partySize':party.memberCount,'partyID':party.id}); Analytics.updateUser({'partyID':party.id,'partySize':party.memberCount});
party.$questAbort() party.$questAbort()
.then(syncUser, logError); .then(syncUser, logError);
}, },

2
website/public/js/services/questServices.js
View File

@@ -87,7 +87,7 @@
function questInit(){ function questInit(){
Analytics.track({'hitType':'event','eventCategory':'behavior','eventAction':'quest','owner':true,'response':'accept','questName':$rootScope.selectedQuest.key}); Analytics.track({'hitType':'event','eventCategory':'behavior','eventAction':'quest','owner':true,'response':'accept','questName':$rootScope.selectedQuest.key});
Analytics.updateUser({'partySize':party.memberCount,'partyID':party.id}); Analytics.updateUser({'partyID':party.id,'partySize':party.memberCount});
party.$questAccept({key:$rootScope.selectedQuest.key}, function(){ party.$questAccept({key:$rootScope.selectedQuest.key}, function(){
party.$get(); party.$get();
$rootScope.$state.go('options.social.party'); $rootScope.$state.go('options.social.party');