krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-14 21:27:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(tests): use baseline quest with fewer update calls

Browse Source
This commit is contained in:
Sabe Jones
2019-06-04 16:09:01 -05:00
parent 7094e75dd8
commit e9a5e084fc
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/api/unit/models/group.test.js
View File

@@ -1734,7 +1734,7 @@ describe('Group Model', () => {
let quest; let quest;
beforeEach(() => { beforeEach(() => {
quest = questScrolls.whale; quest = questScrolls.armadillo;
party.quest.key = quest.key; party.quest.key = quest.key;
party.quest.active = false; party.quest.active = false;
party.quest.leader = questLeader._id; party.quest.leader = questLeader._id;
@@ -2048,13 +2048,13 @@ describe('Group Model', () => {
questLeader = await User.findById(questLeader._id); questLeader = await User.findById(questLeader._id);
participatingMember = await User.findById(participatingMember._id); participatingMember = await User.findById(participatingMember._id);
expect(questLeader.party.quest.completed).to.eql('whale'); expect(questLeader.party.quest.completed).to.eql('armadillo');
expect(questLeader.party.quest.progress.up).to.eql(10); expect(questLeader.party.quest.progress.up).to.eql(10);
expect(questLeader.party.quest.progress.down).to.eql(8); expect(questLeader.party.quest.progress.down).to.eql(8);
expect(questLeader.party.quest.progress.collectedItems).to.eql(5); expect(questLeader.party.quest.progress.collectedItems).to.eql(5);
expect(questLeader.party.quest.RSVPNeeded).to.eql(false); expect(questLeader.party.quest.RSVPNeeded).to.eql(false);
expect(participatingMember.party.quest.completed).to.eql('whale'); expect(participatingMember.party.quest.completed).to.eql('armadillo');
expect(participatingMember.party.quest.progress.up).to.eql(10); expect(participatingMember.party.quest.progress.up).to.eql(10);
expect(participatingMember.party.quest.progress.down).to.eql(8); expect(participatingMember.party.quest.progress.down).to.eql(8);
expect(participatingMember.party.quest.progress.collectedItems).to.eql(5); expect(participatingMember.party.quest.progress.collectedItems).to.eql(5);

2
website/server/models/group.js
View File

@@ -875,7 +875,7 @@ schema.methods.finishQuest = async function finishQuest (quest) {
}); });
}); });
_.forEach(questSeriesAchievements, async (questList, achievement) => { _.forEach(questSeriesAchievements, (questList, achievement) => {
if (questList.includes(questK)) { if (questList.includes(questK)) {
let questAchievementQuery = {}; let questAchievementQuery = {};
questAchievementQuery[`achievements.${achievement}`] = {$ne: true}; questAchievementQuery[`achievements.${achievement}`] = {$ne: true};