krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 07:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #14438: a11y: add semantic roles to habit and todo controls (#14467)

Browse Source 
* a11y: add aria roles to habit control

* a11y: add role to todo checkboxes

* a11y: add aria-labels to score buttons
Helps with screen readers

* add i18n to aria-labels
This commit is contained in:
Ash
2023-06-19 23:00:16 +02:00
committed by GitHub
parent c3f0abadd7
commit e72a25ad02
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
website/client/src/components/tasks/task.vue
View File

@@ -32,6 +32,9 @@
'task-not-scoreable': showTaskLockIcon, 'task-not-scoreable': showTaskLockIcon,
}, controlClass.up.inner]" }, controlClass.up.inner]"
tabindex="0" tabindex="0"
role="button"
:aria-label="$t('scoreUp')"
:aria-disabled="showTaskLockIcon || (!task.up && !showTaskLockIcon)"
@click="score('up')" @click="score('up')"
@keypress.enter="score('up')" @keypress.enter="score('up')"
> >
@@ -63,6 +66,7 @@
controlClass.inner, controlClass.inner,
]" ]"
tabindex="0" tabindex="0"
role="checkbox"
@click="score(showCheckIcon ? 'down' : 'up' )" @click="score(showCheckIcon ? 'down' : 'up' )"
@keypress.enter="score(showCheckIcon ? 'down' : 'up' )" @keypress.enter="score(showCheckIcon ? 'down' : 'up' )"
> >
@@ -359,6 +363,9 @@
'task-not-scoreable': showTaskLockIcon, 'task-not-scoreable': showTaskLockIcon,
}, controlClass.down.inner]" }, controlClass.down.inner]"
tabindex="0" tabindex="0"
role="button"
:aria-label="$t('scoreDown')"
:aria-disabled="showTaskLockIcon || (!task.down && !showTaskLockIcon)"
@click="score('down')" @click="score('down')"
@keypress.enter="score('down')" @keypress.enter="score('down')"
> >

4
website/common/locales/en/tasks.json
View File

@@ -133,5 +133,7 @@
"addTags": "Add tags...", "addTags": "Add tags...",
"enterTag": "Enter a tag", "enterTag": "Enter a tag",
"pressEnterToAddTag": "Press Enter to add tag: '<%= tagName %>'", "pressEnterToAddTag": "Press Enter to add tag: '<%= tagName %>'",
"taskSummary": "<%= type %> Summary" "taskSummary": "<%= type %> Summary",
"scoreUp": "Score up",
"scoreDown": "Score down"
} }