From e6c3d00665b16b760619f283662371a0245f15f8 Mon Sep 17 00:00:00 2001 From: Sabe Jones Date: Tue, 5 Mar 2019 14:55:45 -0600 Subject: [PATCH] fix(emails): send split-test mailings for social reg accounts --- website/server/libs/auth/social.js | 8 +++++++- website/server/models/user/hooks.js | 10 ++++++---- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/website/server/libs/auth/social.js b/website/server/libs/auth/social.js index 882554818f..8ac649ab71 100644 --- a/website/server/libs/auth/social.js +++ b/website/server/libs/auth/social.js @@ -88,7 +88,13 @@ async function loginSocial (req, res) { .remove({email: savedUser.auth[network].emails[0].value.toLowerCase()}) .exec() .then(() => { - if (!existingUser) sendTxnEmail(savedUser, 'welcome'); + if (!existingUser) { + if (savedUser._ABtests && savedUser._ABtests.welcomeEmailSplit) { + sendTxnEmail(savedUser, savedUser._ABtests.welcomeEmailSplit); + } else { + sendTxnEmail(savedUser, 'welcome'); + } + } }); // eslint-disable-line max-nested-callbacks } diff --git a/website/server/models/user/hooks.js b/website/server/models/user/hooks.js index 90616326b2..dad044441b 100644 --- a/website/server/models/user/hooks.js +++ b/website/server/models/user/hooks.js @@ -129,14 +129,16 @@ function _setUpNewUser (user) { user.preferences.background = 'violet'; const testGroup = Math.random(); - if (testGroup < 0.25) { + if (testGroup < 0.2) { user._ABtests.welcomeEmailSplit = 'welcome-v2'; - } else if (testGroup < 0.5) { + } else if (testGroup < 0.4) { user._ABtests.welcomeEmailSplit = 'welcome-v2b'; - } else if (testGroup < 0.75) { + } else if (testGroup < 0.6) { user._ABtests.welcomeEmailSplit = 'welcome-v2c'; - } else { + } else if (testGroup < 0.8) { user._ABtests.welcomeEmailSplit = 'welcome-v2d'; + } else { + user._ABtests.welcomeEmailSplit = 'welcome'; } if (user.registeredThrough === 'habitica-web') {