krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 07:07:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

add tests for tags ops on tasks

Browse Source
This commit is contained in:
Matteo Pagliazzi
2015-12-14 22:44:50 +01:00
parent da154d3ea3
commit e547eb2dde
4 changed files with 127 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
website/src/controllers/api-v3/tasks.js
View File

@@ -518,7 +518,7 @@ api.removeChecklistItem = {
*/
api.addTagToTask = {
method: 'POST',
url: '/tasks/:taskId/tags',
url: '/tasks/:taskId/tags/:tagId',
middlewares: [authWithHeaders()],
handler (req, res, next) {
let user = res.locals.user;
@@ -538,7 +538,7 @@ api.addTagToTask = {
if (!task) throw new NotFound(res.t('taskNotFound'));
let tagId = req.params.tagId;
let alreadyTagged = task.tags.indexOf(tagId) === -1;
let alreadyTagged = task.tags.indexOf(tagId) !== -1;
if (alreadyTagged) throw new BadRequest(res.t('alreadyTagged'));
task.tags.push(tagId);
@@ -580,7 +580,7 @@ api.removeTagFromTask = {
.then((task) => {
if (!task) throw new NotFound(res.t('taskNotFound'));
let tagI = _.findIndex(task.tags, {_id: req.params.tagId});
let tagI = task.tags.indexOf(req.params.tagId);
if (tagI === -1) throw new NotFound(res.t('tagNotFound'));
task.tags.splice(tagI, 1);