Cleaned up code style and abstracted variables that are reused.

This commit is contained in:
Keith Holliday
2016-01-12 13:08:13 -06:00
parent da02f8ca0f
commit e4fd37f3d0

View File

@@ -3,21 +3,22 @@ import {
translate as t, translate as t,
} from '../../../../helpers/api-integration.helper'; } from '../../../../helpers/api-integration.helper';
describe('Put /group', () => { describe('PUT /group', () => {
let groupLeader; let groupLeader;
let groupName = 'Test Public Guild'; let groupName = 'Test Public Guild';
let groupType = 'guild'; let groupType = 'guild';
let groupToUpdate;
let groupUpdatedName = 'Test Public Guild Updated';
beforeEach(async () => { beforeEach(async () => {
groupLeader = await generateUser({balance: 1}); groupLeader = await generateUser({balance: 1});
}); groupToUpdate = await groupLeader.post('/groups', {
it('returns an error when a non group leader tries to update', async () => {
let groupToUpdate = await groupLeader.post('/groups', {
name: groupName, name: groupName,
type: groupType, type: groupType,
}); });
let groupUpdatedName = 'Test Public Guild Updated'; });
it('returns an error when a non group leader tries to update', async () => {
let memberToAttemptUpdate = await generateUser(); let memberToAttemptUpdate = await generateUser();
await groupLeader.post(`/groups/${groupToUpdate._id}/invite`, { await groupLeader.post(`/groups/${groupToUpdate._id}/invite`, {
@@ -27,8 +28,7 @@ describe('Put /group', () => {
await expect(memberToAttemptUpdate.put(`/groups/${groupToUpdate._id}`, { await expect(memberToAttemptUpdate.put(`/groups/${groupToUpdate._id}`, {
name: groupUpdatedName, name: groupUpdatedName,
})) })).to.eventually.be.rejected.and.eql({
.to.eventually.be.rejected.and.eql({
code: 401, code: 401,
error: 'NotAuthorized', error: 'NotAuthorized',
message: t('messageGroupOnlyLeaderCanUpdate'), message: t('messageGroupOnlyLeaderCanUpdate'),
@@ -36,12 +36,7 @@ describe('Put /group', () => {
}); });
it('updates a group', async () => { it('updates a group', async () => {
let groupUpdatedName = 'Test Public Guild Updated'; let updatedGroup = await groupLeader.put(`/groups/${groupToUpdate._id}`, {
let group = await groupLeader.post('/groups', {
name: groupName,
type: groupType,
});
let updatedGroup = await groupLeader.put(`/groups/${group._id}`, {
name: groupUpdatedName, name: groupUpdatedName,
}); });