From e0dae01dda5e6a6e3f927491909cfe8c3a8ba9a5 Mon Sep 17 00:00:00 2001 From: Tyler Renelle Date: Mon, 30 Mar 2015 16:43:26 -0600 Subject: [PATCH] fix(analytics): remove a/b on play button, fixes #4947 --- website/public/js/controllers/footerCtrl.js | 2 +- website/views/static/front.jade | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/website/public/js/controllers/footerCtrl.js b/website/public/js/controllers/footerCtrl.js index 8d15d4690c..864740c7b9 100644 --- a/website/public/js/controllers/footerCtrl.js +++ b/website/public/js/controllers/footerCtrl.js @@ -29,7 +29,7 @@ function($scope, $rootScope, User, $http, Notification, ApiUrl) { if (window.env.NODE_ENV === 'production') { // Get experiments API $.getScript('//www.google-analytics.com/cx/api.js?experiment=OPMHlSzSTj2gVYwUS72wlQ', function(){ - $rootScope.chosenVariation = cxApi.chooseVariation(); + $rootScope.variant = cxApi.chooseVariation(); $rootScope.$apply(); (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){ diff --git a/website/views/static/front.jade b/website/views/static/front.jade index 71d75fb3f6..bbd25b9603 100644 --- a/website/views/static/front.jade +++ b/website/views/static/front.jade @@ -20,8 +20,7 @@ block content //while acting similarly to a logo h1#tagline=env.t('tagline') p.lead - button.btn.btn-primary.btn-lg#frontpage-play-button(ng-click='playButtonClick()') - | {{chosenVariation==1 ? "Play Now - It's Free!" : chosenVariation==2 ? "Start" : "#{env.t('playButton')}"}} + button.btn.btn-primary.btn-lg#frontpage-play-button(ng-click='playButtonClick()')=env.t('playButton') hr img(src='/marketing/devices.png') //we'd want the tagline centered, for sure, and a bit more pop, but without using jumbotron