Use username in challenge member dropdown (#11478)

* update challenge member dropdown and api to display and search by username rather than display name

* remove accidental whitespace

* fix api test

test/api/v3/integration/challenges/GET-challenges_challengeId_members.test.js

@@ -206,16 +206,16 @@ describe('GET /challenges/:challengeId/members', () => {
     for (let i = 0; i < 3; i += 1) {
       usersToGenerate.push(generateUser({
         challenges: [challenge._id],
-        'profile.name': `${i}profilename`,
+        'auth.local.username': `${i}username`,
       }));
     }
     const generatedUsers = await Promise.all(usersToGenerate);
-    const profileNames = generatedUsers.map(generatedUser => generatedUser.profile.name);
+    const usernames = generatedUsers.map(generatedUser => generatedUser.auth.local.username);
 
-    const firstProfileName = profileNames[0];
-    const nameToSearch = firstProfileName.substring(0, 4);
+    const firstUsername = usernames[0];
+    const nameToSearch = firstUsername.substring(0, 4);
 
     const response = await user.get(`/challenges/${challenge._id}/members?search=${nameToSearch}`);
-    expect(response[0].profile.name).to.eql(firstProfileName);
+    expect(response[0].auth.local.username).to.eql(firstUsername);
   });
 });

website/client/src/components/members/memberSearchDropdown.vue

@@ -19,7 +19,7 @@
       :key="member._id"
       @click="selectMember(member)"
     >
-      {{ member.profile.name }}
+      @{{ member.auth.local.username }}
     </b-dropdown-item>
   </b-dropdown>
 </template>

website/server/controllers/api-v3/members.js

@@ -330,7 +330,7 @@ function _getMembersForItem (type) {
       }
 
       if (req.query.search) {
-        query['profile.name'] = { $regex: req.query.search };
+        query['auth.local.username'] = { $regex: req.query.search };
       }
     } else if (type === 'group-members') {
       if (group.type === 'guild') {