krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 07:07:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixing #5706 filtering system messages results in errors.

Browse Source
This commit is contained in:
Joy Clark
2015-04-27 23:01:15 +02:00
parent df91592438
commit df1c349ea7
2 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
test/spec/groupCtrlSpec.js
View File

@@ -101,7 +101,7 @@ describe("Autocomplete controller", function() {
scope.clearUserlist();
expect(scope.response).to.be.empty; // to.be.empty() doesn't work for some reason. This is the same thing
expect(scope.usernames).to.be.empty;
})
});
it('the function is called upon initialization of the controller', function() {
scope.response.push("blah");
@@ -110,33 +110,38 @@ describe("Autocomplete controller", function() {
expect(scope.response).to.be.empty; // to.be.empty() doesn't work for some reason. This is the same thing
expect(scope.usernames).to.be.empty;
})
});
})
describe("filterUser", function() {
it('filters with undefined query (not loaded yet) and returns false (so it will not be rendered)', function() {
expect(scope.filterUser({user: "boo"})).to.be.eq(false);
})
});
it('filters with null query (no typing yet) and returns false (so it will not be rendered)', function() {
scope.query = null
expect(scope.filterUser({user: "boo"})).to.be.eq(false);
})
});
it('filters with empty prefix and returns true', function() {
scope.query = {text: ""}
expect(scope.filterUser({user: "prefix"})).to.be.eq(true);
})
});
it('filters with prefix element and returns true', function() {
scope.query = {text: "pre"}
expect(scope.filterUser({user: "prefix"})).to.be.eq(true);
})
});
it('filters with nonprefix element and returns false', function() {
scope.query = {text: "noprefix"}
expect(scope.filterUser({user: "prefix"})).to.be.eq(false);
})
});
it('filters out system messages (messages without username)', function() {
scope.query = {text: "myquery"}
expect(scope.filterUser({uuid: "system"})).to.be.eq(false);
});
});
describe("addNewUser", function() {
@@ -159,6 +164,6 @@ describe("Autocomplete controller", function() {
scope.$digest(); // trigger watch
scope.group.chat.push({msg: "new chat", user: "boo"});
expect(chatChanged.callCount).to.be.eq(1);
})
});
});
});