krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-14 21:27:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(teams): don't complain about move route when not moving

Browse Source
This commit is contained in:
SabreCat
2022-06-29 09:06:08 -05:00
parent a3f61306d3
commit ddd5f20609
2 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
website/server/controllers/api-v3/tasks.js
View File

@@ -815,7 +815,17 @@ api.moveTask = {
const group = await getGroupFromTaskAndUser(task, user);
const challenge = await getChallengeFromTask(task);
verifyTaskModification(task, user, group, challenge, res);
if (task.group.id && !task.userId) {
if (!group || user.guilds.concat(user.party._id).indexOf(group._id) === -1) {
throw new NotFound(res.t('groupNotFound'));
}
if (task.group.assignedUsers.length !== 0
&& task.group.assignedUsers.indexOf(user._id) === -1) {
throw new BadRequest('Use /group/:groupId/tasks/:taskId/move/to/:position route');
}
} else {
verifyTaskModification(task, user, group, challenge, res);
}
if (task.type === 'todo' && task.completed) throw new BadRequest(res.t('cantMoveCompletedTodo'));