From dc8598ae818ccd85aa81b3273a1b973a8d26b49f Mon Sep 17 00:00:00 2001
From: Matteo Pagliazzi <matteopagliazzi@gmail.com>
Date: Fri, 3 Mar 2017 19:38:17 +0100
Subject: [PATCH] Client: Guilds Discovery (#8529)

* wip: add guilds discovery page

* add public guilds page

* fix and add tests for the groups utilities mixin
---
 .../unit/specs/mixins/groupsUtilities.spec.js | 61 +++++++++++++++++++
 website/client/assets/less/forms.less         |  7 +++
 website/client/assets/less/index.less         |  1 +
 .../assets/less/semantic-ui/semantic.less     |  2 +-
 .../client/components/inventory/stable.vue    | 25 +++-----
 .../social/guilds/discovery/index.vue         | 47 ++++++++++++++
 .../guilds/discovery/publicGuildItem.vue      | 24 ++++++++
 website/client/components/social/index.vue    |  4 +-
 website/client/mixins/groupsUtilities.js      | 25 ++++++++
 website/client/router.js                      | 13 +++-
 website/client/store/actions/guilds.js        |  6 ++
 website/client/store/actions/index.js         | 11 ++--
 website/client/store/getters/index.js         |  4 +-
 website/client/store/helpers/internals.js     |  8 +--
 website/client/store/state.js                 |  1 +
 15 files changed, 209 insertions(+), 30 deletions(-)
 create mode 100644 test/client/unit/specs/mixins/groupsUtilities.spec.js
 create mode 100644 website/client/assets/less/forms.less
 create mode 100644 website/client/components/social/guilds/discovery/index.vue
 create mode 100644 website/client/components/social/guilds/discovery/publicGuildItem.vue
 create mode 100644 website/client/mixins/groupsUtilities.js
 create mode 100644 website/client/store/actions/guilds.js

diff --git a/test/client/unit/specs/mixins/groupsUtilities.spec.js b/test/client/unit/specs/mixins/groupsUtilities.spec.js
new file mode 100644
index 0000000000..ada7f52657
--- /dev/null
+++ b/test/client/unit/specs/mixins/groupsUtilities.spec.js
@@ -0,0 +1,61 @@
+import groupsUtilities from 'client/mixins/groupsUtilities';
+import { TAVERN_ID } from 'common/script/constants';
+import Vue from 'vue';
+
+describe('Groups Utilities Mixin', () => {
+  let instance, user;
+
+  before(() => {
+    instance = new Vue({
+      mixins: [groupsUtilities],
+    });
+
+    user = {
+      _id: '123',
+      party: {
+        _id: '456',
+      },
+      guilds: ['789'],
+    };
+  });
+
+  describe('isMemberOfGroup', () => {
+    it('registers as a method', () => {
+      expect(instance.isMemberOfGroup).to.be.a.function;
+    });
+
+    it('returns true when the group is the Tavern', () => {
+      expect(instance.isMemberOfGroup(user, {
+        _id: TAVERN_ID,
+      })).to.equal(true);
+    });
+
+    it('returns true when the group is the user\'s party', () => {
+      expect(instance.isMemberOfGroup(user, {
+        type: 'party',
+        _id: user.party._id,
+      })).to.equal(true);
+    });
+
+    it('returns false when the group is not the user\'s party', () => {
+      expect(instance.isMemberOfGroup(user, {
+        type: 'party',
+        _id: 'not my party',
+      })).to.equal(false);
+    });
+
+    it('returns true when the group is not a guild of which the user is a member', () => {
+      expect(instance.isMemberOfGroup(user, {
+        type: 'guild',
+        _id: user.guilds[0],
+      })).to.equal(true);
+    });
+
+    it('returns false when the group is not a guild of which the user is a member', () => {
+      expect(instance.isMemberOfGroup(user, {
+        type: 'guild',
+        _id: 'not my guild',
+      })).to.equal(false);
+    });
+  });
+});
\ No newline at end of file
diff --git a/website/client/assets/less/forms.less b/website/client/assets/less/forms.less
new file mode 100644
index 0000000000..bd256066ea
--- /dev/null
+++ b/website/client/assets/less/forms.less
@@ -0,0 +1,7 @@
+.label-primary {
+  font-weight: bold;
+}
+
+.nested-field {
+  padding-left: 1.5rem;
+}
\ No newline at end of file
diff --git a/website/client/assets/less/index.less b/website/client/assets/less/index.less
index 1397606124..da8c3da799 100644
--- a/website/client/assets/less/index.less
+++ b/website/client/assets/less/index.less
@@ -1,5 +1,6 @@
 // CSS that doesn't belong to any specific Vue compoennt
 @import './utilities';
+@import './forms';
 @import './loading-screen';
 
 body {
diff --git a/website/client/assets/less/semantic-ui/semantic.less b/website/client/assets/less/semantic-ui/semantic.less
index d078ed3a2b..be2f24744d 100644
--- a/website/client/assets/less/semantic-ui/semantic.less
+++ b/website/client/assets/less/semantic-ui/semantic.less
@@ -30,7 +30,7 @@
 // & { @import "~semantic-ui-less/definitions/elements/loader"; }
 // & { @import "~semantic-ui-less/definitions/elements/rail"; }
 // & { @import "~semantic-ui-less/definitions/elements/reveal"; }
-// & { @import "~semantic-ui-less/definitions/elements/segment"; }
+& { @import "~semantic-ui-less/definitions/elements/segment"; }
 // & { @import "~semantic-ui-less/definitions/elements/step"; }
 
 /* Collections */
diff --git a/website/client/components/inventory/stable.vue b/website/client/components/inventory/stable.vue
index defda26840..3e50b471e9 100644
--- a/website/client/components/inventory/stable.vue
+++ b/website/client/components/inventory/stable.vue
@@ -9,35 +9,35 @@
     .ui.form
       .field
         .ui.checkbox
-          input(type='checkbox')
+          input(type="checkbox")
           label.label-primary(v-once) {{ $t('pets') }}
       .field.nested-field
         .ui.checkbox
-          input(type='checkbox')
+          input(type="checkbox")
           label(v-once) {{ $t('hatchingPotions') }}
       .field.nested-field
         .ui.checkbox
-          input(type='checkbox')
+          input(type="checkbox")
           label(v-once) {{ $t('quest') }}
       .field.nested-field
         .ui.checkbox
-          input(type='checkbox')
+          input(type="checkbox")
           label(v-once) {{ $t('special') }}
       .field
         .ui.checkbox
-          input(type='checkbox')
+          input(type="checkbox")
           label.label-primary(v-once) {{ $t('mounts') }}
       .field.nested-field
         .ui.checkbox
-          input(type='checkbox')
+          input(type="checkbox")
           label(v-once) {{ $t('hatchingPotions') }}
       .field.nested-field
         .ui.checkbox
-          input(type='checkbox')
+          input(type="checkbox")
           label(v-once) {{ $t('quest') }}
       .field.nested-field
         .ui.checkbox
-          input(type='checkbox')
+          input(type="checkbox")
           label(v-once) {{ $t('special') }}
 
   .thirteen.wide.column
@@ -60,18 +60,9 @@
     h2 Mounts
     h2 Quest Mounts
     h2 Rare Mounts
-
 </template>
 
 <style>
-.label-primary {
-  font-weight: bold;
-}
-
-.nested-field {
-  padding-left: 1.5rem;
-}
-
 .inventory-item-container {
   padding: 20px;
   border: 1px solid;
diff --git a/website/client/components/social/guilds/discovery/index.vue b/website/client/components/social/guilds/discovery/index.vue
new file mode 100644
index 0000000000..026e176531
--- /dev/null
+++ b/website/client/components/social/guilds/discovery/index.vue
@@ -0,0 +1,47 @@
+<template lang="pug">
+.ui.grid
+  .three.wide.column
+    .ui.left.icon.input
+      i.search.icon
+      input(type="text", :placeholder="$t('search')")
+    h3(v-once) {{ $t('filter') }}
+
+    .ui.form
+      h4 Interests
+      .field
+        .ui.checkbox
+          input(type="checkbox")
+          label(v-once) Habitica Official
+      .field
+        .ui.checkbox
+          input(type="checkbox")
+          label(v-once) Nature
+      .field
+        .ui.checkbox
+          input(type="checkbox")
+          label(v-once) Animals
+
+  .thirteen.wide.column
+    h2(v-once) {{ $t('publicGuilds') }}
+    public-guild-item(v-for="guild in guilds", :key='guild._id', :guild="guild")
+</template>
+
+<script>
+import { mapState, mapActions } from '../../../../store';
+import PublicGuildItem from './publicGuildItem';
+
+export default {
+  components: { PublicGuildItem },
+  computed: {
+    ...mapState(['guilds']),
+  },
+  methods: {
+    ...mapActions({
+      fetchGuilds: 'guilds:fetchAll',
+    }),
+  },
+  created () {
+    if (!this.guilds) this.fetchGuilds();
+  },
+};
+</script>
diff --git a/website/client/components/social/guilds/discovery/publicGuildItem.vue b/website/client/components/social/guilds/discovery/publicGuildItem.vue
new file mode 100644
index 0000000000..03af6ff937
--- /dev/null
+++ b/website/client/components/social/guilds/discovery/publicGuildItem.vue
@@ -0,0 +1,24 @@
+<template lang="pug">
+.ui.clearing.raised.segment
+  .ui.right.floated.button(:class="[isMember ? 'red' : 'green']") {{ isMember ? $t('leave') : $t('join') }}
+  .floated
+    // TODO v-once?
+    h3.ui.header {{ guild.name }}
+    p {{ guild.description }}
+</template>
+
+<script>
+import { mapState } from '../../../../store';
+import groupUtilities from '../../../../mixins/groupsUtilities';
+
+export default {
+  mixins: [groupUtilities],
+  props: ['guild'],
+  computed: {
+    ...mapState(['user']),
+    isMember () {
+      return this.isMemberOfGroup(this.user, this.guild);
+    },
+  },
+};
+</script>
\ No newline at end of file
diff --git a/website/client/components/social/index.vue b/website/client/components/social/index.vue
index 86375c32fd..5cd1e33ca4 100644
--- a/website/client/components/social/index.vue
+++ b/website/client/components/social/index.vue
@@ -1,9 +1,11 @@
 <template lang="pug">
 .row
   .sixteen.wide.column
-    .ui.secondary.menu
+    .ui.secondary.menu.center-content
       router-link.item(:to="{name: 'tavern'}")
         span(v-once) {{ $t('tavern') }}
+      router-link.item(:to="{name: 'guilds'}")
+        span(v-once) {{ $t('guilds') }}
       router-link.item(:to="{name: 'inbox'}")
         span(v-once) {{ $t('inbox') }}
 
diff --git a/website/client/mixins/groupsUtilities.js b/website/client/mixins/groupsUtilities.js
new file mode 100644
index 0000000000..664356247f
--- /dev/null
+++ b/website/client/mixins/groupsUtilities.js
@@ -0,0 +1,25 @@
+// TODO if we only have a single method here, move it to an utility
+// a full mixin is not needed
+
+import { TAVERN_ID } from '../../common/script/constants';
+
+export default {
+  methods: {
+    isMemberOfGroup (user, group) {
+      if (group._id === TAVERN_ID) return true;
+
+      // If the group is a guild, just check for an intersection with the
+      // current user's guilds, rather than checking the members of the group.
+      if (group.type === 'guild') {
+        return user.guilds.indexOf(group._id) !== -1;
+      }
+
+      // Similarly, if we're dealing with the user's current party, return true.
+      if (group.type === 'party') {
+        return user.party._id === group._id;
+      }
+
+      return false;
+    },
+  },
+};
\ No newline at end of file
diff --git a/website/client/router.js b/website/client/router.js
index 8e6400c553..f3763402e8 100644
--- a/website/client/router.js
+++ b/website/client/router.js
@@ -18,6 +18,7 @@ import SocialContainer from './components/social/index';
 import TavernPage from './components/social/tavern';
 import InboxPage from './components/social/inbox/index';
 import InboxConversationPage from './components/social/inbox/conversationPage';
+import GuildsDiscoveryPage from './components/social/guilds/discovery/index';
 
 Vue.use(VueRouter);
 
@@ -60,7 +61,17 @@ export default new VueRouter({
         },
         { name: 'challenges', path: 'challenges', component: Page },
         { name: 'party', path: 'party', component: Page },
-        { name: 'guilds', path: 'guilds', component: Page },
+        {
+          path: 'guilds',
+          component: EmptyView,
+          children: [
+            {
+              name: 'guilds',
+              path: '',
+              component: GuildsDiscoveryPage,
+            },
+          ],
+        },
       ],
     },
     {
diff --git a/website/client/store/actions/guilds.js b/website/client/store/actions/guilds.js
new file mode 100644
index 0000000000..9e0676957c
--- /dev/null
+++ b/website/client/store/actions/guilds.js
@@ -0,0 +1,6 @@
+import axios from 'axios';
+
+export async function fetchAll (store) {
+  let response = await  axios.get('/api/v3/groups?type=publicGuilds');
+  store.state.guilds = response.data.data;
+}
\ No newline at end of file
diff --git a/website/client/store/actions/index.js b/website/client/store/actions/index.js
index d2b632efe0..4a43075408 100644
--- a/website/client/store/actions/index.js
+++ b/website/client/store/actions/index.js
@@ -1,13 +1,16 @@
 import { flattenAndNamespace } from '../helpers/internals';
-import * as tasks from './tasks';
-import * as user from './user';
 
-// Actions should be named as 'actionName' and can be accessed as 'namespace.actionName'
-// Example: fetch in user.js -> 'user.fetch'
+import * as user from './user';
+import * as tasks from './tasks';
+import * as guilds from './guilds';
+
+// Actions should be named as 'actionName' and can be accessed as 'namespace:actionName'
+// Example: fetch in user.js -> 'user:fetch'
 
 const actions = flattenAndNamespace({
   user,
   tasks,
+  guilds,
 });
 
 export default actions;
\ No newline at end of file
diff --git a/website/client/store/getters/index.js b/website/client/store/getters/index.js
index 4c3a5a0374..6fe691d460 100644
--- a/website/client/store/getters/index.js
+++ b/website/client/store/getters/index.js
@@ -1,8 +1,8 @@
 import { flattenAndNamespace } from '../helpers/internals';
 import * as user from './user';
 
-// Getters should be named as 'getterName' and can be accessed as 'namespace.getterName'
-// Example: gems in user.js -> 'user.gems'
+// Getters should be named as 'getterName' and can be accessed as 'namespace:getterName'
+// Example: gems in user.js -> 'user:gems'
 
 const getters = flattenAndNamespace({
   user,
diff --git a/website/client/store/helpers/internals.js b/website/client/store/helpers/internals.js
index 01f06997a2..e6999e932e 100644
--- a/website/client/store/helpers/internals.js
+++ b/website/client/store/helpers/internals.js
@@ -14,10 +14,10 @@ Example:
 
   Result:
     getters
-      user.gems
-      user.tasks
-      tasks.todos
-      tasks.dailys
+      user:gems
+      user:tasks
+      tasks:todos
+      tasks:dailys
 */
 export function flattenAndNamespace (namespaces) {
   let result = {};
diff --git a/website/client/store/state.js b/website/client/store/state.js
index 02c0b1b27b..5939cf217c 100644
--- a/website/client/store/state.js
+++ b/website/client/store/state.js
@@ -5,6 +5,7 @@ const state = {
   title: 'Habitica',
   user: null,
   tasks: null, // user tasks
+  guilds: null, // list of public guilds, not fetched initially
   // content data, frozen to prevent Vue from modifying it since it's static and never changes
   // TODO apply freezing to the entire codebase (the server) and not only to the client side?
   // NOTE this takes about 10-15ms on a fast computer