krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-16 14:17:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

Only unequip Gen 1 pets/mounts when releasing pets/mounts, fixes #5366 (#8119)

Browse Source 
* Only unequip Gen 1 pets/mounts when releasing pets/mounts

* Changed mount declaration to match releasePets

* Check if a pet/mount is a drop type instead of checking for its name in the list of pets

* Changed references to pet and mount to petInfo and mountInfo for consistency with releasePets and releaseMounts

* Test that releasePets, releaseMounts, and releaseBoth do not unequip quest pets

* Fixed test names, and tests verify that a pet/mount is/is not a drop pet/mount on release

* Removed unneeded comments
This commit is contained in:
Alyssa Batula
2016-10-20 23:00:15 -04:00
committed by Blade Barringer
parent 2e2dc179c4
commit d2756278c3
6 changed files with 81 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
test/common/ops/releaseMounts.js
View File

@@ -1,4 +1,5 @@
import releaseMounts from '../../../website/common/script/ops/releaseMounts';
import content from '../../../website/common/script/content/index';
import i18n from '../../../website/common/script/i18n';
import {
generateUser,
@@ -37,12 +38,26 @@ describe('shared.ops.releaseMounts', () => {
expect(user.items.mounts[animal]).to.equal(null);
});
it('removes currentMount', () => {
it('removes drop currentMount', () => {
let mountInfo = content.mountInfo[user.items.currentMount];
expect(mountInfo.type).to.equal('drop');
releaseMounts(user);
expect(user.items.currentMount).to.be.empty;
});
it('leaves non-drop mount equipped', () => {
let questAnimal = 'Gryphon-Base';
user.items.currentMount = questAnimal;
user.items.mounts[questAnimal] = true;
let mountInfo = content.mountInfo[user.items.currentMount];
expect(mountInfo.type).to.not.equal('drop');
releaseMounts(user);
expect(user.items.currentMount).to.equal(questAnimal);
});
it('increases mountMasterCount achievement', () => {
releaseMounts(user);