krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-17 22:57:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Ensured leader doesn't change with group plans (#10480)

Browse Source
This commit is contained in:
Keith Holliday
2018-06-28 04:57:24 -05:00
committed by Matteo Pagliazzi
parent 6659d4fa52
commit cbcf5a03e1
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
website/server/controllers/api-v3/groups.js
View File

@@ -588,7 +588,8 @@ api.joinGroup = {
}
if (!isUserInvited) throw new NotAuthorized(res.t('messageGroupRequiresInvite'));
if (group.memberCount === 0) group.leader = user._id; // If new user is only member -> set as leader
// @TODO: Review the need for this and if still needed, don't base this on memberCount
if (!group.hasNotCancelled() && group.memberCount === 0) group.leader = user._id; // If new user is only member -> set as leader
if (group.hasNotCancelled()) {
await payments.addSubToGroupUser(user, group);