krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 07:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add challenge select winner test for broken and winner flags of challenge tasks

Browse Source
This commit is contained in:
Kristian Tashkov
2016-01-28 22:01:39 +02:00
parent 6dce552140
commit c52064b3df
2 changed files with 27 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
test/api/v3/integration/challenges/POST-challenges_challengeId_winner_winnerId.test.js
View File

@@ -44,6 +44,7 @@ describe('POST /challenges/:challengeId/winner/:winnerId', () => {
let group; let group;
let challenge; let challenge;
let winningUser; let winningUser;
let taskText = 'A challenge task text';
beforeEach(async () => { beforeEach(async () => {
let populatedGroup = await createAndPopulateGroup({ let populatedGroup = await createAndPopulateGroup({
@@ -59,7 +60,7 @@ describe('POST /challenges/:challengeId/winner/:winnerId', () => {
}); });
await groupLeader.post(`/tasks/challenge/${challenge._id}`, [ await groupLeader.post(`/tasks/challenge/${challenge._id}`, [
{type: 'habit', text: 'A challenge task text'}, {type: 'habit', text: taskText},
]); ]);
await winningUser.post(`/challenges/${challenge._id}/join`); await winningUser.post(`/challenges/${challenge._id}/join`);
@@ -110,5 +111,29 @@ describe('POST /challenges/:challengeId/winner/:winnerId', () => {
await expect(winningUser.sync()).to.eventually.have.property('balance', oldBalance + challenge.prize / 4); await expect(winningUser.sync()).to.eventually.have.property('balance', oldBalance + challenge.prize / 4);
}); });
it('doesn\'t refund gems to group leader', async () => {
let oldBalance = (await groupLeader.sync()).balance;
await groupLeader.post(`/challenges/${challenge._id}/selectWinner/${winningUser._id}`);
await sleep(0.5);
await expect(groupLeader.sync()).to.eventually.have.property('balance', oldBalance);
});
it('sets broken and winner flags for user\'s challenge tasks', async () => {
await groupLeader.post(`/challenges/${challenge._id}/selectWinner/${winningUser._id}`);
await sleep(0.5);
let tasks = await winningUser.get('/tasks/user');
let testTask = _.find(tasks, (task) => {
return task.text === taskText;
});
expect(testTask.challenge.broken).to.eql('CHALLENGE_CLOSED');
expect(testTask.challenge.winner).to.eql(winningUser.profile.name);
});
}); });
}); });

2
website/src/controllers/api-v3/challenges.js
View File

@@ -467,7 +467,7 @@ api.selectChallengeWinner = {
res.respond(200, {}); res.respond(200, {});
// Close channel in background // Close channel in background
_closeChal(challenge, {broken: 'CHALLENGE_DELETED', winner}); _closeChal(challenge, {broken: 'CHALLENGE_CLOSED', winner});
}, },
}; };