krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 15:17:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

handle error from invalid input

Browse Source
This commit is contained in:
Phillip Thelen
2024-06-10 11:23:46 +02:00
parent 3313584d60
commit c2b370f4d3
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/common/ops/unlock.js → test/common/ops/unlock.test.js
View File

@@ -36,7 +36,7 @@ describe('shared.ops.unlock', () => {
} }
}); });
it('does not unlock lost gear', async () => { it('does not unlock lost gear', async () => {
user.items.gear.owned.headAccessory_special_bearEars = false; user.items.gear.owned.headAccessory_special_bearEars = false;
await unlock(user, { await unlock(user, {
@@ -345,4 +345,13 @@ describe('shared.ops.unlock', () => {
expect(get(user.purchased, backgroundUnlockPath)).to.be.true; expect(get(user.purchased, backgroundUnlockPath)).to.be.true;
expect(user.balance).to.equal(usersStartingGems - 1.75); expect(user.balance).to.equal(usersStartingGems - 1.75);
}); });
it('handles an invalid hair path gracefully', async () => {
try {
await unlock(user, { query: { path: 'hair.invalid' } });
} catch (err) {
expect(err).to.be.an.instanceof(BadRequest);
expect(err.message).to.equal(i18n.t('invalidUnlockSet'));
}
});
}); });

1
website/common/script/ops/unlock.js
View File

@@ -36,6 +36,7 @@ function getItemByPath (path, setType) {
if (setType === 'hair') { if (setType === 'hair') {
// itemPathParent is in this format: hair.purple // itemPathParent is in this format: hair.purple
const hairType = itemPathParent.split('.')[1]; const hairType = itemPathParent.split('.')[1];
if (!content.appearances.hair[hairType]) return null;
return content.appearances.hair[hairType][itemKey]; return content.appearances.hair[hairType][itemKey];
} }