krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 07:07:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix user model, sanitize some fields on task creation, add some tests and comments

Browse Source
This commit is contained in:
Matteo Pagliazzi
2015-12-03 18:15:22 +01:00
parent 506609cc29
commit c0a99eec8b
4 changed files with 36 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
website/src/controllers/api-v3/tasks.js
View File

@@ -31,16 +31,16 @@ api.createTask = {
let user = res.locals.user;
let taskType = req.body.type;
let newTask = new Tasks[taskType](Tasks.Task.sanitize(req.body));
let newTask = new Tasks[taskType](Tasks.Task.sanitizeCreate(req.body));
newTask.userId = user._id;
user.tasksOrder[taskType].unshift(newTask._id);
user.tasksOrder[taskType + 's'].unshift(newTask._id);
Q.all([
newTask.save(),
user.save(),
])
.then(([task]) => res.respond(201, task))
.then((results) => res.respond(201, results[0]))
.catch(next);
},
};
@@ -478,7 +478,7 @@ api.deleteTask = {
let validationErrors = req.validationErrors();
if (validationErrors) return next(validationErrors);
Tasks.Task.findOne({
_id: req.params.taskId,
userId: user._id,