krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 15:17:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Validate that everyX values in dailies are integers bounded by 0 and 9999 fixes #8782 (#9268)

Browse Source 
* Validate that everyX values are integers bounded by 0 and 9999

* Added client side check

* Updated tests

* Added migration for bad dailies

Near idential to the other task migration.

* fix(typo): camelCase function call
This commit is contained in:
Tyler Nychka
2017-12-05 14:55:32 -05:00
committed by Sabe Jones
parent 8367de34bf
commit bfaa7c0fea
5 changed files with 135 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
test/api/v3/integration/tasks/POST-tasks_user.test.js
View File

@@ -628,6 +628,43 @@ describe('POST /tasks/user', () => {
});
});
it('returns an error if everyX is a non int', async () => {
await expect(user.post('/tasks/user', {
text: 'test daily',
type: 'daily',
everyX: 2.5,
})).to.eventually.be.rejected.and.eql({
code: 400,
error: 'BadRequest',
message: 'daily validation failed',
});
});
it('returns an error if everyX is negative', async () => {
await expect(user.post('/tasks/user', {
text: 'test daily',
type: 'daily',
everyX: -1,
})).to.eventually.be.rejected.and.eql({
code: 400,
error: 'BadRequest',
message: 'daily validation failed',
});
});
it('returns an error if everyX is above 9999', async () => {
await expect(user.post('/tasks/user', {
text: 'test daily',
type: 'daily',
everyX: 10000,
})).to.eventually.be.rejected.and.eql({
code: 400,
error: 'BadRequest',
message: 'daily validation failed',
});
});
it('can create checklists', async () => {
let task = await user.post('/tasks/user', {
text: 'test daily',